Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: Import gz.math at startup to fix #1129 #1130

Merged
merged 4 commits into from
Sep 30, 2022

Conversation

willstott101
Copy link
Contributor

@willstott101 willstott101 commented Sep 7, 2022

🦟 Bug fix

Fixes #

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #1130 (874a8c7) into sdf13 (1e5be74) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##            sdf13    #1130   +/-   ##
=======================================
  Coverage   87.05%   87.05%           
=======================================
  Files         125      125           
  Lines       15885    15887    +2     
=======================================
+ Hits        13828    13830    +2     
  Misses       2057     2057           
Impacted Files Coverage Δ
python/src/sdf/_gz_sdformat_pybind11.cc 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

…failure due to gz.math not always being imported.

Signed-off-by: Will Stott <willstott101@gmail.com>
Signed-off-by: Will Stott <willstott101@gmail.com>
@azeey
Copy link
Collaborator

azeey commented Sep 13, 2022

Thanks for the PR @willstott101. We are currently under code freeze in preparation for the Garden release. Since there's a workaround for this as discussed in #1129, we'll wait to review/merge this until Garden is released.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Copy link
Collaborator

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty to merge from sdf13 and make changes so the correct version of gz.math is imported.

@willstott101
Copy link
Contributor Author

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants