-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python: Import gz.math at startup to fix #1129 #1130
Conversation
Codecov Report
@@ Coverage Diff @@
## sdf13 #1130 +/- ##
=======================================
Coverage 87.05% 87.05%
=======================================
Files 125 125
Lines 15885 15887 +2
=======================================
+ Hits 13828 13830 +2
Misses 2057 2057
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…failure due to gz.math not always being imported. Signed-off-by: Will Stott <willstott101@gmail.com>
Signed-off-by: Will Stott <willstott101@gmail.com>
c7c6bda
to
70597a1
Compare
Thanks for the PR @willstott101. We are currently under code freeze in preparation for the Garden release. Since there's a workaround for this as discussed in #1129, we'll wait to review/merge this until Garden is released. |
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took the liberty to merge from sdf13
and make changes so the correct version of gz.math
is imported.
thanks! |
🦟 Bug fix
Fixes #
Summary
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.