World: sdfwarns to sdf::Errors when warnings policy set to sdf::EnforcementPolicy::ERR

[marcoag]

Signed-off-by: Marco A. Gutierrez marco@openrobotics.org

🎉 New feature

Work towards #820.

Summary

Makes warnings to be reported through sdf::Errors when using the Load method of the World class and the warnings policy is set to sdf::EnforcementPolicy::ERR.

@azeey found this duplicated code. It seems do the same exact check than the previous loop so I removed one of them in this PR. It seems to keep passing tests but maybe better to double check in case I'm missing something there.

Test it

When using the Load method of the World class and setting the warnings policy to sdf::EnforcementPolicy::ERR warnings should be reported through in the sdf::Errors structure.

Checklist

• Signed all commits for DCO
• Added tests
• Added example and/or tutorial
• Updated documentation (as needed)
• Updated migration guide (as needed)
• Consider updating Python bindings (if the library has them)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

[codecov]

Codecov Report

Merging #1131 (e0c1242) into main (19ed749) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head e0c1242 differs from pull request most recent head 79fd6fb. Consider uploading reports for the commit 79fd6fb to get more accurate results

@@           Coverage Diff           @@
##             main    #1131   +/-   ##
=======================================
  Coverage   86.70%   86.71%           
=======================================
  Files         125      125           
  Lines       15965    15964    -1     
=======================================
  Hits        13843    13843           
+ Misses       2122     2121    -1     

Impacted Files	Coverage Δ
src/World.cc	95.52% <100.00%> (-0.02%)	⬇️
src/Utils.cc	86.54% <0.00%> (+0.58%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.