Uplift several sidebar fixes (uplift to 1.37.x) #12624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix brave/brave-browser#21060 Introduced new IDS_SETTINGS_SIDEBAR_SHOW_OPTION_TITLE. Although it uses same string with IDS_SIDEBAR_SHOW_OPTION_TITLE, made different string id to prevent future regression. IDS_SIDEBAR_SHOW_OPTION_TITLE was shared by many other UI such as app menu or context menu.
fix brave/brave-browser#21597 In some languages, header text is truncated due to long translated message. To prevent this, header label length is not fixed.
|
|
fix brave/brave-browser#21590 So far, sidebar can't aligned with custom theme because sidebar only knows brave's dark/light theme color. With below changes, sidebar colors are aligned well with custom theme also. Used toolbar color as a sidebar background color. Used toolbar button's hover color for sidebar item/arrow button hover color. Picked proper color between light/dark color for builtin item icon color based on toolbar color. Used toolbar area separator color(separator between toolbar and web contents) for sidebar border.
fix brave/brave-browser#21726 On Stable, sidebar is not visible by default. Otherwise, it's shown.
kjozwiak
approved these changes
Mar 18, 2022
There was a problem hiding this comment.
Uplift into 1.37.x approved 👍 QA has verified the PR on Nightly as per #12596 (comment), #12618 (comment), #12589 (comment), #12578 (comment) and #12644 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uplift of #12596 #12618 #12589 #12578 #12644
Resolves brave/brave-browser#21655
Resolves brave/brave-browser#21014
Resolves brave/brave-browser#21060
Resolves brave/brave-browser#21597
Resolves brave/brave-browser#21590
Resolves brave/brave-browser#21726
Pre-approval checklist:
Pre-merge checklist:
Post-merge checklist: