Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add to Sidebar text is truncated in Bulgarian locale #21597

Closed
Tracked by #14980
Tonev opened this issue Mar 11, 2022 · 5 comments · Fixed by brave/brave-core#12589
Closed
Tracked by #14980

Add to Sidebar text is truncated in Bulgarian locale #21597

Tonev opened this issue Mar 11, 2022 · 5 comments · Fixed by brave/brave-core#12589
Assignees
@simonhong
Labels
bug feature/sidebar Relating to Brave's Sidebar feature l10n OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.37.x - Release

Comments

@Tonev
Copy link
Contributor

Tonev commented Mar 11, 2022

Description

Hovering on the + icon in the sidebar will display truncated text while Brave is displayed in Bulgarian.

Steps to Reproduce

  1. Set Brave to be displayed in Bulgarian.
  2. Make sure Sidebar is displayed.
  3. Open a page that can be added to the Sidebar, for example brave://settings/.
  4. Hover on the + icon in the Sidebar.

Actual result:

Untitled

Expected result:

I guess it could be made so any text longer than X to be displayed on 2 lines to avoid truncation.

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.38.35 Chromium: 99.0.4844.51 (Official Build) nightly (64-bit)
Revision d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS Windows 7 Service Pack 1 (Build 7601)
@stephendonner stephendonner added bug QA/Yes feature/sidebar Relating to Brave's Sidebar feature labels Mar 11, 2022
@rebron
Copy link
Collaborator

rebron commented Mar 11, 2022

cc: @simonhong

@rebron rebron added l10n priority/P2 A bad problem. We might uplift this to the next planned release. labels Mar 11, 2022
@simonhong simonhong self-assigned this Mar 14, 2022
@simonhong
Copy link
Member

@rebron Which one is more better for long string? Multi line vs. Single line
Screenshot 2022-03-14 153922
Screenshot 2022-03-14 154103

simonhong added a commit to brave/brave-core that referenced this issue Mar 14, 2022
@simonhong
Fixed sidebar item add bubble header text is truncated
4b965b8 
fix brave/brave-browser#21597

In some languages, header text is truncated due to long translated
message. To prevent this, header label is set as multiline.
@simonhong simonhong mentioned this issue Mar 14, 2022
Merged
25 tasks
@rebron
Copy link
Collaborator

rebron commented Mar 15, 2022

@simonhong Single line.

@rebron rebron mentioned this issue Mar 15, 2022
Closed
28 tasks
simonhong added a commit to brave/brave-core that referenced this issue Mar 15, 2022
@simonhong
Fixed sidebar item add bubble header text is truncated
a5912f6 
fix brave/brave-browser#21597

In some languages, header text is truncated due to long translated
message. To prevent this, header label length is not fixed.
@simonhong simonhong added this to the 1.38.x - Nightly milestone Mar 16, 2022
simonhong added a commit to brave/brave-core that referenced this issue Mar 16, 2022
@simonhong
Fixed sidebar item add bubble header text is truncated
3cefd48 
fix brave/brave-browser#21597

In some languages, header text is truncated due to long translated
message. To prevent this, header label length is not fixed.
@simonhong simonhong mentioned this issue Mar 16, 2022
Merged
7 tasks
muliswilliam pushed a commit to brave/brave-core that referenced this issue Mar 16, 2022
@simonhong @muliswilliam
Fixed sidebar item add bubble header text is truncated
cee00ac 
fix brave/brave-browser#21597

In some languages, header text is truncated due to long translated
message. To prevent this, header label length is not fixed.
@kjozwiak
Copy link
Member

Above issue requires 1.37.98 or higher for verification on 1.37.x.

@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.37.98 Chromium: 99.0.4844.74 (Официално издание) beta (64 бита)
-- | --
Ревизия | fee9a47e86e981802390cb0d41c5ed7ea93c4f6f-refs/branch-heads/4844@{#1060}
ОС | Windows 10 Version 21H2 (Build 19044.1586)
  • Verified the STR from the description and ensured Add to Sidebar text is NOT truncated in Bulgarian locale
Normal window Private window TOR window
image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
bug feature/sidebar Relating to Brave's Sidebar feature l10n OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.37.x - Release
Development

Successfully merging a pull request may close this issue.

Fixed sidebar item add bubble header text is truncated brave/brave-core
6 participants
@stephendonner @kjozwiak @rebron @simonhong @Tonev @GeetaSarvadnya