Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed sidebar item add bubble header text is truncated #12589

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Mar 14, 2022

fix brave/brave-browser#21597

In some languages, header text is truncated due to long translated
message. To prevent this, header label length is not fixed.

image

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See the STR in the linked issue.

@simonhong simonhong self-assigned this Mar 14, 2022
@simonhong simonhong marked this pull request as ready for review March 15, 2022 11:41
@simonhong simonhong force-pushed the sidebar_item_add_bubble_header_long_string branch from 4b965b8 to 0e97466 Compare March 15, 2022 11:41
@simonhong simonhong requested a review from nullhook March 15, 2022 11:41
@github-actions github-actions bot added rebase and removed rebase labels Mar 15, 2022
@brave-builds brave-builds force-pushed the sidebar_item_add_bubble_header_long_string branch from 0e97466 to f28b42b Compare March 15, 2022 11:43
fix brave/brave-browser#21597

In some languages, header text is truncated due to long translated
message. To prevent this, header label length is not fixed.
@simonhong simonhong force-pushed the sidebar_item_add_bubble_header_long_string branch from f28b42b to a5912f6 Compare March 15, 2022 23:39
@simonhong simonhong added this to the 1.38.x - Nightly milestone Mar 16, 2022
@simonhong simonhong merged commit b57d4b5 into master Mar 16, 2022
@simonhong simonhong deleted the sidebar_item_add_bubble_header_long_string branch March 16, 2022 03:40
@stephendonner
Copy link
Contributor

Verified PASSED using

Brave 1.38.49 Chromium: 99.0.4844.74 (Официално издание) nightly (64 бита)
Ревизия fee9a47e86e981802390cb0d41c5ed7ea93c4f6f-refs/branch-heads/4844@{#1060}
ОС Windows 10 Version 21H2 (Build 19044.1586)

1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add to Sidebar text is truncated in Bulgarian locale
3 participants