-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust sidebar colors #12578
Adjust sidebar colors #12578
Conversation
20b618b
to
641a976
Compare
641a976
to
6dfe04f
Compare
@bradleyrichter PTAL this color changes. I can't add you in the reviewer list. |
6dfe04f
to
165d0e3
Compare
i see conflicts |
fix brave/brave-browser#21590 So far, sidebar can't aligned with custom theme because sidebar only knows brave's dark/light theme color. With below changes, sidebar colors are aligned well with custom theme also. Used toolbar color as a sidebar background color. Used toolbar button's hover color for sidebar item/arrow button hover color. Picked proper color between light/dark color for builtin item icon color based on toolbar color. Used toolbar area separator color(separator between toolbar and web contents) for sidebar border.
165d0e3
to
92c133d
Compare
Fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Verified
Confirmed creating a new, colored profile in both
|
fix brave/brave-browser#21590
So far, sidebar can't aligned with custom theme
because sidebar only knows brave's dark/light theme color.
With below changes, sidebar colors are aligned well with custom theme also.
Used toolbar color as a sidebar background color.
Used toolbar button's hover color for sidebar item/arrow button hover color.
Picked proper color between light/dark color for builtin item icon color based on toolbar color.
Used toolbar area separator color(separator between toolbar and web contents) for sidebar border.
Resolves
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: