Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar color does not adhere to a new profile theme color #21590

Closed
Tracked by #14980
btlechowski opened this issue Mar 10, 2022 · 2 comments · Fixed by brave/brave-core#12578
Closed
Tracked by #14980

Sidebar color does not adhere to a new profile theme color #21590

btlechowski opened this issue Mar 10, 2022 · 2 comments · Fixed by brave/brave-core#12578
Assignees
@simonhong
Labels
bug feature/sidebar Relating to Brave's Sidebar feature OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.37.x - Release

Comments

@btlechowski
Copy link

Follow up to #21013

Steps to Reproduce

  1. Clean profile
  2. Run Brave
  3. Create a new profile

Actual result:

Sidebar color does not adhere to a new profile theme color
image

Expected result:

Sidebar color does adhere to a new profile theme color

For example private window:
image

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.37.86 Chromium: 99.0.4844.51 (Official Build) beta (64-bit)
Revision d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS Ubuntu 18.04 LTS
Brave 1.38.35 Chromium: 99.0.4844.51 (Oficjalna wersja) nightly (64-bitowa)
Wersja d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
System operacyjny Windows 7 Service Pack 1 (Build 7601.24544)

cc @brave/legacy_qa @rebron @simonhong
@simonhong simonhong self-assigned this Mar 11, 2022
simonhong added a commit to brave/brave-core that referenced this issue Mar 11, 2022
@simonhong
WIP: Adjust sidebar colors
20b618b 
fix brave/brave-browser#21590
@simonhong simonhong mentioned this issue Mar 11, 2022
Merged
25 tasks
simonhong added a commit to brave/brave-core that referenced this issue Mar 14, 2022
@simonhong
Adjust sidebar colors
6dfe04f 
fix brave/brave-browser#21590

Use toolbar color as a sidebar background color.
Use toolbar button's hover color for sidebar item/arrow button hover color.
Pick proper color for builtin item icon color based on toolbar color.
Use toolbar area separator color for sidebar border.

With these changes, sidebar colors are aligned well with custom theme also.
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Mar 14, 2022
@rebron rebron mentioned this issue Mar 15, 2022
Closed
28 tasks
simonhong added a commit to brave/brave-core that referenced this issue Mar 16, 2022
@simonhong
Adjust sidebar colors
92c133d 
fix brave/brave-browser#21590

So far, sidebar can't aligned with custom theme
because sidebar only knows brave's dark/light theme color.

With below changes, sidebar colors are aligned well with custom theme also.

Used toolbar color as a sidebar background color.
Used toolbar button's hover color for sidebar item/arrow button hover color.
Picked proper color between light/dark color for builtin item icon color based on toolbar color.
Used toolbar area separator color(separator between toolbar and web contents) for sidebar border.
@simonhong simonhong added this to the 1.38.x - Nightly milestone Mar 16, 2022
simonhong added a commit to brave/brave-core that referenced this issue Mar 16, 2022
@simonhong
Adjust sidebar colors
1bca6da 
fix brave/brave-browser#21590

So far, sidebar can't aligned with custom theme
because sidebar only knows brave's dark/light theme color.

With below changes, sidebar colors are aligned well with custom theme also.

Used toolbar color as a sidebar background color.
Used toolbar button's hover color for sidebar item/arrow button hover color.
Picked proper color between light/dark color for builtin item icon color based on toolbar color.
Used toolbar area separator color(separator between toolbar and web contents) for sidebar border.
@simonhong simonhong mentioned this issue Mar 16, 2022
Merged
7 tasks
@kjozwiak
Copy link
Member

Above issue requires 1.37.98 or higher for verification on 1.37.x.

@GeetaSarvadnya
Copy link

Verification PASSED on


Brave | 1.37.98 Chromium: 99.0.4844.74 (Official Build) beta (64-bit)
-- | --
Revision | fee9a47e86e981802390cb0d41c5ed7ea93c4f6f-refs/branch-heads/4844@{#1060}
OS | Windows 10 Version 21H2 (Build 19044.1586)
  • Verified the STR from the description and ensured sidebar color adhere to the new profile theme color
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
bug feature/sidebar Relating to Brave's Sidebar feature OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.37.x - Release
Development

Successfully merging a pull request may close this issue.

Adjust sidebar colors brave/brave-core
6 participants
@stephendonner @kjozwiak @rebron @simonhong @btlechowski @GeetaSarvadnya