Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable sidebar in private window #21013

Closed
simonhong opened this issue Feb 10, 2022 · 3 comments · Fixed by brave/brave-core#12203
Closed

Enable sidebar in private window #21013

simonhong opened this issue Feb 10, 2022 · 3 comments · Fixed by brave/brave-core#12203
Assignees
@simonhong
Labels
feature/sidebar Relating to Brave's Sidebar feature OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.37.x - Release

Comments

@simonhong
Copy link
Member

No description provided.

@simonhong simonhong self-assigned this Feb 10, 2022
@simonhong simonhong mentioned this issue Feb 10, 2022
Merged
25 tasks
simonhong added a commit to brave/brave-core that referenced this issue Feb 10, 2022
@simonhong
Enable sidebar in private(tor) window
a22bb5a 
fix brave/brave-browser#21013

Sidebar items are shared with its parent profile(normal).
@simonhong simonhong added this to the 1.37.x - Nightly milestone Feb 11, 2022
@stephendonner
Copy link

Verified PASSED using

Brave 1.37.43 Chromium: 98.0.4758.87 (Official Build) nightly (x86_64)
Revision e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS macOS Version 11.6.1 (Build 20G224)

Steps:

  1. new profile
  2. launched Brave
  3. enabled Enable Sidebar via brave://flags
  4. opened a Private Window with Tor
  5. opened a Private Window
  6. opened a Guest window

Confirmed all windows opened with a working Sidebar.

Private Window with Tor Private Window Guest window
Screen Shot 2022-02-11 at 11 17 04 AM Screen Shot 2022-02-11 at 11 16 33 AM Screen Shot 2022-02-11 at 11 16 47 AM

@btlechowski
Copy link

Verification passed on

Brave 1.37.86 Chromium: 99.0.4844.51 (Official Build) beta (64-bit)
Revision d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS Ubuntu 18.04 LTS

Private
image
Private with Tor
image
Guest
image
Other profile
image

@btlechowski btlechowski mentioned this issue Mar 10, 2022
Closed
@MadhaviSeelam
Copy link

Brave 1.37.87 Chromium: 99.0.4844.51 (Official Build) beta (64-bit)
Revision d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS Windows 11 Version 21H2 (Build 22000.556)
  • Clean profile
  • Launched Brave
  • opened a Private Window with Tor
  • opened a Private Window
  • opened a Guest window

Verified all three windows opened with a Sidebar as a default

Note: Enable Sidebar flag is no longer available in Brave://flags. The flag was removed with #20876

Private Window with Tor Private Window Guest Window
private window with tor private window guest window

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
feature/sidebar Relating to Brave's Sidebar feature OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.37.x - Release
Development

Successfully merging a pull request may close this issue.

Enable sidebar in private(tor) window brave/brave-core
5 participants
@stephendonner @simonhong @LaurenWags @btlechowski @MadhaviSeelam