Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable sidebar in private(tor) window #12203

Merged
merged 1 commit into from
Feb 11, 2022
Merged

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Feb 10, 2022

fix brave/brave-browser#21013

Sidebar items are shared with its parent profile(normal).

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Launch browser and enable sidebar feature
  2. Re-launch and open private window(or tor)
  3. Check sidebar is enabled

@simonhong simonhong self-assigned this Feb 10, 2022
@simonhong simonhong force-pushed the enable_sidebar_in_private branch from 1f89d27 to 0e21fcf Compare February 10, 2022 02:47
@simonhong simonhong requested a review from bsclifton February 10, 2022 02:55
fix brave/brave-browser#21013

Sidebar items are shared with its parent profile(normal).
@simonhong simonhong force-pushed the enable_sidebar_in_private branch from 0e21fcf to a22bb5a Compare February 10, 2022 03:36
@bsclifton
Copy link
Member

bsclifton commented Feb 10, 2022

I built this PR locally and with the Sidebar flag enabled (brave://flags/#sidebar), the sidebar is not showing on Private window or Private window with Tor

Anything I might be missing?

@simonhong
Copy link
Member Author

I built this PR locally and with the Sidebar flag enabled (brave://flags/#sidebar), the sidebar is not showing on Private window or Private window with Tor

Anything I might be missing?

Hmm, strange...
I tested this PR on macOS and Linux. and private window has sidebar.

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good! Tested on Windows, works nicely 😄

Not sure what happened before; but redoing npm run sync and rebuilding worked perfect

@simonhong simonhong merged commit fb952b2 into master Feb 11, 2022
@simonhong simonhong deleted the enable_sidebar_in_private branch February 11, 2022 07:36
@simonhong simonhong added this to the 1.37.x - Nightly milestone Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable sidebar in private window
2 participants