This repository has been archived by the owner on Dec 6, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rstudio dev to Developer mainline
feat: Rstudio provisioning with ALB
…tack name to analysis-*
fix: Added ALB permission for SC launch constraint role
feat: Terminate ALB step in termination workflow
fix: incorporated PR comments on code style
Feat rstudio alb
Added unit test cases for alb-service
Fetching availability zones dynamically in alb cft
Fix: Incorporated PR comments
* fix: replace get with post rstudio connect
* feat: integrating appstream with rstudio-alb
Codecov Report
@@ Coverage Diff @@
## develop #807 +/- ##
===========================================
+ Coverage 50.46% 50.91% +0.44%
===========================================
Files 279 286 +7
Lines 15152 15931 +779
Branches 2404 2485 +81
===========================================
+ Hits 7647 8111 +464
- Misses 6573 6863 +290
- Partials 932 957 +25
Continue to review full report at Codecov.
|
* docs: rstudiodocs
* fix: remove legacy RStudio code * fix: update AMI readme * fix: link to post deployment guide
nguyen102
previously approved these changes
Nov 16, 2021
…ch-on-aws into chore-merge-feature-rstudio
Co-authored-by: Tim Nguyen <thingut@amazon.com>
nguyen102
approved these changes
Nov 18, 2021
jxuamazon
pushed a commit
to jxuamazon/service-workbench-on-aws
that referenced
this pull request
Feb 15, 2022
* Implementation for RstudioV2 (backed by ALB) feature
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
GALI-1231
Description of changes:
Merge RStudio-ALB feature onto develop.
Checklist:
AS review ticket id:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.