Skip to content
This repository has been archived by the owner on Dec 6, 2024. It is now read-only.

chore: merge feature rstudio #807

Merged
merged 97 commits into from
Nov 18, 2021
Merged

chore: merge feature rstudio #807

merged 97 commits into from
Nov 18, 2021

Conversation

SanketD92
Copy link
Contributor

@SanketD92 SanketD92 commented Nov 15, 2021

Issue #, if available:
GALI-1231

Description of changes:
Merge RStudio-ALB feature onto develop.

Checklist:

  • Have you successfully deployed to an AWS account with your changes?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully tested with your changes locally?

AS review ticket id:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

manikandan-thangavelu-rl and others added 30 commits May 17, 2021 20:54
feat: Rstudio provisioning with ALB
fix: Added ALB permission for SC launch constraint role
feat: Terminate ALB step in termination workflow
fix: incorporated PR comments on code style
Fetching availability zones dynamically in alb cft
@SanketD92 SanketD92 requested a review from a team as a code owner November 15, 2021 17:02
@SanketD92 SanketD92 changed the title Chore merge feature rstudio chore: merge feature rstudio Nov 15, 2021
@codecov
Copy link

codecov bot commented Nov 15, 2021

Codecov Report

Merging #807 (ab6c1f3) into develop (c6e04ca) will increase coverage by 0.44%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #807      +/-   ##
===========================================
+ Coverage    50.46%   50.91%   +0.44%     
===========================================
  Files          279      286       +7     
  Lines        15152    15931     +779     
  Branches      2404     2485      +81     
===========================================
+ Hits          7647     8111     +464     
- Misses        6573     6863     +290     
- Partials       932      957      +25     
Impacted Files Coverage Δ
src/parts/environments-sc/ScEnvironmentCard.js 34.84% <0.00%> (-2.86%) ⬇️
...studio-environment/start-rstudio-environment-sc.js 34.73% <0.00%> (-1.53%) ⬇️
lib/steps/launch-product/launch-product.js 17.59% <0.00%> (-0.17%) ⬇️
lib/steps/create-service-catalog-portfolio.js 60.00% <0.00%> (ø)
lib/steps/provision-account/provision-account.js 46.80% <0.00%> (ø)
...check-launch-dependency/check-launch-dependency.js 54.59% <0.00%> (ø)
.../helpers/env-type-candidate-version-filter-enum.js 25.00% <0.00%> (ø)
...ent-type/helpers/env-type-candidate-status-enum.js 30.00% <0.00%> (ø)
...e-launch-dependency/terminate-launch-dependency.js 59.71% <0.00%> (ø)
lib/helpers/js-yaml-custom-schema.js 35.71% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6e04ca...ab6c1f3. Read the comment docs.

shyogesh-sw and others added 4 commits November 15, 2021 16:15
* docs: rstudiodocs
* fix: remove legacy RStudio code

* fix: update AMI readme

* fix: link to post deployment guide
nguyen102
nguyen102 previously approved these changes Nov 16, 2021
@SanketD92 SanketD92 merged commit ed2e7dc into develop Nov 18, 2021
@SanketD92 SanketD92 deleted the chore-merge-feature-rstudio branch November 18, 2021 23:08
jxuamazon pushed a commit to jxuamazon/service-workbench-on-aws that referenced this pull request Feb 15, 2022
* Implementation for RstudioV2 (backed by ALB) feature
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants