Skip to content
This repository has been archived by the owner on Dec 6, 2024. It is now read-only.

Sample files #15

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Sample files #15

merged 1 commit into from
Jun 2, 2020

Conversation

hatimkhan
Copy link
Contributor

This pull request contains sample files that implement:

  • Hello service
  • Hello controller
  • Hello UI page

These sample files are meant to demonstrate to external developers how to create services, controllers and UI pages without modifying the addons folders.

Since these sample files are registered via the appropriate plugin registries, they are "live". So, we need to decide if this is an acceptable default.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hatimkhan hatimkhan requested a review from a team as a code owner May 29, 2020 05:11
Copy link
Contributor

@lordjabez lordjabez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to keep this "live", it's like a little easter egg.

Could you maybe add a note in the readme pointing to it, though, as an example of how to extend the capabilities of the API?

@hatimkhan
Copy link
Contributor Author

I think it's fine to keep this "live", it's like a little easter egg.

Could you maybe add a note in the readme pointing to it, though, as an example of how to extend the capabilities of the API?

Sure, that is a good idea.

SanketD92
SanketD92 previously approved these changes Jun 1, 2020
@hatimkhan
Copy link
Contributor Author

I added a few lines to the README.md file.

SanketD92
SanketD92 previously approved these changes Jun 2, 2020
@lordjabez lordjabez self-requested a review June 2, 2020 22:42
@lordjabez lordjabez self-assigned this Jun 2, 2020
@lordjabez lordjabez merged commit 700ed01 into awslabs:master Jun 2, 2020
manikandan-thangavelu-rl pushed a commit to manikandan-thangavelu-rl/service-workbench-on-aws that referenced this pull request Jun 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants