This repository has been archived by the owner on Dec 6, 2024. It is now read-only.
test: rstudio alb integration tests #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: re-ordering locks for alb, fix count update * fix typo
* feat: sync rstudio pre-release with latest mainline code
* fix: replace get with post rstudio connect
nguyen102
commented
Nov 17, 2021
| @@ -55,7 +55,7 @@ class WorkspaceServiceCatalog extends Resource { | |||
|
|
|||
| async cidr(body) { | |||
| const api = `${this.api}/cidr`; | |||
| const response = await this.doCall(async () => this.axiosClient.put(api, body, {})); | |||
| const response = await this.doCall(async () => this.axiosClient.post(api, body, {})); | |||
There was a problem hiding this comment.
Making updates to CIDR is actually a POST method, not a PUT method. (Link here]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Added integration tests for ALB RStudio.
Checklist:
AS review ticket id:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.