This repository has been archived by the owner on Dec 6, 2024. It is now read-only.
fix: count logic alb workspaces #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6f4ccce to
7042d83
Compare
nguyen102
reviewed
Oct 21, 2021
...s/environment-sc-workflow-steps/lib/steps/check-launch-dependency/check-launch-dependency.js
Outdated
Show resolved
Hide resolved
nguyen102
approved these changes
Oct 21, 2021
SanketD92
added a commit
that referenced
this pull request
Nov 15, 2021
* fix: re-ordering locks for alb, fix count update * fix typo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Faulty ALB-workspace count logic.
Description of changes:
Get current count of listener rules directly from ALB and assign it as rules get created/deleted.
Checklist:
AS review ticket id:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.