This repository has been archived by the owner on Dec 6, 2024. It is now read-only.
fix: Don't delete ALB if another instance is starting #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanketD92
reviewed
Nov 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Setup:
There is one instance. Launch a new instance. After check-launch-dependency passes for that instance, terminate the original instance.
This PR prevents SWB from terminating the ALB, because it thinks that there are no more instance relying on the ALB left.
We fix this in
terminate-launch-depency. Before terminating the ALB we check if there anyPENDINGinstances that is associated with a ProjectType that has the input parameterACMSSLCertARN.Checklist:
AS review ticket id:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.