This repository has been archived by the owner on Dec 6, 2024. It is now read-only.
feat: integrating appstream with rstudio-alb #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jn1119
reviewed
Nov 3, 2021
...n-base-raas/packages/base-raas-cfn-templates/src/templates/application-load-balancer.cfn.yml
Outdated
Show resolved
Hide resolved
addons/addon-base-raas/packages/base-raas-cfn-templates/src/templates/onboard-account.cfn.yml
Outdated
Show resolved
Hide resolved
addons/addon-base-raas/packages/base-raas-cfn-templates/src/templates/onboard-account.cfn.yml
Outdated
Show resolved
Hide resolved
addons/addon-base-raas/packages/base-raas-cfn-templates/src/templates/onboard-account.cfn.yml
Outdated
Show resolved
Hide resolved
addons/addon-base-raas/packages/base-raas-cfn-templates/src/templates/onboard-account.cfn.yml
Outdated
Show resolved
Hide resolved
...s/environment-sc-workflow-steps/lib/steps/check-launch-dependency/check-launch-dependency.js
Outdated
Show resolved
Hide resolved
jn1119
reviewed
Nov 10, 2021
...n-base-raas/packages/base-raas-cfn-templates/src/templates/application-load-balancer.cfn.yml
Show resolved
Hide resolved
addons/addon-base-raas/packages/base-raas-services/lib/alb/alb-service.js
Show resolved
Hide resolved
...nment-sc-workflow-steps/lib/steps/terminate-launch-dependency/terminate-launch-dependency.js
Show resolved
Hide resolved
jn1119
reviewed
Nov 12, 2021
addons/addon-base-raas/packages/base-raas-services/lib/alb/alb-service.js
Show resolved
Hide resolved
addons/addon-base-raas/packages/base-raas-services/lib/environment/environment-dns-service.js
Show resolved
Hide resolved
addons/addon-base-raas/packages/base-raas-services/lib/plugins/env-provisioning-plugin.js
Show resolved
Hide resolved
...base-raas/packages/base-raas-workflow-steps/lib/steps/provision-account/provision-account.js
Show resolved
Hide resolved
jn1119
approved these changes
Nov 14, 2021
SanketD92
added a commit
that referenced
this pull request
Nov 15, 2021
* feat: integrating appstream with rstudio-alb
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
GALI-1206
Description of changes:
Changes required for provisioning RStudioV2 with AppStream enabled.
Checklist:
AS review ticket id:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.