-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 7.7! 🎉 #5683
Merged
Release 7.7! 🎉 #5683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New Ramp build with latest changes
Add text-nowrap class to item page buttons
* Use active section/timespan items in Ramp to populate add to playlist options * Add form validation, fix playlist form reset after success * Disable/enable current track option based on the player's currentTime * Update app/assets/javascripts/ramp_utils.js Co-authored-by: Mason Ballengee <68433277+masaball@users.noreply.github.com> * Update app/assets/javascripts/ramp_utils.js Co-authored-by: Mason Ballengee <68433277+masaball@users.noreply.github.com> * Update app/assets/javascripts/ramp_utils.js Co-authored-by: Mason Ballengee <68433277+masaball@users.noreply.github.com> --------- Co-authored-by: Mason Ballengee <68433277+masaball@users.noreply.github.com>
Shorten title for encodes using s3 urls
Move administrative buttons to top of page and outside of scope of Ramp
…al for screen readers Links need to be non-navigable in order for role="presentation" or aria-hidden="true" to take effect. I copied what I saw YouTube as doing with aria-hidden="true" and tabindex=-1. Empty alt text for images marks them as presentation and thus skipped by screen readers.
This is easier to do than fix the underlying issue by reworking the code. While investigating this I found that lsof is blocking for a really long time in the docker container so it is always timing out. This makes this feature pretty useless which was another reason for this quick solution.
Mark thumbnails and wrapping links in search results are presentational for screen readers
Update skip to main content link
Add canvas reference to all root ranges
Add functionality to expand/close all sections button on item page
The solr_doc includes the master file ids in the other identifier field. These ids are not included in the accessor on the media object. These ids also are of a different format than the media object's normal other_identifiers. We need to exclude the master file ids from the accessor on the proxy because of those factors.
Move add to playlist button and add icon in front of button text
Log error for edge case and move on
New Ramp build with latest fixes
…option in add to playlist
Use released versions of dependencies
Avalon 7.7 RC 1
…ilation due to uglifier not supporting newer versions of ECMAScript
Use terser instead of uglifier
Fix for asset precompilation in docker build
Latest Ramp build
Install gems needed for reindex script
Add rake task to migrate IndexedFile captions to ActiveStorage
Bump version number to prepare for release
Bump Ramp version to 3.0.0
Prep for 7.7 release
Captions are currently contained in the HLS manifest and these are parsed by VideoJS. We do not need to manually provide text tracks to the embedded player because of this. This commit also includes a change to the filtering of captions for the embedded player for if/when we reenable manually providing them so that issues will not arise for implementers who run the caption file migration.
Enable create timeline and create thumbnail buttons on timeout
Turn off feeding caption tracks into embedded player
Avalon 7.7 RC2
joncameron
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.