Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rake task to migrate IndexedFile captions to ActiveStorage #5671

Merged
merged 3 commits into from
Feb 19, 2024

Conversation

masaball
Copy link
Contributor

@masaball masaball commented Feb 16, 2024

The original implementation for captions was a single IndexedFile attached to the master file. When we changed to ActiveStorage to support upload of multiple captions, we removed the controller routes and frontend code related to displaying, creating, and deleting the legacy captions. This migration moves the legacy captions to the new caption format so that users will be able to maintain access to, and control of, these captions.

Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good. I had a couple ideas for making it more efficient.

Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@masaball masaball merged commit a6e08f2 into develop Feb 19, 2024
2 checks passed
@masaball masaball deleted the migrate_captions branch February 19, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants