Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text-nowrap class to item page buttons #5444

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Add text-nowrap class to item page buttons #5444

merged 2 commits into from
Nov 2, 2023

Conversation

masaball
Copy link
Contributor

Fixes #5402

Copy link
Contributor

@Dananji Dananji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be the solution to this issue 💯
I do have the following question;
By applying it to this Bootstrap class, this rule gets applied to all the buttons using the btn class in avalon. And do we want that? Or the do we just need the buttons on the item page to have this?

And if it is the second case where we need this only for the buttons on the item view page, we could use the Bootstrap class called text-nowrap (Docs: https://getbootstrap.com/docs/5.2/components/buttons/#disable-text-wrapping).

@masaball
Copy link
Contributor Author

masaball commented Nov 1, 2023

That is something I had thought about as well. It is probably not an issue to have the behavior applied to all buttons. However, I think since there is built in functionality from bootstrap it's probably best for now to limit it to just the item page buttons and reassess if we end up seeing the unwanted line splitting behavior elsewhere. So I will go ahead and make the switch to the more limited set up.

@masaball masaball changed the title Add nowrap css rule for .btn Add text-nowrap class to item page buttons Nov 1, 2023
@masaball masaball requested a review from Dananji November 1, 2023 16:13
Copy link
Contributor

@Dananji Dananji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯

@masaball masaball merged commit c6725bd into develop Nov 2, 2023
@masaball masaball deleted the btn_wrapping branch November 2, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants