Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move administrative buttons to top of page and outside of scope of Ramp #5447

Merged
merged 3 commits into from
Nov 3, 2023

Conversation

cjcolvar
Copy link
Member

@cjcolvar cjcolvar commented Nov 1, 2023

I chose to put the buttons below the workflow progress because it is a panel that looks like a flash message which feels like it should be at the top of the page.

Resolves #5405

Before:
Screenshot from 2023-11-01 15-32-04

After:
Screenshot from 2023-11-01 15-23-53

@cjcolvar cjcolvar force-pushed the admin_button_placement branch from 2eaa0cb to 03807fe Compare November 1, 2023 19:29
Copy link
Contributor

@Dananji Dananji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 💯
I had a couple of suggestions on using some of the existing Bootstrap classes instead of in-lining the CSS

@cjcolvar cjcolvar requested a review from Dananji November 3, 2023 13:20
@cjcolvar cjcolvar merged commit d50e19c into develop Nov 3, 2023
@cjcolvar cjcolvar deleted the admin_button_placement branch November 3, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants