Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark thumbnails and wrapping links in search results are presentational for screen readers #5454

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

cjcolvar
Copy link
Member

@cjcolvar cjcolvar commented Nov 3, 2023

Links need to be non-navigable in order for role="presentation" or aria-hidden="true" to take effect. I copied what I saw YouTube as doing with aria-hidden="true" and tabindex=-1. Empty alt text for images marks them as presentation and thus skipped by screen readers.

Resolves #5342 and #5344

…al for screen readers

Links need to be non-navigable in order for role="presentation" or aria-hidden="true" to take effect.  I copied what I saw YouTube as doing with aria-hidden="true" and tabindex=-1.
Empty alt text for images marks them as presentation and thus skipped by screen readers.
Copy link
Contributor

@Dananji Dananji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@cjcolvar cjcolvar merged commit 4efc54f into develop Nov 6, 2023
@cjcolvar cjcolvar deleted the a11y_improvements branch November 6, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants