Feature/autoware health checker #1943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yn-mrse
reviewed
Jan 31, 2019
yn-mrse
reviewed
Jan 31, 2019
yn-mrse
reviewed
Jan 31, 2019
yn-mrse
reviewed
Jan 31, 2019
yn-mrse
reviewed
Jan 31, 2019
This was referenced Mar 14, 2023
|
@hakuturu583 I have opened a PR #1956 to fix the CI failure. Can you also add unit tests for the new code? I can help you getting started with it. |
|
@sgermanserrano Thank you for your advice!! |
2 tasks
|
@hakuturu583 this feature seems very similar to http://wiki.ros.org/robot_monitor tool. Did you consider a robot_monitor tool when implementing this PR? |
dejanpan
reviewed
Feb 25, 2019
|
|
||
| uint8_t test_function(double value) | ||
| { | ||
| if(value == 0.0) |
There was a problem hiding this comment.
you should not do the == comparison with float
|
@hakuturu583 @yn-mrse this PR changes 82 files in Autoware. For the entire PR there is but one test file. How can you be sure that you did not break something else by introducing such a big change? Also:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
DEVELOPMENT
Description
autowarefoundation/autoware_ai#494
Todos
Steps to Test or Reproduce