Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/autoware health analyzer #2004

Merged
merged 19 commits into from
Feb 22, 2019
Merged

Feature/autoware health analyzer #2004

merged 19 commits into from
Feb 22, 2019

Conversation

hakuturu583
Copy link

Status

DEVELOPMENT

Description

autowarefoundation/autoware_ai#566

Related PRs

List related PRs against other branches:

Todos

  • Tests
  • Documentation

Steps to Test or Reproduce

./run

Health Checker Start Automatically when the Autoware starts.

@hakuturu583 hakuturu583 requested a review from yn-mrse February 19, 2019 08:24
yn-mrse
yn-mrse suggested changes Feb 20, 2019
View reviewed changes
Copy link

@yn-mrse yn-mrse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
This branch worked in my environment.
Please correct the problem pointed out.

ros/src/system/autoware_health_checker/src/health_analyzer.cpp Outdated Show resolved Hide resolved
ros/src/system/autoware_health_checker/src/health_analyzer.cpp Outdated Show resolved Hide resolved
yn-mrse
yn-mrse reviewed Feb 20, 2019
View reviewed changes
Copy link

@yn-mrse yn-mrse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a result of executing this node, there was a missing value of key in node_status.
Please also fix this.

@hakuturu583
Copy link
Author

@yn-mrse I fixed this issue by other fix branch.
Please wait a bit.

@yn-mrse yn-mrse merged commit 4a9dc5a into develop Feb 22, 2019
@dejanpan
Copy link

@hakuturu583 @yn-mrse couple of things here which I hope will make you do better software in the future:

  1. Why were there completely unrelated changes done in this PR (changes to LGSVL)?
  2. Steps to reproduce are: 
    ./run
    In which package? What am I supposed to do after I run above script?
  3. What does this mean: Feature/autoware health analyzer #2004 (comment)?
  4. Why is there no tests?
  5. This work must be based on Feature/autoware health checker #1943, please mention it as a related PR so it is easier to see what has changed since e.g. Feature/autoware health checker #1943

@sgermanserrano sgermanserrano mentioned this pull request Mar 14, 2023
Closed
17 tasks
@amc-nu amc-nu mentioned this pull request Mar 1, 2019
Closed
@hakuturu583 hakuturu583 mentioned this pull request Mar 1, 2019
Merged
2 tasks
@amc-nu amc-nu deleted the feature/autoware_health_analyzer branch March 6, 2019 06:34
anubhavashok pushed a commit to NuronLabs/autoware.ai that referenced this pull request Sep 7, 2021
@hakuturu583 @yn-mrse
Feature/autoware health analyzer (autowarefoundation#2004)
2868614
@mitsudome-r mitsudome-r added the version:autoware-ai Autoware.AI label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yn-mrse yn-mrse yn-mrse approved these changes

Assignees
No one assigned
Labels
version:autoware-ai Autoware.AI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hakuturu583 @dejanpan @yn-mrse @mitsudome-r