Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ./run finction #2051

Merged
merged 1 commit into from
Mar 1, 2019
Merged

fix ./run finction #2051

merged 1 commit into from
Mar 1, 2019

Conversation

hakuturu583
Copy link

Status

DEVELOPMENT

Description

autowarefoundation/autoware_ai#585

Related PRs

#2004

Todos

  • Tests
  • Documentation

Steps to Test or Reproduce

Build Autoware with colcon or

catkin_make -DCMAKE_BUILD_TYPE=Release install
./run

Copy link
Member

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed that runtime manager starts up properly with ./colcon_release and ./run

@gbiggs
Copy link

gbiggs commented Mar 1, 2019

Why do you need to run colcon_release before launching the runtime manager? Did you test with a more standard colcon build; colcon install approach?

@amc-nu
Copy link
Member

amc-nu commented Mar 1, 2019

@gbiggs Runtime Manager depends on autoware_msgs.

@mitsudome-r
Copy link
Member

mitsudome-r commented Mar 1, 2019

@gbiggs
Thank you for your advice.

I used colcon_release script because I thought that the script is the replacement of catkin_make_release, which Autoware Build Instruction tells the users to use.
I thought that this would be the most "basic" way to build Autoware(at least for the first time).
https://github.com/CPFL/Autoware/wiki/Source-Build

Also, the error won't be reproduced just by running colcon build; colcon install if the user has done catkin_make before colcon bulid. The script will make sure that "devel" directory is deleted before running colcon build. (Although I think this operations should be removed in colcon_release script because the directory is not related to colcon.)

Anyway, you are correct that normal colcon users would be more familiar with your commands, so I just tested with your commands and checked that it works fine.

@hakuturu583
Copy link
Author

@mitsudome-r Thank you for review!!

@hakuturu583 hakuturu583 merged commit bed29b7 into develop Mar 1, 2019
@hakuturu583 hakuturu583 deleted the fix/run_script branch March 1, 2019 08:16
@amc-nu
Copy link
Member

amc-nu commented Mar 1, 2019

@mitsudome-r CMakeLists.txt created by catkin_make will cause colcon build to fail. For this reason colcon_release script removes the conflicting file. Read here

Many users didn't know about this, so it was added here and improved here

The instructions in the wiki are for master branch. These will be updated once the 1.11 is released.

@sgermanserrano
Copy link

@hakuturu583 @mitsudome-r @amc-nu when building using colcon instead of catkin a setup.bash and a local_setup.bash files are created.
Using local_setup.bash is the suggested method in https://colcon.readthedocs.io/en/released/user/quick-start.html.
setup.bash will also source the parent workspace, /opt/ros/DISTRO, while this would not lead to compatibility problems at the moment, I believe it might lead to issues down the line when .Auto is also part of .Ai since /opt/ros2/DISTRO will also be sourced.
Sourcing local_setup.bash seems to me like a safer way to go

anubhavashok pushed a commit to NuronLabs/autoware.ai that referenced this pull request Sep 7, 2021
@mitsudome-r mitsudome-r added the version:autoware-ai Autoware.AI label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants