-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(route_handler-bpp): consider lane-ego angle diff in lane following module #2732
feat(route_handler-bpp): consider lane-ego angle diff in lane following module #2732
Conversation
…warefoundation#2732) * docs: add note to use rocker without the CUDA environment error Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp> * docs: fix description Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
bdc80e6
to
7419866
Compare
d5b4d92
to
6e31063
Compare
6e31063
to
c33ebfe
Compare
757f351
to
28f9cbe
Compare
friendly ping to review |
@mehmetdogru cc @xmfcx Since there are too many reviewers, I think it's good to assign someone. |
@mehmetdogru @kenji-miyake I will review this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good. I could not consistently reproduce the issue on the main
branch, but it appears to be fixed with this PR.
I ran scenarios with this PR and there is no problem (https://evaluation.tier4.jp/evaluation/reports/1c358525-5dc8-50f1-8b87-45a9fbed281a?project_id=prd_jt, private TIER IV link).
planning/behavior_path_planner/src/behavior_path_planner_node.cpp
Outdated
Show resolved
Hide resolved
28f9cbe
to
56f1871
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2732 +/- ##
==========================================
- Coverage 12.33% 12.33% -0.01%
==========================================
Files 1381 1381
Lines 96692 96711 +19
Branches 27978 27989 +11
==========================================
+ Hits 11930 11931 +1
- Misses 72094 72113 +19
+ Partials 12668 12667 -1
*This pull request uses carry forward flags. Click here to find out more.
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
56f1871
to
33efc32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems the owner of the code has to approve this PR, so I give the approval
…ng module Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com> style(pre-commit): autofix update copyright years Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com> remove default values for declare_parameter Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>
33efc32
to
9ac2af7
Compare
Signed-off-by: Mehmet Dogru 42mehmetdogru42@gmail.com
closes #2125
Description
Related links
Tests performed
Please check out also:feat(lanelet2_extension): consider lane-ego angle difference in lane following module autoware_common#148feat(lane_following): consider lane ego angle diff autoware_launch#250Before the PR (issue):
2125_issue.mp4
After PR (fix/feat):
2125_fix.mp4
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.