Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(route_handler-bpp): consider lane-ego angle diff in lane following module #2732

Conversation

mehmetdogru
Copy link
Contributor

@mehmetdogru mehmetdogru commented Jan 24, 2023

Signed-off-by: Mehmet Dogru 42mehmetdogru42@gmail.com

closes #2125

Description

Related links

Tests performed

   # Dynamic expansion by projecting the ego footprint along the path
    dynamic_expansion:
      enabled: true
.
.
.
      expansion:
        method: lanelet # method used to expand the drivable area. Either 'lanelet' or 'polygon'.
                         # 'lanelet': add lanelets overlapped by the ego footprints
                         # 'polygon': add polygons built around sections of the ego footprint that go out of the drivable area

Before the PR (issue):

2125_issue.mp4

After PR (fix/feat):

2125_fix.mp4

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@mehmetdogru mehmetdogru added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 24, 2023
@mehmetdogru mehmetdogru self-assigned this Jan 24, 2023
@github-actions github-actions bot added the component:map Map creation, storage, and loading. (auto-assigned) label Jan 24, 2023
@mehmetdogru mehmetdogru marked this pull request as draft January 24, 2023 15:00
KYabuuchi pushed a commit to KYabuuchi/autoware.universe that referenced this pull request Feb 16, 2023
…warefoundation#2732)

* docs: add note to use rocker without the CUDA environment error

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

* docs: fix description

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
@mehmetdogru mehmetdogru force-pushed the 2125-consider-lane-ego-angle-diff-in-lane-following-module branch from bdc80e6 to 7419866 Compare March 14, 2023 06:54
@github-actions github-actions bot removed the component:map Map creation, storage, and loading. (auto-assigned) label Mar 14, 2023
@mehmetdogru mehmetdogru marked this pull request as ready for review March 14, 2023 07:11
@mehmetdogru mehmetdogru force-pushed the 2125-consider-lane-ego-angle-diff-in-lane-following-module branch 2 times, most recently from d5b4d92 to 6e31063 Compare March 14, 2023 08:02
@xmfcx xmfcx force-pushed the 2125-consider-lane-ego-angle-diff-in-lane-following-module branch from 6e31063 to c33ebfe Compare March 21, 2023 16:00
@github-actions github-actions bot added component:system System design and integration. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) labels Apr 4, 2023
@mehmetdogru mehmetdogru force-pushed the 2125-consider-lane-ego-angle-diff-in-lane-following-module branch from 757f351 to 28f9cbe Compare April 4, 2023 15:19
@github-actions github-actions bot removed type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) component:system System design and integration. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) labels Apr 4, 2023
@mehmetdogru
Copy link
Contributor Author

friendly ping to review

@kenji-miyake
Copy link
Contributor

@mehmetdogru cc @xmfcx Since there are too many reviewers, I think it's good to assign someone.

@maxime-clem
Copy link
Contributor

@mehmetdogru @kenji-miyake I will review this PR.

@yukkysaito
Copy link
Contributor

cc @TakaHoribe @takayuki5168

Copy link
Contributor

@maxime-clem maxime-clem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good. I could not consistently reproduce the issue on the main branch, but it appears to be fixed with this PR.
I ran scenarios with this PR and there is no problem (https://evaluation.tier4.jp/evaluation/reports/1c358525-5dc8-50f1-8b87-45a9fbed281a?project_id=prd_jt, private TIER IV link).

planning/route_handler/src/route_handler.cpp Outdated Show resolved Hide resolved
@mehmetdogru mehmetdogru force-pushed the 2125-consider-lane-ego-angle-diff-in-lane-following-module branch from 28f9cbe to 56f1871 Compare April 5, 2023 12:01
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (93e040a) 12.33% compared to head (9ac2af7) 12.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2732      +/-   ##
==========================================
- Coverage   12.33%   12.33%   -0.01%     
==========================================
  Files        1381     1381              
  Lines       96692    96711      +19     
  Branches    27978    27989      +11     
==========================================
+ Hits        11930    11931       +1     
- Misses      72094    72113      +19     
+ Partials    12668    12667       -1     
Flag Coverage Δ *Carryforward flag
differential 4.97% <0.00%> (?)
total 12.34% <0.00%> (+<0.01%) ⬆️ Carriedforward from 86b773a

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...th_planner/scene_module/scene_module_interface.hpp 0.00% <ø> (ø)
...r_path_planner/util/lane_following/module_data.hpp 0.00% <ø> (ø)
...anner/include/behavior_path_planner/util/utils.hpp 100.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 0.11% <0.00%> (-0.01%) ⬇️
...ehavior_path_planner/src/behavior_tree_manager.cpp 0.00% <ø> (ø)
...r_path_planner/src/marker_util/avoidance/debug.cpp 0.00% <ø> (ø)
...r_path_planner/src/marker_util/debug_utilities.cpp 0.00% <ø> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% <0.00%> (ø)
...lanner/src/scene_module/avoidance_by_lc/module.cpp 0.00% <ø> (ø)
...ane_change/external_request_lane_change_module.cpp 0.00% <ø> (ø)
... and 24 more

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mehmetdogru mehmetdogru force-pushed the 2125-consider-lane-ego-angle-diff-in-lane-following-module branch from 56f1871 to 33efc32 Compare April 10, 2023 13:20
Copy link
Contributor

@purewater0901 purewater0901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the owner of the code has to approve this PR, so I give the approval

…ng module

Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>

style(pre-commit): autofix

update copyright years

Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>

remove default values for declare_parameter

Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>
@mehmetdogru mehmetdogru force-pushed the 2125-consider-lane-ego-angle-diff-in-lane-following-module branch from 33efc32 to 9ac2af7 Compare April 11, 2023 07:03
@mehmetdogru mehmetdogru merged commit 1713f8b into autowarefoundation:main Apr 11, 2023
@mehmetdogru mehmetdogru deleted the 2125-consider-lane-ego-angle-diff-in-lane-following-module branch April 11, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

behavior_path_planner generating invalid path orientation
5 participants