This repository has been archived by the owner on Jul 1, 2024. It is now read-only.
feat(lanelet2_extension): consider lane-ego angle difference in lane following module #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #148 +/- ##
==========================================
- Coverage 11.23% 11.15% -0.09%
==========================================
Files 33 33
Lines 2385 2403 +18
Branches 1260 1273 +13
==========================================
Hits 268 268
- Misses 1672 1690 +18
Partials 445 445
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
7 tasks
d90483e to
dad9b92
Compare
mitsudome-r
reviewed
Mar 23, 2023
…following module Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>
Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>
Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>
Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>
Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>
5af8183 to
0f0b6f8
Compare
mitsudome-r
approved these changes
Mar 28, 2023
satoshi-ota
pushed a commit
to satoshi-ota/autoware_common
that referenced
this pull request
Apr 27, 2023
…following module (autowarefoundation#148) * feat(lanelet2_extension): consider lane-ego angle difference in lane following module Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com> * remove debug prints Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com> * include limits Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com> * style(pre-commit): autofix * fix: use bg:distance Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com> * refactor: replace with getLaneletAngle Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com> --------- Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mehmet Dogru 42mehmetdogru42@gmail.com
closes autowarefoundation/autoware.universe#2125
Description
Related links
Tests performed
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.