Update cpplint version

[jacobperron]

This PR pulls in a different fork of cpplint that seems to be better maintained. It also contains patches to fix #309.

I've copied the upstream file (8f925b0) and then applied relevant historical patches from our fork (1754c5f). I looked at applying the following commits from our fork, but they seem to no longer apply:

• cpplint: allow using-directive for user-defined literals namespaces #67
• Escape backslashes #144
• Close source files after reading them #249

---

Full CI for all connected PRs:

• Linux
• Linux-aarch64
• Windows

PRs:

• Fix include order for cpplint ros/class_loader#192
• Fix include order and relative paths for cpplint ros2/demos#551
• Fix include order for cpplint ros2/performance_test_fixture#16
• Fix include order for cpplint ros2/rcl_logging#84
• Fix include order and relative paths for cpplint ros2/rclcpp#1859
• Fix include order for cpplint ros2/rclpy#877
• Fix include order for cpplint ros2/rcpputils#158
• Use static_cast instead of C-style cast ros2/rcutils#349
• Fix include order for cpplint ros/resource_retriever#69
• Fix cpplint errors ros2/rmw_connextdds#69
• Fix cpplint error ros2/rmw_fastrtps#574
• Fix cpplint errors ros2/rmw_cyclonedds#363
• Fix include order for cpplint ros2/rmw_dds_common#55
• Fix relative path include syntax for cpplint ros2/rmw_implementation#203
• Fix include order for cpplint ros/robot_state_publisher#186
• Fix include order for cpplint ros2/rosidl_typesupport_fastrtps#84
• Fix cpplint errors ros-perception/image_common#221
• Fix include order for cpplint ros2/realtime_support#113
• Fix cpplint errors ros2/rviz#818
• Fix include order for cpplint ros2/system_tests#493
• Add linter tests and fix errors ros2/urdf#30
• Fix cpplint errors ros2/geometry2#497
• Fix include order for cpplint ros2/rosidl#644
• Fix relative path syntax for cpplint ros2/rosbag2#947

[jacobperron]

Lint tests only:

• Linux
• Linux-aarch64
• macOS
• Windows

yikes, I didn't see all of these linter failures locally 🤔

[audrow]

Looks good to me with green CI.

[homalozoa]

Any update?

[jacobperron]

So, with this update there's 2000+ cpplint failures across ros2 repositories related to include order. It appears the linter has become more strict about order. Most of the failures come from generated headers (from rosidl), but regardless I think we'll have to touch a large number of files to appease the linter. I don't mind going through and updating headers as necessary (@ament/team thoughts?) Here's an example of what most diffs may look like:

+#include <algorithm>
+#include <chrono>
+#include <functional>
+#include <future>
+#include <map>
+#include <memory>
+#include <mutex>
+#include <string>
+#include <utility>
+
 #include <rclcpp/exceptions.hpp>
 #include <rclcpp/macros.hpp>
 #include <rclcpp/node_interfaces/node_base_interface.hpp>
 #include <rclcpp/node_interfaces/node_logging_interface.hpp>
 #include <rclcpp/node_interfaces/node_graph_interface.hpp>
 #include <rclcpp/logger.hpp>
 #include <rclcpp/time.hpp> #include <rclcpp/time.hpp>
 #include <rclcpp/waitable.hpp>
 
-#include <rosidl_runtime_c/action_type_support_struct.h>
+#include "rosidl_runtime_c/action_type_support_struct.h"
 #include <rosidl_typesupport_cpp/action_type_support.hpp>
 
-#include <algorithm>
-#include <chrono>
-#include <functional>
-#include <future>
-#include <map>
-#include <memory>
-#include <mutex>
-#include <string>
-#include <utility>
-

Note that custom C-headers in angle brackets are considered system headers, so we should use double-quotes instead.

[clalancette]

My opinion:

If you are willing to do the work and have time to do it, I'm fine with the upgrade. It's just going to require a large number of PRs to be merged at once :).