Fix include order for cpplint

Relates to ament/ament_lint#324 Signed-off-by: Jacob Perron <jacob@openrobotics.org>
ros2 · Jan 7, 2022 · dfae1b8 · dfae1b8
1 parent 92f164b
commit dfae1b8
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 29 deletions.
diff --git a/rcl_logging_interface/test/test_get_logging_directory.cpp b/rcl_logging_interface/test/test_get_logging_directory.cpp
@@ -12,16 +12,17 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#include <rcpputils/filesystem_helper.hpp>
-#include <rcpputils/env.hpp>
-#include <rcutils/allocator.h>
-#include <rcutils/env.h>
-#include <rcutils/error_handling.h>
-
 #include <iostream>
 #include <string>
 
 #include "gtest/gtest.h"
+
+#include "rcpputils/filesystem_helper.hpp"
+#include "rcpputils/env.hpp"
+#include "rcutils/allocator.h"
+#include "rcutils/env.h"
+#include "rcutils/error_handling.h"
+
 #include "rcl_logging_interface/rcl_logging_interface.h"
 
 // This is a helper class that resets an environment

diff --git a/rcl_logging_spdlog/src/rcl_logging_spdlog.cpp b/rcl_logging_spdlog/src/rcl_logging_spdlog.cpp
@@ -12,20 +12,20 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#include <rcpputils/filesystem_helper.hpp>
-#include <rcutils/allocator.h>
-#include <rcutils/logging.h>
-#include <rcutils/process.h>
-#include <rcutils/snprintf.h>
-#include <rcutils/time.h>
-
 #include <cerrno>
 #include <cinttypes>
 #include <memory>
 #include <mutex>
 #include <string>
 #include <utility>
 
+#include "rcpputils/filesystem_helper.hpp"
+#include "rcutils/allocator.h"
+#include "rcutils/logging.h"
+#include "rcutils/process.h"
+#include "rcutils/snprintf.h"
+#include "rcutils/time.h"
+
 #include "spdlog/spdlog.h"
 #include "spdlog/sinks/basic_file_sink.h"
 

diff --git a/rcl_logging_spdlog/test/fixtures.hpp b/rcl_logging_spdlog/test/fixtures.hpp
@@ -15,13 +15,6 @@
 #ifndef FIXTURES_HPP_
 #define FIXTURES_HPP_
 
-#include <rcpputils/filesystem_helper.hpp>
-#include <rcutils/allocator.h>
-#include <rcutils/env.h>
-#include <rcutils/error_handling.h>
-#include <rcutils/process.h>
-#include <rcutils/types/string_array.h>
-
 #include <limits.h>
 #ifdef _WIN32
 # include <windows.h>  // MAX_PATH
@@ -30,6 +23,13 @@
 
 #include "gtest/gtest.h"
 
+#include "rcpputils/filesystem_helper.hpp"
+#include "rcutils/allocator.h"
+#include "rcutils/env.h"
+#include "rcutils/error_handling.h"
+#include "rcutils/process.h"
+#include "rcutils/types/string_array.h"
+
 #ifdef _WIN32
 #define popen _popen
 #define pclose _pclose

diff --git a/rcl_logging_spdlog/test/test_logging_interface.cpp b/rcl_logging_spdlog/test/test_logging_interface.cpp
@@ -12,20 +12,21 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#include <rcpputils/filesystem_helper.hpp>
-#include <rcpputils/env.hpp>
-#include <rcutils/allocator.h>
-#include <rcutils/env.h>
-#include <rcutils/error_handling.h>
-#include <rcutils/logging.h>
-#include <rcutils/testing/fault_injection.h>
-
 #include <limits.h>
 #include <fstream>
 #include <string>
 
-#include "fixtures.hpp"
 #include "gtest/gtest.h"
+
+#include "rcpputils/filesystem_helper.hpp"
+#include "rcpputils/env.hpp"
+#include "rcutils/allocator.h"
+#include "rcutils/env.h"
+#include "rcutils/error_handling.h"
+#include "rcutils/logging.h"
+#include "rcutils/testing/fault_injection.h"
+
+#include "fixtures.hpp"
 #include "rcl_logging_interface/rcl_logging_interface.h"
 
 const int logger_levels[] =