Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cpplint errors #363

Merged
merged 3 commits into from
Jan 12, 2022
Merged

Fix cpplint errors #363

merged 3 commits into from
Jan 12, 2022

Conversation

jacobperron
Copy link
Member

Fixes cpplint errors.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Fixes a cpplint error.

Relates to ament/ament_lint#324

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Copy link
Collaborator

@eboasson eboasson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with green CI.

@jacobperron jacobperron merged commit 559ee67 into master Jan 12, 2022
@delete-merged-branch delete-merged-branch bot deleted the jacob/update_cpplint_fork branch January 12, 2022 22:25
clalancette pushed a commit to eboasson/rmw_cyclonedds that referenced this pull request May 18, 2022
* Use static_cast instead of C-style cast

Fixes cpplint errors.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Add missing include

Fixes a cpplint error.

Relates to ament/ament_lint#324

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Include missing rmw header

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants