Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

knowledgebase-disable-new-posts #7509

Merged
merged 1 commit into from
Jan 24, 2025
Merged

knowledgebase-disable-new-posts #7509

merged 1 commit into from
Jan 24, 2025

Conversation

valentinyanakiev
Copy link
Member

@valentinyanakiev valentinyanakiev commented Jan 24, 2025

  • old implementation fixed collection of...
  • changed enable.. to disable...

Summary by CodeRabbit

  • Breaking Changes

    • Renamed acceptNewResponses property to disablePostResponses across multiple components
    • Updated default behavior from accepting new responses to potentially disabling post responses
  • Refactoring

    • Modified response handling logic in callout-related components
    • Adjusted prop interfaces to reflect new response management approach
  • Impact

    • Changes affect how responses are managed in callouts and collaboration features
    • Developers will need to update prop usage when working with these components

Copy link

coderabbitai bot commented Jan 24, 2025

Walkthrough

This pull request introduces a comprehensive renaming of the acceptNewResponses property to disablePostResponses across multiple TypeScript files in the collaboration and community domains. The change affects interfaces, component props, and related logic in various components such as CalloutForm, CalloutView, CalloutSettingsContainer, and others. The modification shifts the semantic meaning from accepting new responses to explicitly disabling post responses, with a default value change from true to false.

Changes

File Change Summary
src/domain/collaboration/callout/CalloutForm.tsx Renamed acceptNewResponses to disablePostResponses in props and adjusted default value
src/domain/collaboration/callout/CalloutView/CalloutView.tsx Updated CommentsCallout prop to use disablePostResponses
src/domain/collaboration/callout/CalloutViewTypes.tsx Replaced acceptNewResponses with disablePostResponses in interface
src/domain/collaboration/callout/calloutBlock/CalloutSettingsContainer.tsx Renamed prop and updated related component logic
src/domain/collaboration/callout/creationDialog/CalloutCreationDialog.tsx Replaced acceptNewResponses with disablePostResponses
src/domain/collaboration/callout/edit/editDialog/CalloutEditDialog.tsx Updated prop name and default value
Multiple context and view components Consistent prop renaming across collaboration and community domains

Suggested labels

bug squash, enhancement, UX

Suggested reviewers

  • bobbykolev

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (6)
src/domain/collaboration/calloutsSet/CalloutsInContext/CalloutsGroupView.tsx (1)

74-74: Propagating disablePostResponses to CalloutCreationDialog.
Confirm that the dialog gracefully handles the scenario where posting is disabled. This should safeguard against users creating new posts if that is disallowed.

src/domain/collaboration/callout/edit/editDialog/CalloutEditDialog.tsx (1)

27-27: Clarify property usage with a doc comment
Consider adding a brief doc comment on what happens when this flag is set to true, to help future developers quickly understand the effect of disabling post responses.

src/domain/collaboration/calloutsSet/CalloutsView/CalloutsView.tsx (1)

44-44: Add doc comment for new prop
Adding a short explanation about when this property is typically used can enhance clarity for other contributors.

src/domain/collaboration/callout/CalloutForm.tsx (1)

94-94: Introduce a short doc
A concise explanation of disablePostResponses would help clarify that it prevents users from posting new responses.

src/domain/collaboration/callout/calloutBlock/CalloutSettingsContainer.tsx (2)

122-122: Consider renaming the boolean prop for clarity.

Although the meaning is clear, naming boolean props starting with “is” or “has” (e.g., isPostResponsesDisabled) can improve readability in large codebases.


451-451: Encapsulate the logic in a more readable expression.

This inline boolean logic is correct, but extracting the check to a helper variable or using a ternary could improve clarity:

-  disablePostResponses={disablePostResponses && callout.type === CalloutType.Post}
+  disablePostResponses={callout.type === CalloutType.Post ? disablePostResponses : false}
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6033b21 and 3a1478a.

📒 Files selected for processing (9)
  • src/domain/collaboration/callout/CalloutForm.tsx (4 hunks)
  • src/domain/collaboration/callout/CalloutView/CalloutView.tsx (1 hunks)
  • src/domain/collaboration/callout/CalloutViewTypes.tsx (1 hunks)
  • src/domain/collaboration/callout/calloutBlock/CalloutSettingsContainer.tsx (3 hunks)
  • src/domain/collaboration/callout/creationDialog/CalloutCreationDialog.tsx (3 hunks)
  • src/domain/collaboration/callout/edit/editDialog/CalloutEditDialog.tsx (3 hunks)
  • src/domain/collaboration/calloutsSet/CalloutsInContext/CalloutsGroupView.tsx (4 hunks)
  • src/domain/collaboration/calloutsSet/CalloutsView/CalloutsView.tsx (3 hunks)
  • src/domain/community/virtualContributor/knowledgeBase/KnowledgeBaseDialog.tsx (1 hunks)
🧰 Additional context used
📓 Path-based instructions (9)
src/domain/collaboration/callout/CalloutView/CalloutView.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

  • We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
  • Avoid flagging the absence of local error handling in cases where the global error handler suffices.
  • Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

  • Not Required: there's a skip
    {
    variables: { templateId: templateId! },
    skip: !templateId,
    }

Check for common security vulnerabilities such as:

  • SQL Injection
  • XSS (Cross-Site Scripting)
  • CSRF (Cross-Site Request Forgery)
  • Insecure dependencies
  • Sensitive data exposure
src/domain/community/virtualContributor/knowledgeBase/KnowledgeBaseDialog.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

  • We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
  • Avoid flagging the absence of local error handling in cases where the global error handler suffices.
  • Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

  • Not Required: there's a skip
    {
    variables: { templateId: templateId! },
    skip: !templateId,
    }

Check for common security vulnerabilities such as:

  • SQL Injection
  • XSS (Cross-Site Scripting)
  • CSRF (Cross-Site Request Forgery)
  • Insecure dependencies
  • Sensitive data exposure
src/domain/collaboration/callout/CalloutViewTypes.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

  • We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
  • Avoid flagging the absence of local error handling in cases where the global error handler suffices.
  • Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

  • Not Required: there's a skip
    {
    variables: { templateId: templateId! },
    skip: !templateId,
    }

Check for common security vulnerabilities such as:

  • SQL Injection
  • XSS (Cross-Site Scripting)
  • CSRF (Cross-Site Request Forgery)
  • Insecure dependencies
  • Sensitive data exposure
src/domain/collaboration/callout/edit/editDialog/CalloutEditDialog.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

  • We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
  • Avoid flagging the absence of local error handling in cases where the global error handler suffices.
  • Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

  • Not Required: there's a skip
    {
    variables: { templateId: templateId! },
    skip: !templateId,
    }

Check for common security vulnerabilities such as:

  • SQL Injection
  • XSS (Cross-Site Scripting)
  • CSRF (Cross-Site Request Forgery)
  • Insecure dependencies
  • Sensitive data exposure
src/domain/collaboration/callout/calloutBlock/CalloutSettingsContainer.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

  • We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
  • Avoid flagging the absence of local error handling in cases where the global error handler suffices.
  • Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

  • Not Required: there's a skip
    {
    variables: { templateId: templateId! },
    skip: !templateId,
    }

Check for common security vulnerabilities such as:

  • SQL Injection
  • XSS (Cross-Site Scripting)
  • CSRF (Cross-Site Request Forgery)
  • Insecure dependencies
  • Sensitive data exposure
src/domain/collaboration/calloutsSet/CalloutsView/CalloutsView.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

  • We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
  • Avoid flagging the absence of local error handling in cases where the global error handler suffices.
  • Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

  • Not Required: there's a skip
    {
    variables: { templateId: templateId! },
    skip: !templateId,
    }

Check for common security vulnerabilities such as:

  • SQL Injection
  • XSS (Cross-Site Scripting)
  • CSRF (Cross-Site Request Forgery)
  • Insecure dependencies
  • Sensitive data exposure
src/domain/collaboration/callout/CalloutForm.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

  • We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
  • Avoid flagging the absence of local error handling in cases where the global error handler suffices.
  • Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

  • Not Required: there's a skip
    {
    variables: { templateId: templateId! },
    skip: !templateId,
    }

Check for common security vulnerabilities such as:

  • SQL Injection
  • XSS (Cross-Site Scripting)
  • CSRF (Cross-Site Request Forgery)
  • Insecure dependencies
  • Sensitive data exposure
src/domain/collaboration/callout/creationDialog/CalloutCreationDialog.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

  • We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
  • Avoid flagging the absence of local error handling in cases where the global error handler suffices.
  • Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

  • Not Required: there's a skip
    {
    variables: { templateId: templateId! },
    skip: !templateId,
    }

Check for common security vulnerabilities such as:

  • SQL Injection
  • XSS (Cross-Site Scripting)
  • CSRF (Cross-Site Request Forgery)
  • Insecure dependencies
  • Sensitive data exposure
src/domain/collaboration/calloutsSet/CalloutsInContext/CalloutsGroupView.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

  • We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
  • Avoid flagging the absence of local error handling in cases where the global error handler suffices.
  • Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

  • Not Required: there's a skip
    {
    variables: { templateId: templateId! },
    skip: !templateId,
    }

Check for common security vulnerabilities such as:

  • SQL Injection
  • XSS (Cross-Site Scripting)
  • CSRF (Cross-Site Request Forgery)
  • Insecure dependencies
  • Sensitive data exposure
🔇 Additional comments (17)
src/domain/collaboration/callout/CalloutViewTypes.tsx (1)

38-38: Ensure consistent default handling for the new property.
By introducing disablePostResponses?: boolean;, please confirm the default value and whether you want to handle it explicitly or rely on undefined as false. This helps maintain clarity for future maintainers.

src/domain/collaboration/callout/CalloutView/CalloutView.tsx (1)

32-32: Revisit the unconditional usage of the prop.
By specifying disablePostResponses (with no value) on the CommentsCallout component, you effectively set it to true. Verify that this is the intended behavior rather than referencing a prop from props.

src/domain/collaboration/calloutsSet/CalloutsInContext/CalloutsGroupView.tsx (3)

17-17: New disablePostResponses property.
This aligns with the overall shift from accepting to disabling responses. Ensure the new property name fits the intended usage (negative vs. positive naming).


29-29: Effective destructuring of the new property.
The destructuring of disablePostResponses is consistent with the interface. Ensure all references to disablePostResponses maintain the correct scope and semantics.


60-60: Passing post responses disabling to CalloutsView.
Review how CalloutsView consumes this prop to confirm that it accurately disables posting responses and does not rely on any outdated acceptNewResponses logic.

src/domain/community/virtualContributor/knowledgeBase/KnowledgeBaseDialog.tsx (1)

62-62: Validate the default boolean prop usage.
Specifying disablePostResponses in JSX without a value passes true by default. Confirm that always disabling post responses aligns with your functional requirements.

src/domain/collaboration/callout/edit/editDialog/CalloutEditDialog.tsx (2)

40-40: Default value is sensible
Setting disablePostResponses to false by default is consistent with the original behavior of allowing new responses by default.


116-116: Correct pass-through of prop
Propagating disablePostResponses to CalloutForm correctly aligns with the rest of the PR. Looks good.

src/domain/collaboration/calloutsSet/CalloutsView/CalloutsView.tsx (2)

56-56: Destructuring looks good
Destructuring the new disablePostResponses prop is straightforward and consistent with surrounding code.


143-143: Prop forwarding is correct
Forwarding disablePostResponses to CalloutView ensures consistent logic across all callout renditions.

src/domain/collaboration/callout/CalloutForm.tsx (3)

108-108: Default value aligns with accepted paradigm
Using a default of false supports the previous behavior of having responses enabled unless explicitly disabled.


132-132: Conditional state logic
Switching opened to reflect !disablePostResponses is an intuitive approach to preserve backward compatibility.


199-199: Good condition for new responses
The check !disablePostResponses ensures that the new responses option is enabled only if allowed, preventing accidental undesired postings.

src/domain/collaboration/callout/creationDialog/CalloutCreationDialog.tsx (3)

60-60: Prop extension
Introducing disablePostResponses as an optional boolean is consistent with the rest of the callout property suite.


73-73: Clear destructuring
Destructuring disablePostResponses follows best practices and is neatly placed among the other props.


284-284: Conditional usage of disablePostResponses
Passing disablePostResponses only if the selected type is CalloutType.Post is a well-targeted approach, ensuring it doesn't affect other callout types.

src/domain/collaboration/callout/calloutBlock/CalloutSettingsContainer.tsx (1)

142-142: Looks good.

Destructuring the newly added disablePostResponses prop is consistent and straightforward. No issues found here.

@ccanos ccanos merged commit 10adae7 into develop Jan 24, 2025
3 checks passed
@ccanos ccanos deleted the disable-new-posts branch January 24, 2025 14:26
reactoholic added a commit that referenced this pull request Jan 29, 2025
* fix forum discussion styles

* update contributors image for unauth users and fix styles (#7354)

* update contributors image for unauth users and fix styles

* resolve pr comments

* Remove location from VC card

* remove usage of anonymousReadAccess (#7332)

* Fix dashboard access (#7360)

* Fix dashboard access

* fixed scope

* change polling interval

* fix pr comment

* renamed to useSpaceTemplate*s*ManagerQuery

---------

Co-authored-by: Carlos Cano <carlos@alkem.io>

* Handling of scroll and page change in documentation. (#7359)

* logs for the frame origin

* add allow-scripts to the docs iframe

* Improve the layout banner of Documentation page;

* Subtitle for the Docs page

* added new tabs to user + org admin pages; refactored contributor admin pages (#7367)

* added new tabs to user + org admin pages; refactored how admin pages for users + orgs + vcs are managed; moved some global admin functionality out of domain down to platform admin; ...

* updated generation to match api tidy ups related to set of preference types + ID passing for org mutations

* fix compile errors related to dropping of separate UserPreferenceType enum

* Synchronize icons, remove comments, make sure there are no redundant settings calls.

* Links & Docs to BoK on VC creation (#7365)

* VC documents and links BoK - refactor the AddContent

* VC documents and links implementation without validation;

* resolve rabbit comments

---------

Co-authored-by: Petar Kolev <33326233+reactoholic@users.noreply.github.com>
Co-authored-by: reactoholic <petar.georgiev.kolev@gmail.com>

* Links and Docs - forgotten commit with Validation  (#7377)

* CalloutsSet entity (#7376)

* codegen passing with updated api

* fixed api + codegen passes

* code compiling

* pick up create callout privilege from the CalloutsSet

* callouts showing up after creation

* retrieving of callouts using only calloutsSet ID

* moved code around to have notion of calloutsSet in tree

* fix array dep breaking tool creation; small code optimizations;

---------

Co-authored-by: bobbykolev <bobbykolev@abv.bg>

* split useCallouts into also useCalloutsOnCollaboration (#7378)

* Style UserAvatar tooltip (#7384)

* Fix: Deleting subspace l2 from its settings throws errors on space dashboard

* InnovationFlow States names validation - no commas (#7391)

* Add arcadeSoftware to the whitelist of iframes (#7397)

* bump client version (#7403)

* implement image pasting in md editor (#7387)

* codegen compilation

* Fix: ENTITY_NOT_FOUND Error is triggered after first login server#4790 (#7396)

* Remove `makeStyles` from `AlkemioAvatar` and `CommunityUpdatesView` (#7390)

* Clean up alkemio avatar component

The goal is to remove `@mui/styles`, but as the component is deprecated,
it is replaced with the new avatar component in the user popup and the
deprecated component is cleaned up from all unused features. The user
popup is inlined in it to simplify more the interface of the
component.

* update contributors image for unauth user (#7410)

* bug fix: verified label overlaps with text (#7415)

* removed usage of AuthorizationCredential, replaced with RoleName; removed usage of UserGroups

* added label to issue templates (#7425)

* Limit the answers length on ApplicationForm (#7419)

* Limit the answers length on ApplicationForm

* Fix error message

---------

Co-authored-by: Petar Kolev <33326233+reactoholic@users.noreply.github.com>

* Display account entitlements (#7414)

* wip

* removed state from some dialogs

---------

Co-authored-by: Carlos Cano <carlos@alkem.io>

* Fix: ENTITY_NOT_FOUND Error is triggered after first login server#4790 (#7396)

* Remove `makeStyles` from `AlkemioAvatar` and `CommunityUpdatesView` (#7390)

* Clean up alkemio avatar component

The goal is to remove `@mui/styles`, but as the component is deprecated,
it is replaced with the new avatar component in the user popup and the
deprecated component is cleaned up from all unused features. The user
popup is inlined in it to simplify more the interface of the
component.

* update contributors image for unauth user (#7410)

* bug fix: verified label overlaps with text (#7415)

* added label to issue templates (#7425)

* Limit the answers length on ApplicationForm (#7419)

* Limit the answers length on ApplicationForm

* Fix error message

---------

Co-authored-by: Petar Kolev <33326233+reactoholic@users.noreply.github.com>

* Display account entitlements (#7414)

* wip

* removed state from some dialogs

---------

Co-authored-by: Carlos Cano <carlos@alkem.io>

* update contributors image for unauth user (#7410)

* first pass fixing

* second pass

* Third pass

* 6 errors left

* Removing scary words in translation.en.json (#7432)

* moved to using UUIDs

* Add Updates from leads block to the subspaces page (l1 & l2). (#7417)

* Add Updates from leads block to the subspaces page (l1 & l2).

* share url

---------

Co-authored-by: Carlos Cano <carlos@alkem.io>

* Fix Sidebar list of spaces not refreshing after subspace delete (#7418)

Co-authored-by: Petar Kolev <33326233+reactoholic@users.noreply.github.com>

* fix

* [VC] Knowledge base instead of Subspace BoK in Written Knowledge step (#7381)

* added new tabs to user + org admin pages; refactored how admin pages for users + orgs + vcs are managed; moved some global admin functionality out of domain down to platform admin; ...

* updated generation to match api tidy ups related to set of preference types + ID passing for org mutations

* fix compile errors related to dropping of separate UserPreferenceType enum

* Synchronize icons, remove comments, make sure there are no redundant settings calls.

* Links & Docs to BoK on VC creation (#7365)

* VC documents and links BoK - refactor the AddContent

* VC documents and links implementation without validation;

* resolve rabbit comments

---------

Co-authored-by: Petar Kolev <33326233+reactoholic@users.noreply.github.com>
Co-authored-by: reactoholic <petar.georgiev.kolev@gmail.com>

* Links and Docs - forgotten commit with Validation  (#7377)

* CalloutsSet entity (#7376)

* codegen passing with updated api

* fixed api + codegen passes

* code compiling

* pick up create callout privilege from the CalloutsSet

* callouts showing up after creation

* retrieving of callouts using only calloutsSet ID

* moved code around to have notion of calloutsSet in tree

* fix array dep breaking tool creation; small code optimizations;

---------

Co-authored-by: bobbykolev <bobbykolev@abv.bg>

* VC knowledge base instead of subspace init

* Space creation after VC creation, loading, code opt & reorganization

* Fix docs uploading, code organization and documentation;

* fix uploading of docs in case there's no space under the acc; remove misleading createdSpaceId usage;

* useLoadingState instead of a new React State

* Fix - set properly the persona type depending on the 3 steps;

* Ability to select SpaceLevel2 on create VC (#7386)

* VC Knowledge Base callouts dialog (#7388)

* VC Knowledge Base callouts dialog - init.
* Filter available callout types.
* disable rich media on VC callout creation.
* Description component with update functionality.
* Update the Create Written Knowledge UI and initial state; Fix dialog titles in VC flow.
* Reingest logic in the Knowledge dialog.
* Remove the icon logic for CalloutVisibilityChangeDialog.
* Use the account hostname for space created in the VC flow.

* fix VC dialog not opening; remove outdated copy;

* storage config for KnowledgeBase description

---------

Co-authored-by: Neil Smyth <neil@thesmyths.eu>
Co-authored-by: Petar Kolev <33326233+reactoholic@users.noreply.github.com>
Co-authored-by: reactoholic <petar.georgiev.kolev@gmail.com>
Co-authored-by: Neil Smyth <30729240+techsmyth@users.noreply.github.com>
Co-authored-by: Carlos Cano <carlos@alkem.io>

* add cspell config (#7404)

* resolveIds returns string and not the entity

* proper check for available account for the vc flow (#7433)

* VirtualContributor fixes

* name ids

* updated for renamed mutation

* Client web/7416 disable image pasting when hide image options flag is true (#7428)

* fix organization verified sign font size by simone's ask

* disable image pasting if hideImageOptions flag is true

* optimize paste handler

* resolve pr comment

* Extract the isImageOrHtmlWithImage and call it once per item.

---------

Co-authored-by: Bobby Kolev <bobbykolev@abv.bg>

* Fix can't add callout to VC KnowledgeBase. (#7437)

Co-authored-by: Valentin Yanakiev <valentin.yanakiev@gmail.com>

* url resolver

* url builders

* Create space link entitlements (#7442)

* check for entitlements in the CreateSpaceLink

(cherry picked from commit aed1830)

* 0.79.7

(cherry picked from commit 7ec232c)

* updated to work with fields for entryRole + elevatedRole availability

* MD fixes - comments not visible with long Post description; `pre` long line not visible; (#7435)

* move fragment

* missing padding for the items on the left block on space and subspaces (#7448)

* Optimize the Contributor Account Tab and VC flow  (#7444)

* Optimize subspace query under acc. Fix first VC/Space flow resulting in errors.

* Fix add to community and navigation related to spaceId

* polishing

* fix navigation of subspaces

* Optimize the main vcWizard account call.

* pr fix

---------

Co-authored-by: Carlos Cano <carlos@alkem.io>

* Admin Roles management

* Available users search. Organizations auth using rolesetAdmin

* Organization roles management

* fix style

* clean up. first 0 errors

* removed usage of platform role set id on mutations for roles on platform as not needed (only one)

* check for the correct privilege for Callout creation

* Add checkbox for adding tutorials when creating new space and fix UI issue in Mozilla regarding the URL input (#7447)

* updated for adjusted privilege names

* [VC Flow] Choose community step (#7457)

* choose community step in vc flow
* fix data reload on home dash;
* refetch the BoK after VC callouts creation

* Append visuals to create profile input (#7301)

* profileData renamed to profile on CreateWhiteboardInput

* Removed visualUrl from post, which doens't make sense on creation

* graphical tweak and little rename

* Fix #7316 Create template permission (#7319)

* Filter file extensions robustly (#7326)

* Fix creating a subspace on a Space by nameId (#7328)

* Fix creating a subspace on a Space by nameId

* remove unused var

* Fix Tutorials Iframes (#7323)

* Fix tutorials iframes

* parse the iframe with the DOMParser instead of with regex

---------

Co-authored-by: Valentin Yanakiev <valentin.yanakiev@gmail.com>

* Add Callouts preview accordion on SubspacesList default subspace template selector (#7325)

* Add Callouts preview accordion on SubspacesList default subspace template selector

* usememo

* memoize the Description component

---------

Co-authored-by: Valentin Yanakiev <valentin.yanakiev@gmail.com>

* codegen

---------

Co-authored-by: Valentin Yanakiev <valentin.yanakiev@gmail.com>

* restrict activities block to 10 results and add activities dialog (#7463)

* Handle missing privileges for add VC to community. (#7470)

* Fix the save as template option missing due to missing array deps (#7476)

* Remove nameIds from VC dialogs

* Entitlements view based on permissions and limits (#7467)

* Fix #7451

* Common component to handle the

---------

Co-authored-by: Svetoslav Petkov <svetoslav@alkem.io>

* display usage-limit of spaces in the account page (#7468)

* display usage-limit of spaces in the account page

* making safer check

---------

Co-authored-by: Svetoslav Petkov <svetoslav@alkem.io>

* removed another url builder

* Remove SpaceRoleSetContributorTypes query and a few unused queries more

* Fix innovationHubs

* Fix add checkbox for tutorials UI bug (#7466)

* fix add checkbox for tutorials ui

* restore graphql files

---------

Co-authored-by: Bobby Kolev <bobbykolev@abv.bg>

* Fix first-child + useEffect dynamic deps array length console errors; (#7477)

Co-authored-by: Petar Kolev <33326233+reactoholic@users.noreply.github.com>

* Bug fix: search bar in spaces page not working, and page refreshes on search term enter (#7462)

* search spaces page not working

* visualize subspaces as well

* resolve pr comment

* resolve pr comment

* fix missing callouts in create template preview (#7482)

Co-authored-by: Petar Kolev <33326233+reactoholic@users.noreply.github.com>

* Fix organization provider

* clean

* Rename files

* Removed variables from notification query (#7481)

* First pass removing useCommunityAdmin

* rename forlder

* wip

* VC Flow - proper filtering of Existing Spaces  (#7490)

* apply multiple filters on space activities (#7489)

Co-authored-by: Bobby Kolev <bobbykolev@abv.bg>

* Available users/orgs/vcs hook

* support knowledge-base route on VC profile (#7480)

* fix nameId issue on VC profile

* fix userNameId issues on UserProfile

* a bit of cleanup. 0 errors again

* fix paste issue (#7493)

* removing fragment CommunityRoleSetDetails

* clean up

* Moved files

* Remove groups

* VC Flow - proper filtering of Existing Spaces  (#7490)

* apply multiple filters on space activities (#7489)

Co-authored-by: Bobby Kolev <bobbykolev@abv.bg>

* support knowledge-base route on VC profile (#7480)

* fix paste issue (#7493)

* VC Flow - proper filtering of Existing Spaces  (#7490)

* UserPage clean nameId

* Removed some unused code

* ApplicationDialog

* invitations in RolesetAdmin

* Delete more group things

* updatePreference mutation

* remove useInviteUsers

* fix md editor typing issue (#7501)

* small refactor

* no space creation when org has no spaces and vc is created

* refetch

* Account storage config for the account resources (#7486)

* use account storage config for entities under the account (instead userStorage)

* refactor a bit

---------

Co-authored-by: Carlos Cano <carlos@alkem.io>

* disable new posts on knowledgebase callouts (#7507)

* knowledgebase-disable-new-posts (#7509)

* No default callouts on space creation w tutorials (#7518)

* update graphql schema

* Add VC Callouts route (#7515)

* Url for posts that are inside VC knowledge-base
* fix url resolver

* 0.80.0 (#7526)

* reingest after creation of a VC with Space BoK (#7536)

* 0.80.1

* BugFix anonymous user access to public space (#7541)

* crowdin config (#7549)

* Fix search in space (#7552)

* Fix search in space

* Also use the lookup for space details

* Translations (#7553)

* 0.80.2

* disabled Crowdin action

---------

Co-authored-by: reactoholic <petar.georgiev.kolev@gmail.com>
Co-authored-by: Petar Kolev <33326233+reactoholic@users.noreply.github.com>
Co-authored-by: Carlos Cano <carlos@alkem.io>
Co-authored-by: Neil Smyth <30729240+techsmyth@users.noreply.github.com>
Co-authored-by: Valentin Yanakiev <valentin.yanakiev@gmail.com>
Co-authored-by: Neil Smyth <neil@thesmyths.eu>
Co-authored-by: Todorka Halacheva <56818790+thalacheva@users.noreply.github.com>
Co-authored-by: Svetoslav Petkov <svetoslav@alkem.io>
Co-authored-by: Simone <38861315+SimoneZaza@users.noreply.github.com>
Co-authored-by: Evgeni Dimitrov <comoque@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants