Filter file extensions robustly

[valentinyanakiev]

• some browsers fail with the mapping of MIME types to file extensions directly (or the combination browser / OS)
• hence the need of a mapping

Summary by CodeRabbit

• New Features
  • Enhanced file upload functionality with improved MIME type to file extension mapping.
  • Introduced a refined file type filtering mechanism for file selection.

[coderabbitai]

Walkthrough

The changes in FileUpload.tsx introduce a mapping of MIME types to file extensions to improve file upload functionality. A new mimeTypeToExtensionMap is added to explicitly associate various MIME types with their respective file extensions, addressing compatibility issues with certain browsers. Additionally, a useMemo hook is utilized to create an allowedExtensions variable, which generates a string of allowed file extensions based on the allowedMimeTypes from storageConfig. This variable is then used to update the allowedTypes prop for the UploadButton component.

Changes

File Path	Change Summary
src/core/ui/upload/FileUpload/FileUpload.tsx	Introduced mimeTypeToExtensionMap for mapping MIME types to file extensions; created allowedExtensions using useMemo for file type filtering; updated allowedTypes prop in UploadButton.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 3

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 523cdd1 and 43c93a5.

📒 Files selected for processing (1)

• src/core/ui/upload/FileUpload/FileUpload.tsx (3 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

src/core/ui/upload/FileUpload/FileUpload.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

• We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
• Avoid flagging the absence of local error handling in cases where the global error handler suffices.
• Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

• Not Required: there's a skip
  {
  variables: { templateId: templateId! },
  skip: !templateId,
  }

Check for common security vulnerabilities such as:

• SQL Injection
• XSS (Cross-Site Scripting)
• CSRF (Cross-Site Request Forgery)
• Insecure dependencies
• Sensitive data exposure

🔇 Additional comments (2)

src/core/ui/upload/FileUpload/FileUpload.tsx (2)

13-13: LGTM!

The useMemo import is appropriate for the new memoization implementation.

---

41-87: Verify browser compatibility of the implementation

The implementation looks solid, but we should verify it works across different browser/OS combinations as mentioned in the PR objectives.

✅ Verification successful

Browser compatibility for MIME type mapping is properly handled

The implementation includes explicit MIME type to extension mapping to handle browser inconsistencies, as evidenced by the comment and comprehensive mapping in the code. The mapping covers all major file types (PDF, Excel, Word, Images, PowerPoint) with their corresponding extensions, ensuring consistent behavior across different browsers.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for any existing browser-specific workarounds or issues
rg -i "browser|chrome|firefox|safari|edge" --type ts --type tsx

Length of output: 93

---

Script:

#!/bin/bash
# Search for any existing browser-specific workarounds or issues with correct file type
rg -i "browser|chrome|firefox|safari|edge" -t ts -t tsx

# Search for any tests related to file upload and browser compatibility
rg -i "test.*fileupload|browser.*test" -t ts -t tsx

# Look for any comments or documentation about browser compatibility
rg "NOTE:.*browser|TODO:.*browser" -t ts -t tsx

Length of output: 245

---

Script:

#!/bin/bash
# Search for any existing browser-specific workarounds or issues
rg -i "browser|chrome|firefox|safari|edge"

# Look for any tests related to file upload
rg -i "test.*fileupload"

# Search for mime type related code
rg "mimeType.*map|allowedMimeTypes"

Length of output: 65999