Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the Contributor Account Tab and VC flow #7444

Merged
merged 8 commits into from
Jan 15, 2025

Conversation

bobbykolev
Copy link
Collaborator

@bobbykolev bobbykolev commented Jan 14, 2025

  • stop requesting Subspaces on the Contributor's Account Tab;
  • stop requesting Subspace on the initial Account load in VC Create Wizard;
  • stop calling active user account information if the AccountInfo is passed directly to the VC Create wizard;
  • rework the VC Existing Knowledge step flow to query the subspace data on demand;
  • fix the initial VC creation flow as it was resulting in errors (add to community/redirect);
  • fix the redirect and Try VC logic for subspaces;
  • removed obsolete strings;

Summary by CodeRabbit

  • New Features

    • Enhanced Virtual Contributor creation process with improved space selection and loading mechanisms.
  • Bug Fixes

    • Simplified space creation loading messages.
    • Removed unnecessary error handling related to space selection.
  • Refactor

    • Updated routing and URL handling for space interactions.
    • Streamlined data structures for account and space management.
    • Removed deprecated subspace-related properties and queries.
  • Documentation

    • Updated translation messages for Virtual Contributor space creation process.

The changes focus on improving the Virtual Contributor creation workflow and simplifying the underlying technical implementation.

Copy link

coderabbitai bot commented Jan 14, 2025

Walkthrough

The pull request introduces significant changes to the Virtual Contributor creation process in the Alkemio platform. The modifications simplify the loading messages, remove subspace-related references, and update the data fetching and routing mechanisms for space selection. The changes streamline the user experience by focusing on space interaction rather than complex subspace structures and modify how spaces are retrieved and managed during the Virtual Contributor creation workflow.

Changes

File Change Summary
src/core/i18n/en/translation.en.json Updated loading messages to focus on space interaction instead of subspace creation; removed specific error messages related to space selection.
src/domain/account/queries/AccountInformation.graphql Removed subspaces field from account query.
src/domain/community/contributor/Account/ContributorAccountView.tsx Eliminated subspaces property from AccountTabResourcesProps interface.
src/main/routing/urlBuilders.ts Removed buildVirtualContributorUrl and buildInnovationPackUrl methods; added getSpaceUrlFromSubSpace.
src/main/topLevelPages/myDashboard/newVirtualContributorWizard/ExistingSpace.tsx Updated props to remove availableSpaces and added accountId and getSpaces; implemented asynchronous fetching of spaces.
src/main/topLevelPages/myDashboard/newVirtualContributorWizard/LoadingState.tsx Removed optional entity prop and associated translation logic; simplified translation handling.
src/main/topLevelPages/myDashboard/newVirtualContributorWizard/newVirtualContributorQueries.graphql Modified queries to replace VCSelectableSpace fragment with spaceProfileCommunityDetails; introduced AccountSpaces query.
src/main/topLevelPages/myDashboard/newVirtualContributorWizard/useNewVirtualContributorProps.ts Removed authorization and subspaces properties from UserAccountProps interface; updated import statements.
src/main/topLevelPages/myDashboard/newVirtualContributorWizard/useNewVirtualContributorWizard.tsx Added useAccountSpacesLazyQuery; updated function signatures for space handling.

Possibly related PRs

Suggested labels

bug squash, enhancement, client

Suggested reviewers

  • ccanos
  • reactoholic

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@bobbykolev bobbykolev marked this pull request as ready for review January 14, 2025 15:31
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (4)
src/main/topLevelPages/myDashboard/newVirtualContributorWizard/ExistingSpace.tsx (2)

30-54: Consider adding loading state during space fetching.

While the implementation handles race conditions well, users might benefit from feedback during the initial space fetching.

 const ExistingSpace = ({ onClose, onBack, onSubmit, accountId, getSpaces, loading }: ExistingSpaceProps) => {
   const { t } = useTranslation();
   const [availableSpaces, setAvailableSpaces] = useState<SelectableSpace[]>();
+  const [isLoading, setIsLoading] = useState(false);
   const prevAccountIdRef = useRef<string | undefined>(undefined);

   useEffect(() => {
     let isMounted = true;

     const fetchSubspaces = async () => {
+      setIsLoading(true);
       const spaces = await getSpaces(accountId);

       if (isMounted) {
         setAvailableSpaces(spaces);
+        setIsLoading(false);
       }
     };

     if (accountId !== prevAccountIdRef.current) {
       prevAccountIdRef.current = accountId;
       fetchSubspaces();
     }

     return () => {
       isMounted = false;
     };
   }, [accountId]);

Line range hint 73-83: Optimize space hierarchy processing with memoization.

The space hierarchy processing could be optimized by memoizing the transformation logic separately from the final result.

+  const transformSpace = useMemo(() => (
+    space: SelectableSpace,
+    parentSpaces: SelectableSpace[] = []
+  ) => ({
+    id: space.id,
+    name: `${space.profile.displayName}${parentSpaces.length > 0 ? '' : ` (${t('common.space')})`}`,
+    url: parentSpaces.length > 0 ? parentSpaces[parentSpaces.length - 1].profile.url : space.profile.url,
+    roleSetId: space.community.roleSet.id,
+    parentRoleSetIds: parentSpaces.map(space => space?.community.roleSet.id),
+  }), [t]);

   const listItems = useMemo(() => {
     const result: SelectableKnowledgeSpace[] = [];
-    const addSelectableSpace = (space: SelectableSpace, parentSpaces: SelectableSpace[] = []) => {
-      result.push({
-        id: space.id,
-        name: `${space.profile.displayName}${parentSpaces.length > 0 ? '' : ` (${t('common.space')})`}`,
-        url: parentSpaces.length > 0 ? parentSpaces[parentSpaces.length - 1].profile.url : space.profile.url,
-        roleSetId: space.community.roleSet.id,
-        parentRoleSetIds: parentSpaces.map(space => space?.community.roleSet.id),
-      });
+    const addSelectableSpace = (space: SelectableSpace, parentSpaces: SelectableSpace[] = []) => {
+      result.push(transformSpace(space, parentSpaces));
     };

     availableSpaces?.forEach((space: SelectableSpace) => {
       addSelectableSpace(space);
       space.subspaces?.forEach(subspace => {
         addSelectableSpace(subspace, [space]);
         subspace.subspaces?.forEach(subsubspace => {
           addSelectableSpace(subsubspace, [space, subspace]);
         });
       });
     });

     return result ?? [];
-  }, [availableSpaces]);
+  }, [availableSpaces, transformSpace]);
src/main/topLevelPages/myDashboard/newVirtualContributorWizard/useNewVirtualContributorWizard.tsx (2)

322-324: Consider enhancing error notification

The current error handling suppresses user feedback. Consider showing a non-intrusive notification to improve user experience.

 const notifyErrorOnAddToCommunity = () => {
-  console.log('Try your VC flow was skipped. Unable to add to community.');
+  notify(
+    t('createVirtualContributorWizard.errors.communityAddition'),
+    'warning'
+  );
 };

518-518: Review TODO comment

There's a TODO comment about StorageConfig that needs attention. Consider creating a follow-up task.

Would you like me to create a GitHub issue to track this StorageConfig TODO?

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b6bf111 and d393ba1.

⛔ Files ignored due to path filters (2)
  • src/core/apollo/generated/apollo-hooks.ts is excluded by !**/generated/**
  • src/core/apollo/generated/graphql-schema.ts is excluded by !**/generated/**
📒 Files selected for processing (9)
  • src/core/i18n/en/translation.en.json (1 hunks)
  • src/domain/account/queries/AccountInformation.graphql (0 hunks)
  • src/domain/community/contributor/Account/ContributorAccountView.tsx (0 hunks)
  • src/main/routing/urlBuilders.ts (1 hunks)
  • src/main/topLevelPages/myDashboard/newVirtualContributorWizard/ExistingSpace.tsx (4 hunks)
  • src/main/topLevelPages/myDashboard/newVirtualContributorWizard/LoadingState.tsx (1 hunks)
  • src/main/topLevelPages/myDashboard/newVirtualContributorWizard/newVirtualContributorQueries.graphql (1 hunks)
  • src/main/topLevelPages/myDashboard/newVirtualContributorWizard/useNewVirtualContributorProps.ts (1 hunks)
  • src/main/topLevelPages/myDashboard/newVirtualContributorWizard/useNewVirtualContributorWizard.tsx (10 hunks)
💤 Files with no reviewable changes (2)
  • src/domain/account/queries/AccountInformation.graphql
  • src/domain/community/contributor/Account/ContributorAccountView.tsx
🧰 Additional context used
📓 Path-based instructions (7)
src/main/topLevelPages/myDashboard/newVirtualContributorWizard/LoadingState.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

  • We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
  • Avoid flagging the absence of local error handling in cases where the global error handler suffices.
  • Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

  • Not Required: there's a skip
    {
    variables: { templateId: templateId! },
    skip: !templateId,
    }

Check for common security vulnerabilities such as:

  • SQL Injection
  • XSS (Cross-Site Scripting)
  • CSRF (Cross-Site Request Forgery)
  • Insecure dependencies
  • Sensitive data exposure
src/main/topLevelPages/myDashboard/newVirtualContributorWizard/newVirtualContributorQueries.graphql (1)

Pattern src/**/*.{graphql,gql}: Review the GraphQL schema and queries for best practices, potential bugs, and adherence to the project's GraphQL standards.
Ensure that the schema is well-defined and queries are optimized.
Check for security vulnerabilities.

src/main/topLevelPages/myDashboard/newVirtualContributorWizard/useNewVirtualContributorProps.ts (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

  • We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
  • Avoid flagging the absence of local error handling in cases where the global error handler suffices.
  • Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

  • Not Required: there's a skip
    {
    variables: { templateId: templateId! },
    skip: !templateId,
    }

Check for common security vulnerabilities such as:

  • SQL Injection
  • XSS (Cross-Site Scripting)
  • CSRF (Cross-Site Request Forgery)
  • Insecure dependencies
  • Sensitive data exposure
src/main/topLevelPages/myDashboard/newVirtualContributorWizard/ExistingSpace.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

  • We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
  • Avoid flagging the absence of local error handling in cases where the global error handler suffices.
  • Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

  • Not Required: there's a skip
    {
    variables: { templateId: templateId! },
    skip: !templateId,
    }

Check for common security vulnerabilities such as:

  • SQL Injection
  • XSS (Cross-Site Scripting)
  • CSRF (Cross-Site Request Forgery)
  • Insecure dependencies
  • Sensitive data exposure
src/main/routing/urlBuilders.ts (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

  • We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
  • Avoid flagging the absence of local error handling in cases where the global error handler suffices.
  • Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

  • Not Required: there's a skip
    {
    variables: { templateId: templateId! },
    skip: !templateId,
    }

Check for common security vulnerabilities such as:

  • SQL Injection
  • XSS (Cross-Site Scripting)
  • CSRF (Cross-Site Request Forgery)
  • Insecure dependencies
  • Sensitive data exposure
src/main/topLevelPages/myDashboard/newVirtualContributorWizard/useNewVirtualContributorWizard.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

  • We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
  • Avoid flagging the absence of local error handling in cases where the global error handler suffices.
  • Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

  • Not Required: there's a skip
    {
    variables: { templateId: templateId! },
    skip: !templateId,
    }

Check for common security vulnerabilities such as:

  • SQL Injection
  • XSS (Cross-Site Scripting)
  • CSRF (Cross-Site Request Forgery)
  • Insecure dependencies
  • Sensitive data exposure
src/core/i18n/en/translation.en.json (1)

Pattern src/**/*.json: Review the JSON files for correct syntax and structure.
Ensure that the configuration and data are accurate and follow the project's standards.
Check for sensitive data exposure and ensure that the data is properly validated.

⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Travis CI - Pull Request
🔇 Additional comments (9)
src/main/routing/urlBuilders.ts (1)

75-81: 🛠️ Refactor suggestion

Add error handling for URL manipulation.

The function assumes a specific URL structure and might fail silently for malformed URLs or when the '/challenges' segment is missing. Consider adding proper error handling.

 export const getSpaceUrlFromSubSpace = (subSpaceUrl: string) => {
+  try {
   const url = new URL(subSpaceUrl, window.location.origin);
   const urlSegments = url.pathname.split('/challenges');
+
+  if (urlSegments.length < 1) {
+    throw new Error('Invalid subspace URL format');
+  }
 
   url.pathname = urlSegments[0];
   return url.href;
+  } catch (error) {
+    console.error('Failed to parse subspace URL:', error);
+    return subSpaceUrl;
+  }
 };

Likely invalid or redundant comment.

src/main/topLevelPages/myDashboard/newVirtualContributorWizard/ExistingSpace.tsx (1)

25-27: LGTM! Props interface changes look good.

The transition from static spaces to dynamic fetching improves performance by loading spaces on demand.

src/main/topLevelPages/myDashboard/newVirtualContributorWizard/useNewVirtualContributorProps.ts (1)

1-2: LGTM! Clean up of imports

The removal of unused SpaceType import aligns with the PR's objective of removing subspace-related code.

src/main/topLevelPages/myDashboard/newVirtualContributorWizard/LoadingState.tsx (1)

14-14: LGTM! Component simplification

The removal of the entity prop and use of a static translation key makes the component more focused and maintainable.

Also applies to: 27-27

src/main/topLevelPages/myDashboard/newVirtualContributorWizard/useNewVirtualContributorWizard.tsx (2)

12-12: LGTM! Enhanced space fetching

The addition of useAccountSpacesLazyQuery and getSelectableSpaces function improves the space selection functionality.

Also applies to: 115-127


Line range hint 277-320: Verify error handling in addVCToCommunity

The function now handles spaceId explicitly, but consider adding error logging for failed community additions.

 const addVCToCommunity = async (
   virtualContributorId: string,
   parentRoleSetIds: string[] = [],
   spaceId: string | undefined
 ) => {
   if (!spaceId) {
+    console.error('Failed to add VC to community: spaceId is undefined');
     return false;
   }
   // ... existing code ...
   if (!roleSetId) {
+    console.error('Failed to add VC to community: roleSetId not found for space', spaceId);
     return false;
   }
   // ... rest of the code ...
 };
✅ Verification successful

Error logging suggestion aligns with codebase patterns

The suggested addition of console.error calls is consistent with the error handling patterns found throughout the codebase. Multiple examples show console.error being used for logging issues in similar async functions, particularly for API operations and validation failures.

🏁 Scripts executed

The following scripts were executed for the analysis:

Error: No shell scripts found


Script:

#!/bin/bash
# Search for console.error usage patterns
rg "console\.error\(" -A 2

# Look for potential error logging utilities
rg "logger\." -A 2
rg "log\." -A 2

# Search for error handling patterns in similar async functions
ast-grep --pattern 'async $_ = $_$ => {
  if (!$_) {
    $$$
    return $_$;
  }
}'

Length of output: 56460

src/main/topLevelPages/myDashboard/newVirtualContributorWizard/newVirtualContributorQueries.graphql (2)

28-44: LGTM! Well-structured GraphQL query

The new AccountSpaces query with the spaceProfileCommunityDetails fragment provides a clean and efficient way to fetch space data.


Line range hint 45-56: LGTM! Simplified fragment structure

The spaceProfileCommunityDetails fragment provides a focused set of fields, improving query efficiency.

src/core/i18n/en/translation.en.json (1)

3158-3159: LGTM! The loading message has been simplified and improved.

The updated loading message is more user-friendly as it removes technical terms like "Subspace" and provides a clearer description of what's happening during the VC creation process.

@bobbykolev bobbykolev requested a review from ccanos January 14, 2025 16:08
ccanos
ccanos previously approved these changes Jan 15, 2025
Copy link
Contributor

@ccanos ccanos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two small comments maybe we can go with them

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/main/topLevelPages/myDashboard/newVirtualContributorWizard/ExistingSpace.tsx (1)

Line range hint 73-82: Consider a more flexible approach for handling space hierarchy.

The current implementation hardcodes three levels of hierarchy using nested forEach loops. Consider using a recursive approach for better maintainability and flexibility.

-    availableSpaces?.forEach((space: SelectableSpace) => {
-      addSelectableSpace(space);
-      space.subspaces?.forEach(subspace => {
-        addSelectableSpace(subspace, [space]);
-        subspace.subspaces?.forEach(subsubspace => {
-          addSelectableSpace(subsubspace, [space, subspace]);
-        });
-      });
-    });
+    const processSpaceHierarchy = (space: SelectableSpace, parentSpaces: SelectableSpace[] = []) => {
+      addSelectableSpace(space, parentSpaces);
+      space.subspaces?.forEach(subspace => 
+        processSpaceHierarchy(subspace, [...parentSpaces, space])
+      );
+    };
+    
+    availableSpaces?.forEach(space => processSpaceHierarchy(space));
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d393ba1 and 1b6e8c2.

📒 Files selected for processing (1)
  • src/main/topLevelPages/myDashboard/newVirtualContributorWizard/ExistingSpace.tsx (4 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
src/main/topLevelPages/myDashboard/newVirtualContributorWizard/ExistingSpace.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

  • We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
  • Avoid flagging the absence of local error handling in cases where the global error handler suffices.
  • Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

  • Not Required: there's a skip
    {
    variables: { templateId: templateId! },
    skip: !templateId,
    }

Check for common security vulnerabilities such as:

  • SQL Injection
  • XSS (Cross-Site Scripting)
  • CSRF (Cross-Site Request Forgery)
  • Insecure dependencies
  • Sensitive data exposure
🔇 Additional comments (3)
src/main/topLevelPages/myDashboard/newVirtualContributorWizard/ExistingSpace.tsx (3)

25-27: LGTM! Props refactoring improves component reusability.

The change from passing pre-fetched spaces to providing an accountId and getSpaces callback follows React's best practices for data fetching and improves component reusability.

Also applies to: 30-30


Line range hint 94-137: LGTM! Form handling and UI implementation.

The form implementation with Formik, validation with Yup, and conditional rendering based on loading and data states follow React best practices. The UI provides appropriate feedback for all states.


35-54: 🛠️ Refactor suggestion

Add error handling for space fetching.

While the fetch implementation is good, it lacks error handling. Consider catching potential errors to provide feedback to users when space fetching fails.

 const fetchSubspaces = async () => {
+  try {
     const spaces = await getSpaces(accountId);
     if (isMounted) {
       setAvailableSpaces(spaces);
     }
+  } catch (error) {
+    if (isMounted) {
+      // Handle error state, e.g., show error message
+      console.error('Failed to fetch spaces:', error);
+      setAvailableSpaces([]);
+    }
+  }
 };

Likely invalid or redundant comment.

@ccanos ccanos merged commit cf82b69 into develop Jan 15, 2025
3 checks passed
@ccanos ccanos deleted the client-7380-vc-account-opt branch January 15, 2025 13:05
This was referenced Jan 27, 2025
reactoholic added a commit that referenced this pull request Jan 29, 2025
* fix forum discussion styles

* update contributors image for unauth users and fix styles (#7354)

* update contributors image for unauth users and fix styles

* resolve pr comments

* Remove location from VC card

* remove usage of anonymousReadAccess (#7332)

* Fix dashboard access (#7360)

* Fix dashboard access

* fixed scope

* change polling interval

* fix pr comment

* renamed to useSpaceTemplate*s*ManagerQuery

---------

Co-authored-by: Carlos Cano <carlos@alkem.io>

* Handling of scroll and page change in documentation. (#7359)

* logs for the frame origin

* add allow-scripts to the docs iframe

* Improve the layout banner of Documentation page;

* Subtitle for the Docs page

* added new tabs to user + org admin pages; refactored contributor admin pages (#7367)

* added new tabs to user + org admin pages; refactored how admin pages for users + orgs + vcs are managed; moved some global admin functionality out of domain down to platform admin; ...

* updated generation to match api tidy ups related to set of preference types + ID passing for org mutations

* fix compile errors related to dropping of separate UserPreferenceType enum

* Synchronize icons, remove comments, make sure there are no redundant settings calls.

* Links & Docs to BoK on VC creation (#7365)

* VC documents and links BoK - refactor the AddContent

* VC documents and links implementation without validation;

* resolve rabbit comments

---------

Co-authored-by: Petar Kolev <33326233+reactoholic@users.noreply.github.com>
Co-authored-by: reactoholic <petar.georgiev.kolev@gmail.com>

* Links and Docs - forgotten commit with Validation  (#7377)

* CalloutsSet entity (#7376)

* codegen passing with updated api

* fixed api + codegen passes

* code compiling

* pick up create callout privilege from the CalloutsSet

* callouts showing up after creation

* retrieving of callouts using only calloutsSet ID

* moved code around to have notion of calloutsSet in tree

* fix array dep breaking tool creation; small code optimizations;

---------

Co-authored-by: bobbykolev <bobbykolev@abv.bg>

* split useCallouts into also useCalloutsOnCollaboration (#7378)

* Style UserAvatar tooltip (#7384)

* Fix: Deleting subspace l2 from its settings throws errors on space dashboard

* InnovationFlow States names validation - no commas (#7391)

* Add arcadeSoftware to the whitelist of iframes (#7397)

* bump client version (#7403)

* implement image pasting in md editor (#7387)

* codegen compilation

* Fix: ENTITY_NOT_FOUND Error is triggered after first login server#4790 (#7396)

* Remove `makeStyles` from `AlkemioAvatar` and `CommunityUpdatesView` (#7390)

* Clean up alkemio avatar component

The goal is to remove `@mui/styles`, but as the component is deprecated,
it is replaced with the new avatar component in the user popup and the
deprecated component is cleaned up from all unused features. The user
popup is inlined in it to simplify more the interface of the
component.

* update contributors image for unauth user (#7410)

* bug fix: verified label overlaps with text (#7415)

* removed usage of AuthorizationCredential, replaced with RoleName; removed usage of UserGroups

* added label to issue templates (#7425)

* Limit the answers length on ApplicationForm (#7419)

* Limit the answers length on ApplicationForm

* Fix error message

---------

Co-authored-by: Petar Kolev <33326233+reactoholic@users.noreply.github.com>

* Display account entitlements (#7414)

* wip

* removed state from some dialogs

---------

Co-authored-by: Carlos Cano <carlos@alkem.io>

* Fix: ENTITY_NOT_FOUND Error is triggered after first login server#4790 (#7396)

* Remove `makeStyles` from `AlkemioAvatar` and `CommunityUpdatesView` (#7390)

* Clean up alkemio avatar component

The goal is to remove `@mui/styles`, but as the component is deprecated,
it is replaced with the new avatar component in the user popup and the
deprecated component is cleaned up from all unused features. The user
popup is inlined in it to simplify more the interface of the
component.

* update contributors image for unauth user (#7410)

* bug fix: verified label overlaps with text (#7415)

* added label to issue templates (#7425)

* Limit the answers length on ApplicationForm (#7419)

* Limit the answers length on ApplicationForm

* Fix error message

---------

Co-authored-by: Petar Kolev <33326233+reactoholic@users.noreply.github.com>

* Display account entitlements (#7414)

* wip

* removed state from some dialogs

---------

Co-authored-by: Carlos Cano <carlos@alkem.io>

* update contributors image for unauth user (#7410)

* first pass fixing

* second pass

* Third pass

* 6 errors left

* Removing scary words in translation.en.json (#7432)

* moved to using UUIDs

* Add Updates from leads block to the subspaces page (l1 & l2). (#7417)

* Add Updates from leads block to the subspaces page (l1 & l2).

* share url

---------

Co-authored-by: Carlos Cano <carlos@alkem.io>

* Fix Sidebar list of spaces not refreshing after subspace delete (#7418)

Co-authored-by: Petar Kolev <33326233+reactoholic@users.noreply.github.com>

* fix

* [VC] Knowledge base instead of Subspace BoK in Written Knowledge step (#7381)

* added new tabs to user + org admin pages; refactored how admin pages for users + orgs + vcs are managed; moved some global admin functionality out of domain down to platform admin; ...

* updated generation to match api tidy ups related to set of preference types + ID passing for org mutations

* fix compile errors related to dropping of separate UserPreferenceType enum

* Synchronize icons, remove comments, make sure there are no redundant settings calls.

* Links & Docs to BoK on VC creation (#7365)

* VC documents and links BoK - refactor the AddContent

* VC documents and links implementation without validation;

* resolve rabbit comments

---------

Co-authored-by: Petar Kolev <33326233+reactoholic@users.noreply.github.com>
Co-authored-by: reactoholic <petar.georgiev.kolev@gmail.com>

* Links and Docs - forgotten commit with Validation  (#7377)

* CalloutsSet entity (#7376)

* codegen passing with updated api

* fixed api + codegen passes

* code compiling

* pick up create callout privilege from the CalloutsSet

* callouts showing up after creation

* retrieving of callouts using only calloutsSet ID

* moved code around to have notion of calloutsSet in tree

* fix array dep breaking tool creation; small code optimizations;

---------

Co-authored-by: bobbykolev <bobbykolev@abv.bg>

* VC knowledge base instead of subspace init

* Space creation after VC creation, loading, code opt & reorganization

* Fix docs uploading, code organization and documentation;

* fix uploading of docs in case there's no space under the acc; remove misleading createdSpaceId usage;

* useLoadingState instead of a new React State

* Fix - set properly the persona type depending on the 3 steps;

* Ability to select SpaceLevel2 on create VC (#7386)

* VC Knowledge Base callouts dialog (#7388)

* VC Knowledge Base callouts dialog - init.
* Filter available callout types.
* disable rich media on VC callout creation.
* Description component with update functionality.
* Update the Create Written Knowledge UI and initial state; Fix dialog titles in VC flow.
* Reingest logic in the Knowledge dialog.
* Remove the icon logic for CalloutVisibilityChangeDialog.
* Use the account hostname for space created in the VC flow.

* fix VC dialog not opening; remove outdated copy;

* storage config for KnowledgeBase description

---------

Co-authored-by: Neil Smyth <neil@thesmyths.eu>
Co-authored-by: Petar Kolev <33326233+reactoholic@users.noreply.github.com>
Co-authored-by: reactoholic <petar.georgiev.kolev@gmail.com>
Co-authored-by: Neil Smyth <30729240+techsmyth@users.noreply.github.com>
Co-authored-by: Carlos Cano <carlos@alkem.io>

* add cspell config (#7404)

* resolveIds returns string and not the entity

* proper check for available account for the vc flow (#7433)

* VirtualContributor fixes

* name ids

* updated for renamed mutation

* Client web/7416 disable image pasting when hide image options flag is true (#7428)

* fix organization verified sign font size by simone's ask

* disable image pasting if hideImageOptions flag is true

* optimize paste handler

* resolve pr comment

* Extract the isImageOrHtmlWithImage and call it once per item.

---------

Co-authored-by: Bobby Kolev <bobbykolev@abv.bg>

* Fix can't add callout to VC KnowledgeBase. (#7437)

Co-authored-by: Valentin Yanakiev <valentin.yanakiev@gmail.com>

* url resolver

* url builders

* Create space link entitlements (#7442)

* check for entitlements in the CreateSpaceLink

(cherry picked from commit aed1830)

* 0.79.7

(cherry picked from commit 7ec232c)

* updated to work with fields for entryRole + elevatedRole availability

* MD fixes - comments not visible with long Post description; `pre` long line not visible; (#7435)

* move fragment

* missing padding for the items on the left block on space and subspaces (#7448)

* Optimize the Contributor Account Tab and VC flow  (#7444)

* Optimize subspace query under acc. Fix first VC/Space flow resulting in errors.

* Fix add to community and navigation related to spaceId

* polishing

* fix navigation of subspaces

* Optimize the main vcWizard account call.

* pr fix

---------

Co-authored-by: Carlos Cano <carlos@alkem.io>

* Admin Roles management

* Available users search. Organizations auth using rolesetAdmin

* Organization roles management

* fix style

* clean up. first 0 errors

* removed usage of platform role set id on mutations for roles on platform as not needed (only one)

* check for the correct privilege for Callout creation

* Add checkbox for adding tutorials when creating new space and fix UI issue in Mozilla regarding the URL input (#7447)

* updated for adjusted privilege names

* [VC Flow] Choose community step (#7457)

* choose community step in vc flow
* fix data reload on home dash;
* refetch the BoK after VC callouts creation

* Append visuals to create profile input (#7301)

* profileData renamed to profile on CreateWhiteboardInput

* Removed visualUrl from post, which doens't make sense on creation

* graphical tweak and little rename

* Fix #7316 Create template permission (#7319)

* Filter file extensions robustly (#7326)

* Fix creating a subspace on a Space by nameId (#7328)

* Fix creating a subspace on a Space by nameId

* remove unused var

* Fix Tutorials Iframes (#7323)

* Fix tutorials iframes

* parse the iframe with the DOMParser instead of with regex

---------

Co-authored-by: Valentin Yanakiev <valentin.yanakiev@gmail.com>

* Add Callouts preview accordion on SubspacesList default subspace template selector (#7325)

* Add Callouts preview accordion on SubspacesList default subspace template selector

* usememo

* memoize the Description component

---------

Co-authored-by: Valentin Yanakiev <valentin.yanakiev@gmail.com>

* codegen

---------

Co-authored-by: Valentin Yanakiev <valentin.yanakiev@gmail.com>

* restrict activities block to 10 results and add activities dialog (#7463)

* Handle missing privileges for add VC to community. (#7470)

* Fix the save as template option missing due to missing array deps (#7476)

* Remove nameIds from VC dialogs

* Entitlements view based on permissions and limits (#7467)

* Fix #7451

* Common component to handle the

---------

Co-authored-by: Svetoslav Petkov <svetoslav@alkem.io>

* display usage-limit of spaces in the account page (#7468)

* display usage-limit of spaces in the account page

* making safer check

---------

Co-authored-by: Svetoslav Petkov <svetoslav@alkem.io>

* removed another url builder

* Remove SpaceRoleSetContributorTypes query and a few unused queries more

* Fix innovationHubs

* Fix add checkbox for tutorials UI bug (#7466)

* fix add checkbox for tutorials ui

* restore graphql files

---------

Co-authored-by: Bobby Kolev <bobbykolev@abv.bg>

* Fix first-child + useEffect dynamic deps array length console errors; (#7477)

Co-authored-by: Petar Kolev <33326233+reactoholic@users.noreply.github.com>

* Bug fix: search bar in spaces page not working, and page refreshes on search term enter (#7462)

* search spaces page not working

* visualize subspaces as well

* resolve pr comment

* resolve pr comment

* fix missing callouts in create template preview (#7482)

Co-authored-by: Petar Kolev <33326233+reactoholic@users.noreply.github.com>

* Fix organization provider

* clean

* Rename files

* Removed variables from notification query (#7481)

* First pass removing useCommunityAdmin

* rename forlder

* wip

* VC Flow - proper filtering of Existing Spaces  (#7490)

* apply multiple filters on space activities (#7489)

Co-authored-by: Bobby Kolev <bobbykolev@abv.bg>

* Available users/orgs/vcs hook

* support knowledge-base route on VC profile (#7480)

* fix nameId issue on VC profile

* fix userNameId issues on UserProfile

* a bit of cleanup. 0 errors again

* fix paste issue (#7493)

* removing fragment CommunityRoleSetDetails

* clean up

* Moved files

* Remove groups

* VC Flow - proper filtering of Existing Spaces  (#7490)

* apply multiple filters on space activities (#7489)

Co-authored-by: Bobby Kolev <bobbykolev@abv.bg>

* support knowledge-base route on VC profile (#7480)

* fix paste issue (#7493)

* VC Flow - proper filtering of Existing Spaces  (#7490)

* UserPage clean nameId

* Removed some unused code

* ApplicationDialog

* invitations in RolesetAdmin

* Delete more group things

* updatePreference mutation

* remove useInviteUsers

* fix md editor typing issue (#7501)

* small refactor

* no space creation when org has no spaces and vc is created

* refetch

* Account storage config for the account resources (#7486)

* use account storage config for entities under the account (instead userStorage)

* refactor a bit

---------

Co-authored-by: Carlos Cano <carlos@alkem.io>

* disable new posts on knowledgebase callouts (#7507)

* knowledgebase-disable-new-posts (#7509)

* No default callouts on space creation w tutorials (#7518)

* update graphql schema

* Add VC Callouts route (#7515)

* Url for posts that are inside VC knowledge-base
* fix url resolver

* 0.80.0 (#7526)

* reingest after creation of a VC with Space BoK (#7536)

* 0.80.1

* BugFix anonymous user access to public space (#7541)

* crowdin config (#7549)

* Fix search in space (#7552)

* Fix search in space

* Also use the lookup for space details

* Translations (#7553)

* 0.80.2

* disabled Crowdin action

---------

Co-authored-by: reactoholic <petar.georgiev.kolev@gmail.com>
Co-authored-by: Petar Kolev <33326233+reactoholic@users.noreply.github.com>
Co-authored-by: Carlos Cano <carlos@alkem.io>
Co-authored-by: Neil Smyth <30729240+techsmyth@users.noreply.github.com>
Co-authored-by: Valentin Yanakiev <valentin.yanakiev@gmail.com>
Co-authored-by: Neil Smyth <neil@thesmyths.eu>
Co-authored-by: Todorka Halacheva <56818790+thalacheva@users.noreply.github.com>
Co-authored-by: Svetoslav Petkov <svetoslav@alkem.io>
Co-authored-by: Simone <38861315+SimoneZaza@users.noreply.github.com>
Co-authored-by: Evgeni Dimitrov <comoque@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants