added new tabs to user + org admin pages; refactored contributor admin pages #7367

techsmyth · 2024-12-21T13:46:02Z

Also moved some global admin functionality out of domain down to platform admin

Generally a very badly needed tidy up within the contributors administration area

Summary by CodeRabbit

New Features
- Enhanced user settings with options for communication preferences and privacy settings.
- Introduced new admin routes for organization management, including settings and authorization pages.
- Added new GraphQL queries and mutations for managing user and organization settings.
- Introduced a tabbed interface for organization admin settings, including profile, community, and settings tabs.
- Added new components for managing organization and user admin settings.
Bug Fixes
- Corrected import paths for several components to reflect updated directory structures.
Removals
- Removed several outdated components related to organization and user settings, streamlining the codebase.

…for users + orgs + vcs are managed; moved some global admin functionality out of domain down to platform admin; ...

coderabbitai · 2024-12-21T13:46:12Z

Walkthrough

This pull request introduces significant changes across multiple files, focusing on enhancing user and organization settings interfaces. Key modifications include adding new sections to the translation.en.json file for user and organization settings, updating import paths for various components, and restructuring the organization of admin routes and views. The changes also involve the removal of outdated components and the introduction of new GraphQL queries and mutations to manage settings more effectively.

Changes

File/Directory	Change Summary
`src/core/i18n/en/translation.en.json`	Added new sections for user and organization settings with enhanced privacy and communication preferences
`src/domain/common/preference/organization/`	Removed `OrganizationPreferenceContainer.tsx`, `OrganizationPreferenceQueries.graphql`, and `preference-types.ts` files, eliminating organization preference management functionality
`src/domain/community/organizationAdmin/`	New directory with admin-specific organization routes, layouts, and views, including `OrganizationAdminRoutes.tsx` and `OrganizationAdminTabs.ts`
`src/domain/community/userAdmin/`	New directory with admin-specific user routes, layouts, and views, including `UserAdminRoute.tsx` and `UserAdminTabs.ts`
`src/domain/platform/admin/layout/EntitySettingsLayout/`	Introduced `SettingsSection.ts` enum and restructured settings-related imports
Import Path Reorganizations	Multiple components updated to use new, more structured import paths

Sequence Diagram

sequenceDiagram
    participant User
    participant UserAdminRoute
    participant UserAdminLayout
    participant UserAdminSettingsView

    User->>UserAdminRoute: Navigate to settings
    UserAdminRoute->>UserAdminLayout: Render layout
    UserAdminLayout->>UserAdminSettingsView: Load settings view
    UserAdminSettingsView->>UserAdminSettingsView: Fetch current settings
    UserAdminSettingsView-->>User: Display settings options

Possibly related PRs

vc profile page #7093: Modifies translation.en.json file
Create Template in Subspace settings - check for parent space permissions #7232: Adds new sections to translation file
[VC invites] Fix BoK not loading every time in preview dialog #7350: Addresses loading issues in VC preview dialog

Suggested Labels

client, translations

Suggested Reviewers

reactoholic

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 5

🔭 Outside diff range comments (7)

src/domain/context/ContextForm/index.tsx (1)
Line range hint 52-57: Consider refactoring form submission handling.

The current implementation has two potential issues:

Using a module-level isSubmitWired flag could cause issues in concurrent renders or multiple form instances

The TODO comment correctly suggests using useImperativeHandle with useRef for better form submission control

Consider refactoring to:
const ContextForm = ({ ... }) => {
  const [isSubmitWired, setIsSubmitWired] = useState(false);
  const formRef = useRef(null);

  useImperativeHandle(formRef, () => ({
    submit: handleSubmit
  }));

  useEffect(() => {
    if (!isSubmitWired) {
      wireSubmit(() => formRef.current?.submit());
      setIsSubmitWired(true);
    }
  }, [wireSubmit]);
  
  // ... rest of the component
}
src/domain/journey/space/spaceEditForm/SpaceEditForm.tsx (1)
Line range hint 14-15: Remove duplicate import of FormikInputField.

The same component is imported twice with different names (FormikInputField and FormikInputFieldField).
- import FormikInputField from '@/core/ui/forms/FormikInputField/FormikInputField';
- import FormikInputFieldField from '@/core/ui/forms/FormikInputField/FormikInputField';
+ import FormikInputField from '@/core/ui/forms/FormikInputField/FormikInputField';
src/domain/journey/subspace/pages/SubspaceSubspaces/SubspaceSubspacesPage.tsx (1)
Line range hint 7-13: Component name doesn't match filename

The component is named ChallengeOpportunitiesPage but exists in a file named SubspaceSubspacesPage.tsx. This mismatch could lead to confusion during maintenance.

Consider renaming the component to match the file name:
-const ChallengeOpportunitiesPage: FC<SettingsPageProps> = ({ routePrefix }) => {
+const SubspaceSubspacesPage: FC<SettingsPageProps> = ({ routePrefix }) => {
   return (
     <SubspaceSettingsLayout currentTab={SettingsSection.Subsubspaces} tabRoutePrefix={routePrefix}>
       <OpportunityList />
     </SubspaceSettingsLayout>
   );
 };
 
-export default ChallengeOpportunitiesPage;
+export default SubspaceSubspacesPage;
src/domain/journey/subspace/pages/SubspaceAuthorization/SubspaceAuthorizationPage.tsx (1)
Line range hint 38-65: Add error handling for mutation

The handleUpdateSettings function should handle potential errors from the GraphQL mutation to provide better user feedback.

Consider implementing error handling like this:
  const handleUpdateSettings = async (
    privacyModeUpdate?: SpacePrivacyMode,
    membershipPolicyUpdate?: CommunityMembershipPolicy,
    hostOrgTrustedUpdate?: boolean
  ) => {
+   try {
      const privacyMode = privacyModeUpdate ? privacyModeUpdate : settings?.privacy.mode ?? SpacePrivacyMode.Public;
      const membershipPolicy =
        membershipPolicyUpdate ?? settings?.membership.policy ?? CommunityMembershipPolicy.Invitations;
      const hostOrgArray = settings?.membership.trustedOrganizations ?? [];
      const hostOrgTrusted = hostOrgTrustedUpdate ?? hostOrgArray.length > 0;
      await updateSubspaceSettings({
        variables: {
          settingsData: {
            spaceID: challengeId,
            settings: {
              privacy: {
                mode: privacyMode,
                allowPlatformSupportAsAdmin: settings?.privacy.allowPlatformSupportAsAdmin ?? false,
              },
              membership: {
                policy: membershipPolicy,
                trustedOrganizations: hostOrgTrusted ? ['myHostOrgID-TODO'] : [],
                allowSubspaceAdminsToInviteMembers: settings?.membership.allowSubspaceAdminsToInviteMembers ?? false,
              },
              collaboration: {
                allowMembersToCreateCallouts: true,
                allowMembersToCreateSubspaces: true,
                inheritMembershipRights: true,
                allowEventsFromSubspaces: true,
              },
            },
          },
        },
      });
+   } catch (error) {
+     console.error('Failed to update subspace settings:', error);
+     // Consider using a toast or notification system to inform the user
+   }
  };
src/domain/community/virtualContributorAdmin/layout/VCSettingsPageLayout.tsx (1)
Line range hint 21-23: Consider safer type handling for tab mapping

The non-null assertion (!) in the tab mapping could lead to runtime errors if a section is not found. Consider adding runtime validation or using a safer pattern.
-const tabs = [SettingsSection.MyProfile, SettingsSection.Membership, SettingsSection.Settings].map(
-  section => VCProfileTabs.find(tab => tab.section === section)!
-);
+const tabs = [SettingsSection.MyProfile, SettingsSection.Membership, SettingsSection.Settings]
+  .map(section => VCProfileTabs.find(tab => tab.section === section))
+  .filter((tab): tab is NonNullable<typeof tab> => tab !== undefined);
src/domain/community/userAdmin/tabs/UserAdminProfilePage.tsx (1)
Line range hint 37-43: Consider enhancing error handling for createTagset mutation

The error is only being logged to console. Consider implementing proper error handling to inform users when tagset creation fails.
 const [createTagset] = useCreateTagsetOnProfileMutation({
-  // Just log the error. Do not send it to the notification hanlder.
-  // there is an issue handling multiple snackbars.
-  onError: error => console.error(error.message),
+  onError: error => {
+    console.error(error.message);
+    notify('Failed to create tagset. Please try again.', 'error');
+  },
 });
src/domain/community/virtualContributorAdmin/VCAccessibilitySettings/VCAccessibilitySettingsPage.tsx (1)
Line range hint 41-52: Add error handling for the update mutation

The mutation lacks proper error handling and could benefit from loading state management.

Apply these changes:
 const [updateContributorMutation] = useUpdateVirtualContributorMutation();
+const [isUpdating, setIsUpdating] = useState(false);
 const handleUpdate = (props: VCAccessibilityProps) => {
+  setIsUpdating(true);
   updateContributorMutation({
     variables: {
       virtualContributorData: {
         ID: data?.virtualContributor?.id ?? '',
         ...props,
       },
     },
     onCompleted: () => {
       notify(t('pages.virtualContributorProfile.success', { entity: t('common.settings') }), 'success');
+      setIsUpdating(false);
     },
+    onError: (error) => {
+      notify(t('common.error.update'), 'error');
+      console.error('Failed to update virtual contributor:', error);
+      setIsUpdating(false);
+    },
   });
 };

🧹 Nitpick comments (32)

src/domain/journey/opportunity/pages/AdminOpportunityCommunityPage.tsx (1)

Line range hint 1-93: Well-structured component with proper separation of concerns.

The component demonstrates good practices:

Proper TypeScript typing

Clean separation of concerns with hooks

Appropriate permission checks

Proper loading state handling

Consistent layout structure using reusable components

Consider breaking down the large permission object into more specific hooks if the permissions grow further, to maintain the single responsibility principle.
src/domain/journey/space/pages/SpaceSettings/SpaceSettingsView.tsx (3)
Line range hint 156-159: Consider using immutable array operations

The current implementation mutates the array using splice. Consider using a more functional approach for better predictability and maintainability.
-      trustedOrganizations.splice(0, trustedOrganizations.length); // Clear the array
+      trustedOrganizations = []; // Create a new empty array
Line range hint 403-405: Replace empty click handler for pending functionality

The disabled duplicate button uses an empty click handler. Consider adding a TODO comment or removing the handler until implementation.
-                <Button variant="outlined" onClick={/* PENDING */ () => {}} disabled>
+                <Button variant="outlined" disabled>
                  {t('pages.admin.space.settings.copySpace.duplicate')}
                </Button>
Line range hint 412-412: Use theme-based colors instead of hardcoded values

Consider using MUI theme colors instead of hardcoded color values for better maintainability and theme consistency.
-            <PageContentBlock sx={{ borderColor: errorColor }}>
+            <PageContentBlock sx={{ borderColor: theme => theme.palette.error.main }}>
src/domain/community/userAdmin/tabs/UserAdminOrganizationsPage.tsx (1)
Line range hint 18-34: Consider adding error state handling.

While the loading state is handled properly, consider adding explicit error state handling for cases where userMetadata fails to load. This would improve the user experience by providing clear feedback when data fetching fails.
 return (
   <UserAdminLayout currentTab={SettingsSection.Organizations}>
     <Grid container rowSpacing={4}>
       <Grid item xs={12}>
         <AssociatedOrganizationsLazilyFetched
           enableLeave
           canCreateOrganization={
             userMetadata?.hasPlatformPrivilege(AuthorizationPrivilege.CreateOrganization) ?? false
           }
           organizationIds={organizationIds ?? []}
           title={t('pages.user-profile.associated-organizations.title')}
           helpText={t('pages.user-profile.associated-organizations.help')}
-          loading={loading}
+          loading={loading}
+          error={!userMetadata && !loading}
           dense
         />
       </Grid>
     </Grid>
   </UserAdminLayout>
 );
src/domain/community/userAdmin/tabs/UserAdminCredentialsPage.tsx (1)
Line range hint 51-203: Consider extracting JSON parsing logic to improve maintainability.

The inline JSON parsing within template literals could be moved to separate utility functions or computed values.
+ const getCredentialContext = (metadata: CredentialMetadata[] | undefined, type: string) => {
+   const context = metadata?.find(m => m.uniqueType === type)?.context || '{}';
+   return JSON.stringify(JSON.parse(context), null, 2);
+ };

  // Then in the render:
- {(() => {
-   const context = credentialMetadata?.find(metadata => 
-     metadata.uniqueType === 'AlkemioMemberCredential')?.context || '{}';
-   return JSON.stringify(JSON.parse(context), null, 2);
- })()}
+ {getCredentialContext(credentialMetadata, 'AlkemioMemberCredential')}
src/domain/journey/space/spaceEditForm/SpaceEditForm.tsx (1)
Line range hint 45-57: Consider optimizing useMemo dependencies.

The useMemo hook for tagsets only depends on the tagset prop, but it's recreating a new array with default values when tagset is undefined. This could be optimized.

Consider extracting the default tagset and memoizing it separately:
const DEFAULT_TAGSETS = [
  {
    id: '',
    name: DEFAULT_TAGSET,
    tags: [],
    allowedValues: [],
    type: TagsetType.Freeform,
  },
] as const;

const SpaceEditForm: FC<SpaceEditFormProps> = ({ ... }) => {
  const tagsets = useMemo(() => 
    tagset ? [tagset] : DEFAULT_TAGSETS,
    [tagset]
  );
  // ... rest of the component
}
src/domain/platform/admin/opportunity/pages/OpportunityProfile/OpportunityProfilePage.tsx (1)
Line range hint 9-10: Consider adding a safety check for array access.

The array access journeyPath[journeyPath.length - 1] could potentially return undefined if the array is empty.

Consider adding a safety check:
- const subspaceId = journeyPath[journeyPath.length - 1];
+ const subspaceId = journeyPath.length > 0 ? journeyPath[journeyPath.length - 1] : undefined;
src/domain/community/userAdmin/tabs/UserAdminAccountPage.tsx (1)
25-31: Consider handling query error states

While loading states are well-handled, consider displaying an error message when queries fail. This would improve the user experience by providing clear feedback.
 return (
   <UserAdminLayout currentTab={SettingsSection.Account}>
+    {(userData?.error || accountData?.error) && (
+      <ErrorMessage message="Failed to load account information" />
+    )}
     <ContributorAccountView
       accountHostName={userData?.user.profile?.displayName ?? ''}
       account={accountData?.lookup.account}
       loading={loadingUser || loadingAccount}
     />
   </UserAdminLayout>
 );
src/domain/community/organizationAdmin/tabs/OrganizationAdminProfilePage.tsx (1)
8-14: Consider destructuring props for better readability.

Even if props aren't currently used, it's good practice to explicitly show which props are expected by destructuring them in the function parameters.
-const OrganizationAdminProfilePage: FC<SettingsPageProps> = () => {
+const OrganizationAdminProfilePage: FC<SettingsPageProps> = ({ ...props }) => {
src/domain/community/organizationAdmin/graphql/updateOrganizationSettings.graphql (1)
2-9: Enhance mutation response with error handling and metadata.

The mutation response is minimal. Consider adding:

Error information for failed updates

Timestamp of the update

User who made the change
 mutation updateOrganizationSettings($settingsData: UpdateOrganizationSettingsInput!) {
   updateOrganizationSettings(settingsData: $settingsData) {
     id
+    updatedAt
+    updatedBy {
+      id
+      displayName
+    }
     settings {
       membership {
         allowUsersMatchingDomainToJoin
       }
+      __typename
     }
+    errors {
+      code
+      message
+    }
   }
 }
src/domain/community/userAdmin/tabs/UserAdminSettingsPage.tsx (1)
5-9: Consider adding type annotations for better maintainability.

While the component works correctly, adding explicit type annotations would improve maintainability.
-export const UserAdminSettingsPage = () => (
+export const UserAdminSettingsPage: React.FC = () => (
src/domain/community/organizationAdmin/tabs/OrganizationAdminSettingsPage.tsx (2)
1-3: Consider using absolute imports for better maintainability.

The relative imports could be replaced with absolute imports using the @/ alias for better maintainability and consistency.
-import OrganizationAdminLayout from '../layout/OrganizationAdminLayout';
-import { SettingsSection } from '../../../platform/admin/layout/EntitySettingsLayout/SettingsSection';
-import OrganizationAdminSettingsView from '../views/OrganizationAdminSettingsView';
+import OrganizationAdminLayout from '@/domain/community/organizationAdmin/layout/OrganizationAdminLayout';
+import { SettingsSection } from '@/domain/platform/admin/layout/EntitySettingsLayout/SettingsSection';
+import OrganizationAdminSettingsView from '@/domain/community/organizationAdmin/views/OrganizationAdminSettingsView';
5-9: Consider creating a shared settings page component.

This component has a very similar structure to UserAdminSettingsPage. Consider creating a shared higher-order component or a generic settings page component to reduce code duplication.

Example approach:
interface AdminSettingsPageProps {
  Layout: React.ComponentType<{ currentTab: SettingsSection }>;
  SettingsView: React.ComponentType;
}

const AdminSettingsPage: React.FC<AdminSettingsPageProps> = ({ Layout, SettingsView }) => (
  <Layout currentTab={SettingsSection.Settings}>
    <SettingsView />
  </Layout>
);
Also, consider adding type annotations for better maintainability:
-const OrganizationAdminSettingsPage = () => (
+const OrganizationAdminSettingsPage: React.FC = () => (
src/domain/platform/admin/layout/EntitySettingsLayout/SettingsSection.ts (1)
1-20: Consider enhancing type safety and consistency

While the enum implementation is functional, consider these improvements:

Maintain consistent casing in values (either all kebab-case or all single words)

Consider using const enum for better performance

Add type guards or utility functions for route matching

Here's a suggested improvement:
-export enum SettingsSection {
+export const enum SettingsSection {
   Profile = 'profile',
   Context = 'context',
   Community = 'community',
   Communications = 'communications',
   Authorization = 'authorization',
   Subspaces = 'subspaces',
   Subsubspaces = 'subsubspaces',
   Templates = 'templates',
   Storage = 'storage',
-  SpaceSettings = 'space-settings',
+  SpaceSettings = 'spacesettings',
   MyProfile = 'my-profile',
   Membership = 'membership',
   Organizations = 'organizations',
   Notifications = 'notifications',
   Credentials = 'credentials',
-  InnovationFlow = 'innovation-flow',
+  InnovationFlow = 'innovationflow',
   Account = 'account',
   Settings = 'settings',
}

+export const isSettingsSection = (value: string): value is SettingsSection => {
+  return Object.values(SettingsSection).includes(value as SettingsSection);
+};
src/domain/community/userAdmin/tabs/UserAdminNotificationsPage.tsx (1)
1-4: Consider optimizing import paths

The import paths could be simplified by using consistent aliases. Consider updating the imports to use the same pattern:
-import UserNotificationsContainer from '../../user/containers/UserNotificationsContainer';
-import { SettingsSection } from '@/domain/platform/admin/layout/EntitySettingsLayout/SettingsSection';
-import UserAdminLayout from '@/domain/community/userAdmin/layout/UserAdminLayout';
-import UserNotificationsPageView from '../views/UserAdminNotificationsPageView';
+import { SettingsSection } from '@/domain/platform/admin/layout/EntitySettingsLayout/SettingsSection';
+import UserAdminLayout from '@/domain/community/userAdmin/layout/UserAdminLayout';
+import UserNotificationsContainer from '@/domain/community/user/containers/UserNotificationsContainer';
+import UserNotificationsPageView from '@/domain/community/userAdmin/views/UserAdminNotificationsPageView';
src/domain/community/organizationAdmin/tabs/OrganizationAdminAuthorizationPage.tsx (1)
1-5: Consider optimizing import paths and adding documentation

The import paths could be more consistent, and the component would benefit from documentation.

Update imports to use consistent aliases:
-import OrganizationAdminLayout from '../layout/OrganizationAdminLayout';
-import { SettingsSection } from '../../../platform/admin/layout/EntitySettingsLayout/SettingsSection';
-import OrganizationAdminAuthorizationView from '../views/OrganizationAdminAuthorizationView';
-import OrganizationOwnerAuthorizationView from '../views/OrganizationOwnerAuthorizationView';
-import { SectionSpacer } from '@/domain/shared/components/Section/Section';
+import { SettingsSection } from '@/domain/platform/admin/layout/EntitySettingsLayout/SettingsSection';
+import { SectionSpacer } from '@/domain/shared/components/Section/Section';
+import OrganizationAdminLayout from '@/domain/community/organizationAdmin/layout/OrganizationAdminLayout';
+import OrganizationAdminAuthorizationView from '@/domain/community/organizationAdmin/views/OrganizationAdminAuthorizationView';
+import OrganizationOwnerAuthorizationView from '@/domain/community/organizationAdmin/views/OrganizationOwnerAuthorizationView';
Add component documentation:
/**
 * OrganizationAdminAuthorizationPage component
 * Renders the authorization management page for organization admins
 * Combines both admin and owner authorization views
 */
src/domain/community/virtualContributorAdmin/VcAdminTabs.ts (1)
7-23: Consider adding documentation for the tab configuration.

The tab configuration is well-structured and type-safe. However, adding JSDoc comments would improve maintainability by documenting the purpose of each tab section.
+/**
+ * Defines the navigation tabs for the Virtual Contributor admin interface.
+ * - Membership: Manages contributor membership details
+ * - MyProfile: Personal profile information
+ * - Settings: General settings and preferences
+ */
export const VCProfileTabs: TabDefinition<SettingsSection>[] = [
src/domain/community/organizationAdmin/tabs/OrganizationAdminCommunityPage.tsx (1)
9-15: Consider memoizing the component for performance optimization.

While the component is well-structured, consider wrapping it with React.memo since it's a pure functional component that receives props.
-const OrganizationAdminCommunityPage: FC<SettingsPageProps> = () => (
+const OrganizationAdminCommunityPage: FC<SettingsPageProps> = React.memo(() => (
   <OrganizationAdminLayout currentTab={SettingsSection.Community}>
     <OrganizationAssociatesView />
     <SectionSpacer />
     <OrganizationGroupsView />
   </OrganizationAdminLayout>
-);
+));
+
+OrganizationAdminCommunityPage.displayName = 'OrganizationAdminCommunityPage';
src/domain/community/organizationAdmin/OrganizationAdminTabs.ts (1)

21-21: Consider using a different icon for the Community section.

The PeopleOutlinedIcon is currently used for both Profile and Community sections, which might cause confusion. Consider using a distinct icon for better visual differentiation.
src/domain/community/userAdmin/UserAdminTabs.ts (1)
45-45: Maintain consistency in icon variants.

Other tab icons use the Outlined variant, but the Settings icon doesn't follow this pattern. Consider using SettingsOutlined to maintain visual consistency.
-    icon: Settings,
+    icon: SettingsOutlined,
src/domain/community/organizationAdmin/tabs/OrganizationAdminAccountPage.tsx (1)
Line range hint 11-24: Consider adding error handling for failed queries.

While loading states are handled properly, the component doesn't handle query errors. Consider displaying an error message when queries fail.
 const { data: organizationData, loading: loadingOrganization } = useOrganizationAccountQuery({
    variables: {
      organizationNameId,
    },
    skip: !organizationNameId,
  });

  const { data: accountData, loading: loadingAccount } = useAccountInformationQuery({
    variables: {
      accountId: organizationData?.organization.account?.id!,
    },
    skip: !organizationData?.organization.account?.id,
  });
+
+ if (error || accountError) {
+   return (
+     <OrganizationAdminLayout currentTab={SettingsSection.Account}>
+       <ErrorDisplay message="Failed to load account information" />
+     </OrganizationAdminLayout>
+   );
+ }
src/domain/community/userAdmin/routing/UserAdminRoute.tsx (2)
19-31: Consider extracting route paths as constants

To improve maintainability and prevent typos, consider extracting the route paths into named constants.

Example implementation:
const USER_ADMIN_ROUTES = {
  PROFILE: 'profile',
  ACCOUNT: 'account',
  MEMBERSHIP: 'membership',
  ORGANIZATIONS: 'organizations',
  NOTIFICATIONS: 'notifications',
  SETTINGS: 'settings',
  CREDENTIALS: 'credentials',
} as const;
5-12: Consider implementing lazy loading for route components

To improve initial load performance, consider implementing lazy loading for the admin pages using React.lazy().

Example implementation:
import { lazy } from 'react';

const UserAdminProfilePage = lazy(() => import('../tabs/UserAdminProfilePage'));
const UserAdminAccountPage = lazy(() => import('../tabs/UserAdminAccountPage'));
// ... other imports
Remember to wrap the routes with <Suspense> when implementing lazy loading.
src/domain/community/userAdmin/tabs/UserAdminMembershipPage.tsx (1)
Line range hint 22-29: Consider refactoring repeated user ID access pattern

The non-null assertion on userMetadata?.user.id! is used multiple times. Consider extracting this to a memoized value to improve code maintainability.
 const UserAdminMembershipPage = () => {
   const { userNameId = '' } = useUrlParams();
   const { user: userMetadata } = useUserMetadata(userNameId);
+  
+  const userId = useMemo(() => userMetadata?.user.id, [userMetadata]);
 
   const { data, loading, refetch } = useUserContributionsQuery({
     variables: {
-      userId: userMetadata?.user.id!,
+      userId: userId!,
     },
-    skip: !userMetadata?.user.id,
+    skip: !userId,
   });
Also applies to: 49-57
src/domain/community/organizationAdmin/views/OrganizationAdminSettingsView.tsx (2)
72-74: Remove commented-out notification code

Either implement the notification functionality or remove the commented code to maintain cleaner codebase.
-    // if (showNotification) {
-    //   notify(t('pages.admin.space.settings.savedSuccessfully'), 'success');
-    // }
79-98: Remove unnecessary Fragment

The Fragment wrapper is unnecessary as it contains only one child element.
     <PageContent background="transparent">
-      {!loading && (
-        <>
-          <PageContentBlock>
-            <BlockTitle>{t('pages.admin.organization.settings.title')}</BlockTitle>
-            <SwitchSettingsGroup
-              options={{
-                allowUsersMatchingDomainToJoin: {
-                  checked: currentSettings?.membership?.allowUsersMatchingDomainToJoin || false,
-                  label: (
-                    <Trans
-                      i18nKey="pages.admin.organization.settings.membership.usersMatchingEmail"
-                      components={{ b: <strong /> }}
-                    />
-                  ),
-                },
-              }}
-              onChange={(setting, newValue) => handleUpdateSettings({ [setting]: newValue })}
-            />
-          </PageContentBlock>
-        </>
-      )}
+      {!loading && (
+        <PageContentBlock>
+          <BlockTitle>{t('pages.admin.organization.settings.title')}</BlockTitle>
+          <SwitchSettingsGroup
+            options={{
+              allowUsersMatchingDomainToJoin: {
+                checked: currentSettings?.membership?.allowUsersMatchingDomainToJoin || false,
+                label: (
+                  <Trans
+                    i18nKey="pages.admin.organization.settings.membership.usersMatchingEmail"
+                    components={{ b: <strong /> }}
+                  />
+                ),
+              },
+            }}
+            onChange={(setting, newValue) => handleUpdateSettings({ [setting]: newValue })}
+          />
+        </PageContentBlock>
+      )}
🧰 Tools

🪛 Biome (1.9.4)

[error] 80-98: Avoid using unnecessary Fragment.

A fragment is redundant if it contains only one child, or if it is the child of a html element, and is not a keyed fragment.
Unsafe fix: Remove the Fragment

(lint/complexity/noUselessFragments)
src/domain/community/userAdmin/views/UserAdminSettingsView.tsx (2)
12-19: Consider moving default settings to a constants file

The defaultUserSettings object should be moved to a dedicated constants file to improve maintainability and reusability across components.

81-99: Remove unnecessary Fragment

The Fragment wrapping the PageContentBlock is unnecessary as it contains only one child element.

Apply this change:
 {!loading && (
-  <>
     <PageContentBlock>
       <BlockTitle>{t('pages.admin.user.settings.title')}</BlockTitle>
       <SwitchSettingsGroup
         options={{
           allowOtherUsersToSendMessages: {
             checked: currentSettings?.communication?.allowOtherUsersToSendMessages || false,
             label: (
               <Trans
                 i18nKey="pages.admin.user.settings.communication.allowOtherUsersToSendMessages"
                 components={{ b: <strong /> }}
               />
             ),
           },
         }}
         onChange={(setting, newValue) => handleUpdateSettings({ [setting]: newValue })}
       />
     </PageContentBlock>
-  </>
 )}
🧰 Tools

🪛 Biome (1.9.4)

[error] 81-99: Avoid using unnecessary Fragment.

A fragment is redundant if it contains only one child, or if it is the child of a html element, and is not a keyed fragment.
Unsafe fix: Remove the Fragment

(lint/complexity/noUselessFragments)
src/domain/community/userAdmin/views/UserAdminNotificationsPageView.tsx (2)
Line range hint 33-34: Consider implementing conditional rendering based on user roles

There are TODO comments indicating that certain sections should be hidden based on user roles, but this logic isn't implemented.

Would you like me to help implement the conditional rendering logic for community and organization administrators?

Line range hint 71-99: Improve conditional rendering logic

The conditional rendering of admin sections could be simplified and made more maintainable.

Consider extracting the admin sections into a separate component:
interface AdminSectionsProps {
  adminGroup: Preference[];
  communityGroup: Preference[];
  loading: boolean;
  onUpdate: (id: string, type: UserPreferenceType, value: boolean) => void;
}

const AdminSections: FC<AdminSectionsProps> = ({ adminGroup, communityGroup, loading, onUpdate }) => {
  const { t } = useTranslation();
  
  if (!adminGroup.length && !communityGroup.length) return null;
  
  return (
    <>
      {adminGroup.length > 0 && (
        <PreferenceSection
          headerText={t('pages.user-notifications-settings.user-administration.title')}
          subHeaderText={t('pages.user-notifications-settings.user-administration.subtitle')}
          preferences={adminGroup}
          loading={loading}
          onUpdate={onUpdate}
        />
      )}
      {communityGroup.length > 0 && (
        <PreferenceSection
          headerText={t('pages.user-notifications-settings.community-administration.title')}
          subHeaderText={t('pages.user-notifications-settings.community-administration.subtitle')}
          preferences={communityGroup}
          loading={loading}
          onUpdate={onUpdate}
        />
      )}
    </>
  );
};
src/domain/community/virtualContributorAdmin/VCAccessibilitySettings/VCAccessibilitySettingsPage.tsx (1)
Line range hint 20-24: Improve type safety of VCAccessibilityProps

The optional properties in VCAccessibilityProps could be more strictly typed.

Consider this improvement:
type VCAccessibilityProps = Partial<{
  listedInStore: boolean;
  searchVisibility: SearchVisibility;
}>;

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 96d6b02 and 19f2c3e.

⛔ Files ignored due to path filters (3)

src/core/apollo/generated/apollo-helpers.ts is excluded by !**/generated/**
src/core/apollo/generated/apollo-hooks.ts is excluded by !**/generated/**
src/core/apollo/generated/graphql-schema.ts is excluded by !**/generated/**

📒 Files selected for processing (82)

src/core/i18n/en/translation.en.json (1 hunks)
src/core/ui/content/LabeledCount.tsx (1 hunks)
src/domain/common/preference/organization/OrganizationPreferenceContainer.tsx (0 hunks)
src/domain/common/preference/organization/OrganizationPreferenceQueries.graphql (0 hunks)
src/domain/common/preference/preference-types.ts (0 hunks)
src/domain/community/contributor/organization/views/OrganizationAuthorizationPreferencesView.tsx (0 hunks)
src/domain/community/organization/layout/OrganizationPageLayout.tsx (1 hunks)
src/domain/community/organization/pages/OrganizationPage.tsx (1 hunks)
src/domain/community/organization/routing/OrganizationRoute.tsx (1 hunks)
src/domain/community/organizationAdmin/OrganizationAdminRoutes.tsx (2 hunks)
src/domain/community/organizationAdmin/OrganizationAdminTabs.ts (1 hunks)
src/domain/community/organizationAdmin/OrganizationGroupRoute.tsx (1 hunks)
src/domain/community/organizationAdmin/OrganizationGroupsRoute.tsx (1 hunks)
src/domain/community/organizationAdmin/graphql/organizationSettingsQueries.graphql (1 hunks)
src/domain/community/organizationAdmin/graphql/updateOrganizationSettings.graphql (1 hunks)
src/domain/community/organizationAdmin/index.ts (1 hunks)
src/domain/community/organizationAdmin/layout/OrganizationAdminLayout.tsx (2 hunks)
src/domain/community/organizationAdmin/tabs/OrganizationAdminAccountPage.tsx (1 hunks)
src/domain/community/organizationAdmin/tabs/OrganizationAdminAuthorizationPage.tsx (1 hunks)
src/domain/community/organizationAdmin/tabs/OrganizationAdminCommunityPage.tsx (1 hunks)
src/domain/community/organizationAdmin/tabs/OrganizationAdminProfilePage.tsx (1 hunks)
src/domain/community/organizationAdmin/tabs/OrganizationAdminSettingsPage.tsx (1 hunks)
src/domain/community/organizationAdmin/views/OrganizationAdminSettingsView.tsx (1 hunks)
src/domain/community/profile/views/ProfileView/OrganizationProfileView.tsx (1 hunks)
src/domain/community/user/pages/UserNotificationsPage.tsx (0 hunks)
src/domain/community/user/routing/UserRoute.tsx (2 hunks)
src/domain/community/user/routing/UserSettingsRoute.tsx (0 hunks)
src/domain/community/userAdmin/UserAdminTabs.ts (2 hunks)
src/domain/community/userAdmin/graphql/updateUserSettings.graphql (1 hunks)
src/domain/community/userAdmin/graphql/userSettingsQueries.graphql (1 hunks)
src/domain/community/userAdmin/layout/UserAdminLayout.tsx (3 hunks)
src/domain/community/userAdmin/routing/UserAdminRoute.tsx (1 hunks)
src/domain/community/userAdmin/tabs/UserAdminAccountPage.tsx (2 hunks)
src/domain/community/userAdmin/tabs/UserAdminCredentialsPage.tsx (3 hunks)
src/domain/community/userAdmin/tabs/UserAdminMembershipPage.tsx (3 hunks)
src/domain/community/userAdmin/tabs/UserAdminNotificationsPage.tsx (1 hunks)
src/domain/community/userAdmin/tabs/UserAdminOrganizationsPage.tsx (2 hunks)
src/domain/community/userAdmin/tabs/UserAdminProfilePage.tsx (3 hunks)
src/domain/community/userAdmin/tabs/UserAdminSettingsPage.tsx (1 hunks)
src/domain/community/userAdmin/views/UserAdminNotificationsPageView.tsx (1 hunks)
src/domain/community/userAdmin/views/UserAdminSettingsView.tsx (1 hunks)
src/domain/community/virtualContributor/VCRoute.tsx (1 hunks)
src/domain/community/virtualContributor/vcMembershipPage/VCMembershipPage.tsx (1 hunks)
src/domain/community/virtualContributorAdmin/VCAccessibilitySettings/VCAccessibilitySettingsPage.tsx (1 hunks)
src/domain/community/virtualContributorAdmin/VCSettingsRoute.tsx (1 hunks)
src/domain/community/virtualContributorAdmin/VcAdminTabs.ts (1 hunks)
src/domain/community/virtualContributorAdmin/layout/VCSettingsPageLayout.tsx (1 hunks)
src/domain/community/virtualContributorAdmin/vcSettingsPage/VCEditProfilePage.tsx (1 hunks)
src/domain/community/virtualContributorAdmin/vcSettingsPage/VirtualContributorForm.tsx (1 hunks)
src/domain/context/ContextForm/index.tsx (1 hunks)
src/domain/journey/opportunity/pages/AdminOpportunityCommunityPage.tsx (1 hunks)
src/domain/journey/space/pages/AdminSpaceCommunityPage.tsx (1 hunks)
src/domain/journey/space/pages/SpaceAccount/SpaceAccountPage.tsx (1 hunks)
src/domain/journey/space/pages/SpaceCommunication/SpaceCommunicationsPage.tsx (1 hunks)
src/domain/journey/space/pages/SpaceContext/SpaceContextPage.tsx (1 hunks)
src/domain/journey/space/pages/SpaceProfile/SpaceProfilePage.tsx (1 hunks)
src/domain/journey/space/pages/SpaceSettings/EditVirtualContributorDialog.tsx (1 hunks)
src/domain/journey/space/pages/SpaceSettings/SpaceSettingsPage.tsx (1 hunks)
src/domain/journey/space/pages/SpaceSettings/SpaceSettingsView.tsx (1 hunks)
src/domain/journey/space/pages/SpaceSubspaces/SubspaceListPage.tsx (1 hunks)
src/domain/journey/space/spaceEditForm/SpaceEditForm.tsx (1 hunks)
src/domain/journey/subspace/pages/AdminSubspaceCommunityPage.tsx (1 hunks)
src/domain/journey/subspace/pages/SubspaceAuthorization/SubspaceAuthorizationPage.tsx (1 hunks)
src/domain/journey/subspace/pages/SubspaceCommunications/SubspaceCommunicationsPage.tsx (1 hunks)
src/domain/journey/subspace/pages/SubspaceContext/SubspaceContextPage.tsx (1 hunks)
src/domain/journey/subspace/pages/SubspaceProfile/SubspaceProfilePage.tsx (1 hunks)
src/domain/journey/subspace/pages/SubspaceSubspaces/SubspaceSubspacesPage.tsx (1 hunks)
src/domain/platform/admin/components/Group/EditMembersPage.tsx (1 hunks)
src/domain/platform/admin/components/Group/GroupPage.tsx (1 hunks)
src/domain/platform/admin/components/Organization/CreateOrganizationGroup.tsx (1 hunks)
src/domain/platform/admin/components/Organization/OrganizationForm.tsx (2 hunks)
src/domain/platform/admin/layout/EntitySettingsLayout/EntitySettingsLayout.tsx (1 hunks)
src/domain/platform/admin/layout/EntitySettingsLayout/SettingsSection.ts (1 hunks)
src/domain/platform/admin/opportunity/pages/OpportunityCommunications/OpportunityCommunicationsPage.tsx (1 hunks)
src/domain/platform/admin/opportunity/pages/OpportunityContext/OpportunityContextPage.tsx (1 hunks)
src/domain/platform/admin/opportunity/pages/OpportunityProfile/OpportunityProfilePage.tsx (1 hunks)
src/domain/platform/admin/opportunity/pages/OpportunitySettings/OpportunitySettingsPage.tsx (1 hunks)
src/domain/platform/admin/organization/OrganizationAuthorizationPage.tsx (0 hunks)
src/domain/platform/admin/organization/OrganizationCommunityPage.tsx (0 hunks)
src/domain/platform/admin/organization/OrganizationProfilePage.tsx (0 hunks)
src/domain/platform/admin/organization/index.ts (0 hunks)
src/domain/platform/admin/organization/views/OrganizationAuthorizationPreferencesPageView.tsx (0 hunks)

⛔ Files not processed due to max files limit (12)

src/domain/platform/admin/organizations/AdminOrganizationsRoutes.tsx
src/domain/platform/admin/routing/AdminRoute.tsx
src/domain/platform/admin/space/SpaceSettingsLayout.tsx
src/domain/platform/admin/space/SpaceTemplatesAdminPage.tsx
src/domain/platform/admin/space/storage/SpaceStorageAdminPage.tsx
src/domain/platform/admin/subspace/SubspaceSettingsLayout.tsx
src/domain/platform/admin/users/useAdminGlobalUserList.tsx
src/domain/templates-manager/SelectDefaultCollaborationTemplate/SelectDefaultCollaborationTemplateDialog.tsx
src/main/admin/authorizationPolicies/AuthorizationPrivilegesForUser.tsx
src/main/admin/users/adminUsers/AdminUsersPage.tsx
src/main/routing/TopLevelRoutes.tsx
src/main/ui/settings/PreferenceSection.tsx

💤 Files with no reviewable changes (11)

src/domain/common/preference/preference-types.ts
src/domain/platform/admin/organization/index.ts
src/domain/community/user/routing/UserSettingsRoute.tsx
src/domain/platform/admin/organization/OrganizationCommunityPage.tsx
src/domain/community/user/pages/UserNotificationsPage.tsx
src/domain/platform/admin/organization/OrganizationAuthorizationPage.tsx
src/domain/platform/admin/organization/OrganizationProfilePage.tsx
src/domain/platform/admin/organization/views/OrganizationAuthorizationPreferencesPageView.tsx
src/domain/common/preference/organization/OrganizationPreferenceQueries.graphql
src/domain/common/preference/organization/OrganizationPreferenceContainer.tsx
src/domain/community/contributor/organization/views/OrganizationAuthorizationPreferencesView.tsx

✅ Files skipped from review due to trivial changes (20)

src/domain/community/organizationAdmin/index.ts
src/domain/journey/subspace/pages/SubspaceContext/SubspaceContextPage.tsx
src/domain/journey/space/pages/SpaceSubspaces/SubspaceListPage.tsx
src/domain/platform/admin/opportunity/pages/OpportunityCommunications/OpportunityCommunicationsPage.tsx
src/domain/journey/space/pages/SpaceSettings/EditVirtualContributorDialog.tsx
src/domain/platform/admin/opportunity/pages/OpportunitySettings/OpportunitySettingsPage.tsx
src/domain/journey/space/pages/SpaceSettings/SpaceSettingsPage.tsx
src/domain/community/organizationAdmin/OrganizationGroupRoute.tsx
src/domain/journey/space/pages/SpaceCommunication/SpaceCommunicationsPage.tsx
src/domain/community/profile/views/ProfileView/OrganizationProfileView.tsx
src/domain/journey/space/pages/AdminSpaceCommunityPage.tsx
src/domain/community/virtualContributor/vcMembershipPage/VCMembershipPage.tsx
src/domain/community/virtualContributorAdmin/vcSettingsPage/VCEditProfilePage.tsx
src/domain/community/organizationAdmin/OrganizationGroupsRoute.tsx
src/domain/journey/space/pages/SpaceAccount/SpaceAccountPage.tsx
src/domain/journey/subspace/pages/SubspaceCommunications/SubspaceCommunicationsPage.tsx
src/domain/journey/subspace/pages/AdminSubspaceCommunityPage.tsx
src/domain/platform/admin/components/Group/GroupPage.tsx
src/domain/community/virtualContributorAdmin/vcSettingsPage/VirtualContributorForm.tsx
src/domain/platform/admin/components/Group/EditMembersPage.tsx

🧰 Additional context used

📓 Path-based instructions (51)

src/domain/community/userAdmin/views/UserAdminNotificationsPageView.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/community/organizationAdmin/graphql/updateOrganizationSettings.graphql (1)

Pattern src/**/*.{graphql,gql}: Review the GraphQL schema and queries for best practices, potential bugs, and adherence to the project's GraphQL standards.
Ensure that the schema is well-defined and queries are optimized.
Check for security vulnerabilities.

src/domain/platform/admin/layout/EntitySettingsLayout/SettingsSection.ts (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/community/organizationAdmin/tabs/OrganizationAdminSettingsPage.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/journey/subspace/pages/SubspaceProfile/SubspaceProfilePage.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/community/organizationAdmin/graphql/organizationSettingsQueries.graphql (1)

Pattern src/**/*.{graphql,gql}: Review the GraphQL schema and queries for best practices, potential bugs, and adherence to the project's GraphQL standards.
Ensure that the schema is well-defined and queries are optimized.
Check for security vulnerabilities.

src/domain/journey/subspace/pages/SubspaceSubspaces/SubspaceSubspacesPage.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/community/virtualContributor/VCRoute.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/journey/space/pages/SpaceProfile/SpaceProfilePage.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/context/ContextForm/index.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/community/organizationAdmin/tabs/OrganizationAdminProfilePage.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/journey/opportunity/pages/AdminOpportunityCommunityPage.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/core/ui/content/LabeledCount.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/community/userAdmin/tabs/UserAdminNotificationsPage.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/community/userAdmin/tabs/UserAdminSettingsPage.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/platform/admin/opportunity/pages/OpportunityContext/OpportunityContextPage.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/community/userAdmin/graphql/updateUserSettings.graphql (1)

Pattern src/**/*.{graphql,gql}: Review the GraphQL schema and queries for best practices, potential bugs, and adherence to the project's GraphQL standards.
Ensure that the schema is well-defined and queries are optimized.
Check for security vulnerabilities.

src/domain/platform/admin/opportunity/pages/OpportunityProfile/OpportunityProfilePage.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/journey/subspace/pages/SubspaceAuthorization/SubspaceAuthorizationPage.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/community/userAdmin/routing/UserAdminRoute.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/community/userAdmin/views/UserAdminSettingsView.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/journey/space/pages/SpaceContext/SpaceContextPage.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/community/userAdmin/graphql/userSettingsQueries.graphql (1)

Pattern src/**/*.{graphql,gql}: Review the GraphQL schema and queries for best practices, potential bugs, and adherence to the project's GraphQL standards.
Ensure that the schema is well-defined and queries are optimized.
Check for security vulnerabilities.

src/domain/community/userAdmin/tabs/UserAdminAccountPage.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/community/organizationAdmin/OrganizationAdminTabs.ts (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/community/userAdmin/tabs/UserAdminMembershipPage.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/community/userAdmin/UserAdminTabs.ts (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/community/virtualContributorAdmin/VcAdminTabs.ts (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/community/virtualContributorAdmin/VCSettingsRoute.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/community/organization/layout/OrganizationPageLayout.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/community/user/routing/UserRoute.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/community/virtualContributorAdmin/layout/VCSettingsPageLayout.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/community/organizationAdmin/tabs/OrganizationAdminCommunityPage.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/platform/admin/components/Organization/CreateOrganizationGroup.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/community/organization/pages/OrganizationPage.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/community/userAdmin/layout/UserAdminLayout.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/journey/space/pages/SpaceSettings/SpaceSettingsView.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/community/userAdmin/tabs/UserAdminCredentialsPage.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/platform/admin/layout/EntitySettingsLayout/EntitySettingsLayout.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/community/virtualContributorAdmin/VCAccessibilitySettings/VCAccessibilitySettingsPage.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/community/userAdmin/tabs/UserAdminOrganizationsPage.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/community/organization/routing/OrganizationRoute.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/community/userAdmin/tabs/UserAdminProfilePage.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/community/organizationAdmin/tabs/OrganizationAdminAuthorizationPage.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/community/organizationAdmin/layout/OrganizationAdminLayout.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/core/i18n/en/translation.en.json (1)

Pattern src/**/*.json: Review the JSON files for correct syntax and structure.
Ensure that the configuration and data are accurate and follow the project's standards.
Check for sensitive data exposure and ensure that the data is properly validated.

src/domain/platform/admin/components/Organization/OrganizationForm.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/journey/space/spaceEditForm/SpaceEditForm.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/community/organizationAdmin/OrganizationAdminRoutes.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/community/organizationAdmin/views/OrganizationAdminSettingsView.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/community/organizationAdmin/tabs/OrganizationAdminAccountPage.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

🪛 Biome (1.9.4)

src/domain/community/userAdmin/views/UserAdminSettingsView.tsx

[error] 81-99: Avoid using unnecessary Fragment.

A fragment is redundant if it contains only one child, or if it is the child of a html element, and is not a keyed fragment.
Unsafe fix: Remove the Fragment

(lint/complexity/noUselessFragments)

src/domain/community/organizationAdmin/views/OrganizationAdminSettingsView.tsx

[error] 80-98: Avoid using unnecessary Fragment.

A fragment is redundant if it contains only one child, or if it is the child of a html element, and is not a keyed fragment.
Unsafe fix: Remove the Fragment

(lint/complexity/noUselessFragments)

🔇 Additional comments (57)

src/domain/journey/opportunity/pages/AdminOpportunityCommunityPage.tsx (1)

8-8: LGTM! Import path change aligns with the refactoring objectives.

The updated import path for SettingsSection from a dedicated file instead of constants improves code organization and maintainability.

src/domain/journey/space/pages/SpaceSettings/SpaceSettingsView.tsx (1)

31-31: LGTM: Import path refactoring improves module organization

The change from importing SettingsSection from constants to a dedicated module improves code organization and maintainability.

src/domain/community/userAdmin/tabs/UserAdminOrganizationsPage.tsx (3)

4-7: LGTM! Import paths properly restructured.

The import paths have been updated to use absolute imports and reflect the new admin-focused structure, which aligns well with the PR objectives of refactoring the admin pages.

11-16: LGTM! Component properly renamed and hooks well-structured.

The component has been appropriately renamed to reflect its admin context, and the hooks usage follows React best practices.

38-38: LGTM! Export statement properly updated.

The default export has been correctly updated to match the new component name.

src/domain/community/userAdmin/tabs/UserAdminCredentialsPage.tsx (3)

15-20: LGTM! Import changes align with the architectural restructuring.

The updated imports properly reflect the movement of components to their new locations and maintain a clear organizational structure.

Line range hint 22-50: LGTM! Component state management is well-structured.

The component rename aligns with its administrative purpose, and the state management implementation properly handles credential verification with appropriate feedback.

207-207: LGTM! Export follows React conventions.

The default export is appropriately updated to match the renamed component.

src/domain/community/user/routing/UserRoute.tsx (2)

15-15: LGTM! Good preservation of URL structure.

The route maintains the existing URL pattern (settings/*) while switching to the admin implementation, ensuring a smooth transition without breaking existing URLs.

4-4: LGTM! Verify the new import path exists.

The import path change aligns with moving functionality to the platform admin level.

✅ Verification successful

Import path is correct and component exists

The UserAdminRoute component exists at the expected location src/domain/community/userAdmin/routing/UserAdminRoute.tsx and is properly exported as a default export. The import path in UserRoute.tsx correctly references this file using a relative path.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the new UserAdminRoute component exists and is exported correctly

# Check if the file exists and exports the component
ast-grep --pattern 'export default UserAdminRoute' '../../userAdmin/routing/UserAdminRoute'

Length of output: 177

Script:

#!/bin/bash
# Let's try to find the UserAdminRoute file in the repository
fd UserAdminRoute

# Also search for any file that exports UserAdminRoute
ast-grep --pattern 'export default UserAdminRoute'

# Let's also check if there are any references to UserAdminRoute in the codebase
rg "UserAdminRoute" -A 2

Length of output: 1197

src/domain/context/ContextForm/index.tsx (1)

15-16: LGTM! Type changes align with PR objectives.

The removal of 'anonymousReadAccess' from Context type aligns with moving functionality to platform admin level. The Profile type modifications appropriately remove unused fields.

src/domain/journey/space/spaceEditForm/SpaceEditForm.tsx (1)

26-27: LGTM! Type changes are consistent.

The type changes align with the corresponding changes in ContextForm and the overall PR objectives.

src/domain/platform/admin/opportunity/pages/OpportunityContext/OpportunityContextPage.tsx (1)

1-1: LGTM! Import path change aligns with codebase restructuring.

The change from importing SettingsSection from constants to a dedicated module improves code organization and maintainability.

Let's verify this refactoring is consistent across the codebase:

✅ Verification successful

Import path change is consistently used across the codebase

The verification shows that all imports of SettingsSection are using the new path @/domain/platform/admin/layout/EntitySettingsLayout/SettingsSection consistently. No instances of the old import path from constants were found, confirming the refactoring is complete and consistent.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for any remaining imports from the old constants path
# and verify the new path is consistently used

# Check for any remaining old imports
rg "import.*SettingsSection.*from.*EntitySettingsLayout/constants"

# Verify new import pattern usage
rg "import.*SettingsSection.*from.*EntitySettingsLayout/SettingsSection"

Length of output: 8518

src/domain/platform/admin/opportunity/pages/OpportunityProfile/OpportunityProfilePage.tsx (1)

1-1: LGTM! Import path change is consistent with the codebase restructuring.

The change from importing SettingsSection from constants to a dedicated module maintains consistency with the broader refactoring effort.

src/domain/community/userAdmin/tabs/UserAdminAccountPage.tsx (2)

Line range hint 7-23: LGTM! Well-structured query handling

The component properly handles loading states and skip conditions for both queries. The non-null assertion usage is correct as it's paired with a skip condition.

7-7: Verify component rename impact

The component has been renamed from UserAccountPage to UserAdminAccountPage. Let's verify that all imports have been updated accordingly.

Also applies to: 35-35

✅ Verification successful

Component rename verification completed

No references to the old component name UserAccountPage were found in the TypeScript/React files across the codebase, indicating that all imports have been properly updated to use the new name UserAdminAccountPage.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for any remaining references to the old component name
rg "UserAccountPage" --type ts --type tsx

Length of output: 69

Script:

#!/bin/bash
# Search for any remaining references to the old component name using ripgrep
# Note: Using --type-add to properly handle TypeScript/React files
rg "UserAccountPage" --type-add 'tsx:*.tsx' --type-add 'ts:*.ts' --type tsx --type ts

Length of output: 85

src/domain/journey/space/pages/SpaceProfile/SpaceProfilePage.tsx (1)

4-4: LGTM! Verify other usages of SettingsSection

The import path change is consistent with the refactoring objectives. The component structure and typing remain solid.

Let's verify that this import path change is consistent across the codebase:

✅ Verification successful

Import path changes are consistent across the codebase

All files importing SettingsSection are using the new path @/domain/platform/admin/layout/EntitySettingsLayout/SettingsSection, and there are no remaining imports from the old path with constants. The changes are consistent with the refactoring objectives.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for any remaining old imports of SettingsSection from constants
rg "import.*SettingsSection.*EntitySettingsLayout/constants" 

# Search for new import pattern to confirm consistency
rg "import.*SettingsSection.*EntitySettingsLayout/SettingsSection"

Length of output: 8506

src/domain/journey/space/pages/SpaceContext/SpaceContextPage.tsx (1)

4-4: LGTM! Import path change maintains consistency

The update follows the same pattern as other files, maintaining a consistent approach to importing SettingsSection.

src/domain/journey/subspace/pages/SubspaceSubspaces/SubspaceSubspacesPage.tsx (1)

3-3: Import path change is consistent

The update follows the established pattern for SettingsSection imports.

src/domain/journey/subspace/pages/SubspaceProfile/SubspaceProfilePage.tsx (1)

3-3: LGTM! Import path modification aligns with refactoring objectives.

The change to import SettingsSection from a dedicated module improves code organization and maintainability.

src/domain/journey/subspace/pages/SubspaceAuthorization/SubspaceAuthorizationPage.tsx (2)

2-2: LGTM! Import path modification aligns with refactoring objectives.

The change to import SettingsSection from a dedicated module improves code organization and maintainability.

Line range hint 54-54: Remove hardcoded organization ID

The hardcoded value 'myHostOrgID-TODO' should be replaced with the actual organization ID. This could cause issues in production if not addressed.

Let's verify if this hardcoded value exists elsewhere in the codebase:

✅ Verification successful

Remove hardcoded organization ID 'myHostOrgID-TODO'

The hardcoded value is confirmed to exist in src/domain/journey/subspace/pages/SubspaceAuthorization/SubspaceAuthorizationPage.tsx within the trustedOrganizations array. This is the only instance of this hardcoded value in the codebase, making it a straightforward issue to address.

Replace 'myHostOrgID-TODO' in SubspaceAuthorizationPage.tsx with the actual organization ID from your configuration or environment variables.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for hardcoded organization ID
rg "myHostOrgID-TODO" --type ts --type tsx

Length of output: 70

Script:

#!/bin/bash
# Search for hardcoded organization ID with ripgrep, without file type restrictions
rg "myHostOrgID-TODO"

Length of output: 187

src/domain/community/organizationAdmin/tabs/OrganizationAdminProfilePage.tsx (3)

1-6: LGTM! Well-organized imports with proper typing.

The imports are logically organized and all are being used in the component.

16-16: LGTM! Proper export statement.

The default export follows React component conventions.

8-8: Verify if SettingsPageProps are needed.

The component is typed with SettingsPageProps but doesn't appear to use any props. Please verify if this type is necessary or if there are missing prop usages.

✅ Verification successful

Looking at the search results, I can see that SettingsPageProps is used across multiple components in the codebase, and most components that use it accept a routePrefix prop. Let me search for the type definition to confirm if this prop is required.

Let me try a different approach to find the type definition using ast-grep:

The SettingsPageProps type is needed but routePrefix is optional

The SettingsPageProps interface is defined in src/domain/platform/admin/layout/EntitySettingsLayout/types.ts with an optional routePrefix prop. Since the component is using the layout pattern consistently with other admin pages, the type should be kept even though the component doesn't use the optional prop.

The type provides consistency across all settings pages in the application
The routePrefix prop is marked as optional with ?, so it's valid to not use it
Other components in the same directory (OrganizationAdmin) follow the same pattern

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check the SettingsPageProps type definition and its usage across the codebase

# Check the type definition
ast-grep --pattern 'type SettingsPageProps = {
  $$$
}'

# Check other components using SettingsPageProps to understand the expected usage
ast-grep --pattern 'const $_ : FC<SettingsPageProps> = $_'

Length of output: 45071

Script:

#!/bin/bash
# Search for SettingsPageProps type definition
rg -A 5 "type SettingsPageProps"

Length of output: 34

Script:

#!/bin/bash
# Search for SettingsPageProps type definition using different patterns
ast-grep --pattern 'type SettingsPageProps = $_'

# Also try interface definition
ast-grep --pattern 'interface SettingsPageProps {
  $$$
}'

# Check for potential type imports
rg "import.*SettingsPageProps.*from"

Length of output: 4445

src/domain/community/organizationAdmin/graphql/updateOrganizationSettings.graphql (1)

1-10: ⚠️ Potential issue

Consider adding authorization directives and input validation.

The mutation lacks explicit authorization controls and input validation. Consider:

Adding @requireAuth or similar directive to ensure only authorized users can modify settings
Making the input fields nullable to support partial updates
Including validation directives for the input fields

Let's verify if other mutations use authorization directives:

src/domain/community/userAdmin/graphql/userSettingsQueries.graphql (1)

2-3: Consider removing the nested lookup layer.

The lookup nesting seems unnecessary and could be simplified by directly querying the user.

Let's check if other queries use this pattern:

src/domain/community/userAdmin/graphql/updateUserSettings.graphql (1)

1-13: LGTM! Clean and well-structured mutation.

The mutation is well-organized with appropriate return fields and type safety through UpdateUserSettingsInput.

Let's verify the input type definition:

src/domain/community/userAdmin/tabs/UserAdminSettingsPage.tsx (1)

1-3: LGTM! Clean imports and good separation of concerns.

The component follows good practices with clear separation between layout and view components.

src/domain/community/organizationAdmin/tabs/OrganizationAdminAuthorizationPage.tsx (1)

7-13: LGTM! Clean component structure

The component follows good practices:

Single responsibility principle
Clear separation of concerns
Logical grouping of related views

src/domain/community/virtualContributorAdmin/VcAdminTabs.ts (1)

1-6: LGTM! Clean and well-organized imports.

The imports are properly organized, using named imports for types and components. Material UI icons are imported individually which is good for tree-shaking.

src/domain/community/virtualContributor/VCRoute.tsx (2)

Line range hint 9-27: LGTM! Well-structured routing configuration.

The routing structure is clean and follows React Router best practices:

Proper nesting of routes
Clear URL parameter naming
Appropriate error handling with 404 page

6-6: Verify the new import path across the codebase.

The import path change from './VCSettingsRoute' to '../virtualContributorAdmin/VCSettingsRoute' needs verification to ensure all references are updated.

✅ Verification successful

Import path change is correctly implemented

The import path change has been properly implemented across the codebase. The search results show:

No instances of the old import path './VCSettingsRoute'
The new import path '../virtualContributorAdmin/VCSettingsRoute' is used consistently in VCRoute.tsx
VCSettingsRoute is correctly defined in its new location and properly referenced only where needed

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for any remaining old import paths
rg "from './VCSettingsRoute'" --type ts --type tsx

# Search for consistency in new import path usage
rg "from '../virtualContributorAdmin/VCSettingsRoute'" --type ts --type tsx

Length of output: 198

Script:

#!/bin/bash
# Search for any remaining old import paths without file type restrictions
rg "from './VCSettingsRoute'"

# Search for consistency in new import path usage
rg "from '../virtualContributorAdmin/VCSettingsRoute'"

# Find all files that might reference VCSettingsRoute
rg "VCSettingsRoute"

Length of output: 683

src/domain/community/virtualContributorAdmin/VCSettingsRoute.tsx (1)

5-5: LGTM! Import path update aligns with refactoring objectives.

The updated import path reflects the reorganization of contributor-related components, improving code organization.

✅ Verification successful

Import path update verified and correct

The new import path ../virtualContributor/vcMembershipPage/VCMembershipPage is valid as confirmed by the existence of the file at src/domain/community/virtualContributor/vcMembershipPage/VCMembershipPage.tsx. The directory structure matches the import path relative to the importing file's location.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Verify the new import path exists and is correctly referenced
fd "vcMembershipPage" --type d

Length of output: 88

Script:

#!/bin/bash
# Verify if the VCMembershipPage component exists in the correct location
ast-grep --pattern 'export default function VCMembershipPage'

Length of output: 63

Script:

#!/bin/bash
# Let's try a different pattern to find the component, including class-based components
ast-grep --pattern 'export $_ class VCMembershipPage'

# Also check for the file itself
fd "VCMembershipPage.tsx"

Length of output: 159

src/domain/community/organizationAdmin/OrganizationAdminTabs.ts (1)

7-33: LGTM! Well-structured tab configuration.

The tab definitions are well-organized with proper typing and consistent structure. The separation into a dedicated configuration file improves maintainability.

src/core/ui/content/LabeledCount.tsx (1)

2-2: LGTM! Import path update aligns with component reorganization.

The updated import path reflects the broader refactoring effort to improve organization of contributor-related components.

✅ Verification successful

Import path change is valid and file exists at the specified location

The verification confirms that the file OrganizationVerifiedStatus.tsx exists at the new import path src/domain/community/contributor/organization/, validating the import statement change.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Verify the new import path exists
fd "OrganizationVerifiedStatus" --type f

Length of output: 117

src/domain/community/organization/routing/OrganizationRoute.tsx (1)

5-5: LGTM! Import path changes align with the refactoring objectives.

The updated import paths reflect the reorganization of admin functionality, moving from platform level to community domain, which aligns with the PR objectives.

Also applies to: 7-7

src/domain/community/organizationAdmin/tabs/OrganizationAdminAccountPage.tsx (1)

Line range hint 21-21: LGTM! Non-null assertion is properly used with skip condition.

The non-null assertion on accountId is acceptable as it's followed by a skip condition that ensures the value exists.

src/domain/community/organization/pages/OrganizationPage.tsx (1)

1-1: LGTM! Import path changes align with the contributor module restructuring

The changes correctly update the import paths to reflect the new module organization. The non-null assertion usage with organizationNameId is appropriate as it's paired with the skip condition.

Also applies to: 7-7

src/domain/community/organization/layout/OrganizationPageLayout.tsx (1)

1-1: LGTM! Import paths are consistently updated

The import path changes maintain consistency with the broader refactoring effort of moving organization-related components to the contributor module.

Also applies to: 6-6

src/domain/platform/admin/components/Organization/CreateOrganizationGroup.tsx (1)

3-4: Verify the consistency of the new import paths

The import path changes align with the refactoring objectives, but let's verify the consistency across the codebase.

✅ Verification successful

Import paths are correctly updated and consistent with the new structure

The verification confirms:

Both components exist at their new locations:
- SettingsSection at src/domain/platform/admin/layout/EntitySettingsLayout/SettingsSection.ts
- OrganizationAdminLayout at src/domain/community/organizationAdmin/layout/OrganizationAdminLayout.tsx
No references to the old import paths remain in the codebase

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the consistency of the new import paths

# Check for any remaining old import paths
rg -l "EntitySettingsLayout/constants" 
rg -l "platform/admin/organization/OrganizationAdminLayout"

# Verify the new import paths exist
fd "SettingsSection.ts" "src/domain/platform/admin/layout/EntitySettingsLayout"
fd "OrganizationAdminLayout.tsx" "src/domain/community/organizationAdmin/layout"

Length of output: 402

src/domain/community/organizationAdmin/OrganizationAdminRoutes.tsx (2)

4-8: Verify the existence of the new admin components

The imports have been updated to use the new admin-specific components. Let's verify that all these components exist.

Also applies to: 14-14

✅ Verification successful

All imported admin components exist in the codebase

All the new admin-specific components referenced in the imports are present in the expected location under src/domain/community/organizationAdmin/tabs/:

OrganizationAdminProfilePage
OrganizationAdminAccountPage
OrganizationAdminCommunityPage
OrganizationAdminAuthorizationPage
OrganizationAdminSettingsPage

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the existence of the new admin components

# Check for the new component files
fd -e tsx "OrganizationAdmin(Profile|Account|Community|Authorization|Settings)Page\.tsx" "src/domain/community/organizationAdmin/tabs"

Length of output: 528

37-37: Review the route structure and navigation flow

The routes have been updated to use the new admin components, and a new settings route has been added. The structure looks good, but let's verify the navigation flow.

Also applies to: 39-39, 41-42

✅ Verification successful

Navigation structure and flow are properly implemented

The route structure in OrganizationAdminRoutes.tsx is well-organized with:

Default route redirecting to "profile"
All necessary admin routes (profile, account, community, authorization, settings) properly defined
Navigation components (HeaderNavigationTabs) support these routes with proper tab structure
Error handling and loading states are implemented correctly

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the navigation flow between routes

# Check for any references to these routes in navigation components
rg -A 3 "to=[\"\']/?profile[\"\']|to=[\"\']/?community[\"\']|to=[\"\']/?authorization[\"\']|to=[\"\']/?settings[\"\']" --type ts --type tsx

Length of output: 329

Script:

#!/bin/bash
# Check for navigation links and route references
rg -A 3 "to=\"/profile\"|to=\"/community\"|to=\"/authorization\"|to=\"/settings\"" --type ts --type tsx

# Check for route definitions
rg -A 3 "path=\"profile\"|path=\"community\"|path=\"authorization\"|path=\"settings\"" --type ts --type tsx

# Look for any navigation components
fd -e tsx -e ts | grep -i "nav"

Length of output: 2400

Script:

#!/bin/bash
# Check navigation components content
cat src/main/ui/platformNavigation/platformNavigationMenu/menuItems.ts
cat src/domain/shared/components/PageHeader/HeaderNavigationTabs.tsx
cat src/domain/journey/dashboardNavigation/DashboardNavigation.tsx

# Check the route file content
cat src/domain/community/organizationAdmin/OrganizationAdminRoutes.tsx

Length of output: 16302

src/domain/platform/admin/layout/EntitySettingsLayout/EntitySettingsLayout.tsx (1)

2-2: Verify the new SettingsSection module structure

The SettingsSection has been moved from constants to its own module, which is a good separation of concerns.

✅ Verification successful

Import change is correctly implemented

The SettingsSection has been properly moved to its own module and is now an enum containing all the settings section identifiers. All imports across the codebase have been updated to reference the new location, and there are no remaining references to the old location in constants.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the SettingsSection module structure

# Check the new SettingsSection file exists and its content
fd "SettingsSection.ts" "src/domain/platform/admin/layout/EntitySettingsLayout"

# Verify no other files are still importing from constants
rg -l "EntitySettingsLayout/constants"

Length of output: 189

Script:

#!/bin/bash
# Let's verify the content and structure more thoroughly

# Check the content of SettingsSection.ts
cat src/domain/platform/admin/layout/EntitySettingsLayout/SettingsSection.ts

# Check if there are any remaining references to SettingsSection in constants
fd "constants.ts" "src/domain/platform/admin/layout/EntitySettingsLayout" --exec cat {}

# Check for any imports of SettingsSection across the codebase
rg "import.*SettingsSection" -A 2

Length of output: 24072

src/domain/community/organizationAdmin/layout/OrganizationAdminLayout.tsx (1)

2-2: LGTM: Import paths refactored for better organization

The refactoring of import paths to use platform-level components improves the architectural organization by:

Centralizing common layout components under the platform namespace
Reducing duplication of layout-related code
Making the component hierarchy more explicit

Also applies to: 4-4, 5-5

src/domain/community/virtualContributorAdmin/layout/VCSettingsPageLayout.tsx (1)

8-8: LGTM: Import paths aligned with platform structure

The import paths have been properly updated to align with the platform-level organization of components.

Also applies to: 10-10, 11-11

src/domain/community/userAdmin/layout/UserAdminLayout.tsx (2)

36-38: LGTM: Clean feature flag handling

The conditional addition of the credentials tab based on the SSI feature flag is well implemented.

27-27: LGTM: Component naming aligned with functionality

The renaming from UserSettingsLayout to UserAdminLayout better reflects the component's purpose and maintains consistency with the admin context.

Also applies to: 32-32, 75-75

src/domain/community/userAdmin/tabs/UserAdminMembershipPage.tsx (2)

Line range hint 71-91: LGTM: Layout structure and component composition

The layout structure using GridProvider and proper spacing looks good. The ContributionsView components are properly configured with their respective props.

Line range hint 22-25: Verify the correctness of user memberships query

The TODO comment indicates potential incorrect logic in fetching memberships. The comment suggests we might be viewing memberships of a different user instead of the current user.

Please verify if this is the intended behavior or if it needs to be updated to use the correct user context.

src/domain/community/userAdmin/tabs/UserAdminProfilePage.tsx (1)

Line range hint 87-100: LGTM: Profile form implementation

The UserForm implementation with proper title, avatar, and edit mode handling looks good. The save handler is properly connected.

src/domain/community/organizationAdmin/views/OrganizationAdminSettingsView.tsx (1)

45-75: LGTM: Settings update implementation

The settings update logic is well-implemented with proper default values and type safety.

src/domain/community/userAdmin/views/UserAdminSettingsView.tsx (1)

64-76: ⚠️ Potential issue

Add error handling for mutation and clean up commented code

The mutation lacks error handling, and there's commented out notification code that should be either implemented or removed.

Apply this change:

 await updateUserSettings({
   variables: {
     settingsData: {
       userID,
       settings: settingsVariable,
     },
   },
+  onError: error => {
+    // Handle error appropriately
+    console.error('Failed to update user settings:', error);
+  }
 });

- // if (showNotification) {
- //   notify(t('pages.admin.space.settings.savedSuccessfully'), 'success');
- // }

Likely invalid or redundant comment.

src/domain/platform/admin/components/Organization/OrganizationForm.tsx (2)

18-18: LGTM! Import path updated correctly.

The import path for OrgVerificationLifecycleEvents has been updated to use the platform admin path, which aligns with the refactoring mentioned in the PR objectives.

75-82: Verify the settings migration impact.

The new settings structure with privacy and membership properties replaces the old preferences. While the implementation looks correct, we should verify the impact of this change.

Let's verify the usage of these settings:

✅ Verification successful

The settings migration appears to be a valid structural change

The verification shows that:

The old preferences references in the codebase are unrelated to organization settings, mostly dealing with user notifications and space settings.
The new settings structure with privacy and membership properties is properly integrated into the GraphQL schema and mutations.
The mutation updateOrganizationSettings is correctly structured to handle the new settings format.

The change is localized to organization settings and doesn't conflict with other parts of the codebase. The implementation is consistent with the GraphQL schema and mutations.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for any remaining references to the old preferences structure
# and verify the new settings structure is used consistently.

echo "Checking for old preferences references..."
rg "preferences" --type ts --type tsx

echo "Checking usage of new settings structure..."
rg "settings\s*:\s*\{[^}]*privacy[^}]*membership" --type ts --type tsx

Length of output: 358

Script:

#!/bin/bash
# Let's try a different approach without file type restrictions
echo "Checking for preferences references..."
rg "preferences"

echo -e "\nChecking for settings structure usage..."
rg -A 5 "settings.*privacy"

Length of output: 33390

Script:

#!/bin/bash
# Let's check for the organization settings structure in GraphQL schema and queries
echo "Checking GraphQL schema for organization settings..."
rg -A 5 "type Organization.*settings" 

echo -e "\nChecking organization-related queries and mutations..."
rg -A 5 "mutation.*Organization.*settings"
rg -A 5 "query.*Organization.*settings"

echo -e "\nChecking for organization settings usage..."
ast-grep --pattern 'settings: {
  privacy: {
    $$$
  },
  membership: {
    $$$
  }
}'

Length of output: 1773

src/core/i18n/en/translation.en.json (2)

1986-1996: LGTM! User settings translations added.

The new user settings translations are well-structured and provide clear messaging for communication and privacy preferences.

2001-2013: LGTM! Organization settings translations added.

The new organization settings translations are well-organized with appropriate sections for authorization, membership, and privacy settings.

src/domain/community/organizationAdmin/graphql/organizationSettingsQueries.graphql

src/domain/community/userAdmin/graphql/userSettingsQueries.graphql

src/domain/community/userAdmin/tabs/UserAdminNotificationsPage.tsx

src/domain/community/organizationAdmin/layout/OrganizationAdminLayout.tsx

src/domain/community/userAdmin/layout/UserAdminLayout.tsx

… types + ID passing for org mutations

… enum

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (4)

src/main/ui/settings/PreferenceSection.tsx (1)

42-42: Consider memoizing the onChange handler for better performance

While the current implementation is functional, consider memoizing the handler using useCallback to prevent unnecessary re-renders, especially if this component is used in a list.
+ const handleChange = useCallback(
+   (id: string) => (event: React.ChangeEvent<HTMLInputElement>, checked: boolean) =>
+     onUpdate(id, event.target.name as PreferenceType, checked),
+   [onUpdate]
+ );

  // In the JSX
- onChange={(event, checked) => onUpdate(id, event.target.name as PreferenceType, checked)}
+ onChange={handleChange(id)}

src/domain/community/organization/views/OrganizationPageView.tsx (3)

Line range hint 42-49: Consider memoizing translation strings.

While the useMemo implementation is correct, consider memoizing the translation strings to prevent unnecessary re-renders when the language doesn't change.

 const { t } = useTranslation();
+const memoizedLabels = useMemo(
+  () => ({
+    keywords: t('components.profile.fields.keywords.title'),
+    capabilities: t('components.profile.fields.capabilities.title')
+  }),
+  [t]
+);

 const tagsets = useMemo(
   () => [
-    { name: t('components.profile.fields.keywords.title'), tags: keywords },
-    { name: t('components.profile.fields.capabilities.title'), tags: capabilities },
+    { name: memoizedLabels.keywords, tags: keywords },
+    { name: memoizedLabels.capabilities, tags: capabilities },
   ],
   [keywords, capabilities, t]
 );

Line range hint 51-67: Enhance type safety and simplify null checks.

While the implementation is functionally correct, we can improve type safety and readability.

+const createOrganizationProfileEntity = (
+  organization: OrganizationContainerEntities['organization'],
+  tagsets: Array<{ name: string; tags: string[] }>,
+  socialLinks: OrganizationContainerEntities['socialLinks'],
+  links: OrganizationContainerEntities['links'],
+  t: (key: string) => string
+): OrganizationProfileViewEntity => ({
+  avatar: organization?.profile.avatar?.uri ?? undefined,
+  displayName: organization?.profile.displayName ?? '',
+  settingsTooltip: t('pages.organization.settings.tooltip'),
+  settingsUrl: buildSettingsUrl(organization?.nameID ?? ''),
+  bio: organization?.profile.description,
+  verified: organization?.verification.status === OrganizationVerificationEnum.VerifiedManualAttestation,
+  tagsets,
+  socialLinks,
+  links,
+  location: organization?.profile.location,
+});

 const entity = useMemo(
-  () =>
-    ({
-      avatar: organization?.profile.avatar?.uri,
-      displayName: organization?.profile.displayName || '',
-      settingsTooltip: t('pages.organization.settings.tooltip'),
-      settingsUrl: buildSettingsUrl(organization?.nameID || ''),
-      bio: organization?.profile.description,
-      verified: organization?.verification.status === OrganizationVerificationEnum.VerifiedManualAttestation,
-      tagsets,
-      socialLinks,
-      links,
-      location: organization?.profile.location,
-    } as OrganizationProfileViewEntity),
+  () => createOrganizationProfileEntity(organization, tagsets, socialLinks, links, t),
   [organization, tagsets, socialLinks, links, t]
 );

Line range hint 89-111: Consider extracting contributions section for better readability.

The nested conditional rendering of contributions could be simplified by extracting it into a separate component or function.

+const ContributionsSection = ({
+  filteredMemberships,
+  remainingMemberships,
+  t,
+}: {
+  filteredMemberships: typeof filteredMemberships;
+  remainingMemberships: typeof remainingMemberships;
+  t: (key: string) => string;
+}) => (
+  <>
+    {filteredMemberships.length > 0 && (
+      <ContributionsView
+        title={t('components.contributions.leadSpacesTitle')}
+        contributions={filteredMemberships}
+      />
+    )}
+    {remainingMemberships.length > 0 ? (
+      <ContributionsView
+        title={t('components.contributions.allMembershipsTitle')}
+        contributions={remainingMemberships}
+      />
+    ) : (
+      <PageContentBlock>
+        <PageContentBlockHeader title={t('components.contributions.allMembershipsTitle')} />
+        <CaptionSmall>{t('pages.user-profile.communities.noMembership')}</CaptionSmall>
+      </PageContentBlock>
+    )}
+  </>
+);

// In the main render
-        {filteredMemberships.length > 0 && (
-          <ContributionsView
-            title={t('components.contributions.leadSpacesTitle')}
-            contributions={filteredMemberships}
-          />
-        )}
-        {remainingMemberships.length > 0 ? (
-          <ContributionsView
-            title={t('components.contributions.allMembershipsTitle')}
-            contributions={remainingMemberships}
-          />
-        ) : (
-          <PageContentBlock>
-            <PageContentBlockHeader title={t('components.contributions.allMembershipsTitle')} />
-            <CaptionSmall>{t('pages.user-profile.communities.noMembership')}</CaptionSmall>
-          </PageContentBlock>
-        )}
+        <ContributionsSection
+          filteredMemberships={filteredMemberships}
+          remainingMemberships={remainingMemberships}
+          t={t}
+        />

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 19f2c3e and 0569961.

⛔ Files ignored due to path filters (2)

src/core/apollo/generated/apollo-hooks.ts is excluded by !**/generated/**
src/core/apollo/generated/graphql-schema.ts is excluded by !**/generated/**

📒 Files selected for processing (5)

src/domain/community/organization/views/OrganizationPageView.tsx (2 hunks)
src/domain/community/user/containers/UserNotificationsContainer.tsx (3 hunks)
src/domain/community/userAdmin/views/UserAdminNotificationsPageView.tsx (6 hunks)
src/domain/community/virtualContributorAdmin/layout/VCSettingsPageLayout.tsx (1 hunks)
src/main/ui/settings/PreferenceSection.tsx (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

src/domain/community/virtualContributorAdmin/layout/VCSettingsPageLayout.tsx
src/domain/community/userAdmin/views/UserAdminNotificationsPageView.tsx

🧰 Additional context used

📓 Path-based instructions (3)

src/domain/community/user/containers/UserNotificationsContainer.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/main/ui/settings/PreferenceSection.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/community/organization/views/OrganizationPageView.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

🔇 Additional comments (6)

src/main/ui/settings/PreferenceSection.tsx (2)

4-4: LGTM! Good use of generated GraphQL types

Using generated GraphQL types ensures type safety and consistency between frontend and backend.

12-12: LGTM! Well-typed callback signature

The callback type signature is clear and type-safe, using appropriate types for each parameter.

src/domain/community/user/containers/UserNotificationsContainer.tsx (3)

9-9: LGTM: Import statement correctly updated

The import of PreferenceType from the generated GraphQL schema is appropriate and consistent with the refactoring objectives.

43-43: LGTM: Function signature properly updated

The updatePreference function signature has been updated to use PreferenceType while maintaining the existing implementation logic. The GraphQL mutation and optimistic response handling remain correct.

20-20: Verify the impact of the PreferenceType change

The type change in the interface is a breaking change that might affect components implementing this interface.

Let's verify all implementations of this interface:

✅ Verification successful

No breaking changes detected in PreferenceType usage

The verification shows that PreferenceType is consistently used across the codebase:

It's imported from @/core/apollo/generated/graphql-schema in all files
The type is used consistently in both the container and its implementations
The interface signature matches the actual implementation in UserAdminNotificationsPageView
The type is part of the generated GraphQL schema, suggesting it's defined by the API

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for components implementing UserNotificationsContainerActions
rg -t typescript -t tsx "UserNotificationsContainerActions" -B 2 -A 2

Length of output: 104

Script:

#!/bin/bash
# Search for components implementing UserNotificationsContainerActions using ripgrep
rg "UserNotificationsContainerActions" -B 2 -A 2

# Also search for components using updatePreference to catch any implementations
rg "updatePreference.*PreferenceType" -B 2 -A 2

Length of output: 6044

Script:

#!/bin/bash
# Let's check what PreferenceType was before this change
git log -p src/domain/community/user/containers/UserNotificationsContainer.tsx | rg -B 5 -A 5 "PreferenceType"

# Also check the definition of PreferenceType
rg "PreferenceType" -B 2 -A 2 --type-add "ts:*.{ts,tsx}" --type ts

Length of output: 9253

src/domain/community/organization/views/OrganizationPageView.tsx (1)

Line range hint 3-28: LGTM! Import changes align with refactoring objectives.

The reorganization of imports and the addition of verification-related imports support the PR's goal of refactoring contributor admin pages.

…settings calls.

…into server-4742

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (8)

src/domain/community/userAdmin/UserAdminTabs.ts (1)
11-47: Consider more semantically appropriate icons for certain sections

The tab structure is well-defined and type-safe. However, some icon choices could be more intuitive:

The Organizations section uses ForumOutlinedIcon which implies discussion/communication rather than organization management

The Account section uses SellOutlinedIcon which implies commerce rather than account management

Consider these alternative Material-UI icons:
  {
    section: SettingsSection.Organizations,
    route: 'organizations',
-   icon: ForumOutlinedIcon,
+   icon: BusinessOutlinedIcon, // or CorporateFareOutlinedIcon
  },
  {
    section: SettingsSection.Account,
    route: 'account',
-   icon: SellOutlinedIcon,
+   icon: AccountCircleOutlinedIcon,
  },
src/domain/community/organizationAdmin/views/OrganizationAdminSettingsView.tsx (3)
23-32: Consider adding TypeScript interface for the component props.

The component setup and hooks usage is well-implemented. For better type safety and documentation, consider adding an empty interface even if there are no props currently:
interface OrganizationAdminSettingsViewProps {}

export const OrganizationAdminSettingsView: React.FC<OrganizationAdminSettingsViewProps> = () => {
34-39: Optimize useMemo implementation.

The useMemo dependency array includes organizationId which isn't used in the computation. Also, the spread operation isn't adding any new properties.
  const currentSettings = useMemo(() => {
-   const settings = data?.organization.settings;
-   return {
-     ...settings,
-   };
+   return data?.organization.settings;
-  }, [data, organizationId]);
+  }, [data]);
73-96: Simplify the render logic.

There are a few opportunities for improvement:

The loading check at line 75 is redundant since there's already a loading check at line 41.

The Fragment is unnecessary as it wraps a single child.
  return (
    <PageContent background="transparent">
-     {!loading && (
-       <>
-         <PageContentBlock>
-           <BlockTitle>{t('pages.admin.organization.settings.title')}</BlockTitle>
-           <SwitchSettingsGroup
-             options={{
-               allowUsersMatchingDomainToJoin: {
-                 checked: currentSettings?.membership?.allowUsersMatchingDomainToJoin || false,
-                 label: (
-                   <Trans
-                     i18nKey="pages.admin.organization.settings.membership.usersMatchingEmail"
-                     components={{ b: <strong /> }}
-                   />
-                 ),
-               },
-             }}
-             onChange={(setting, newValue) => handleUpdateSettings({ [setting]: newValue })}
-           />
-         </PageContentBlock>
-       </>
-     )}
+     <PageContentBlock>
+       <BlockTitle>{t('pages.admin.organization.settings.title')}</BlockTitle>
+       <SwitchSettingsGroup
+         options={{
+           allowUsersMatchingDomainToJoin: {
+             checked: currentSettings?.membership?.allowUsersMatchingDomainToJoin || false,
+             label: (
+               <Trans
+                 i18nKey="pages.admin.organization.settings.membership.usersMatchingEmail"
+                 components={{ b: <strong /> }}
+               />
+             ),
+           },
+         }}
+         onChange={(setting, newValue) => handleUpdateSettings({ [setting]: newValue })}
+       />
+     </PageContentBlock>
    </PageContent>
  );
🧰 Tools

🪛 Biome (1.9.4)

[error] 76-94: Avoid using unnecessary Fragment.

A fragment is redundant if it contains only one child, or if it is the child of a html element, and is not a keyed fragment.
Unsafe fix: Remove the Fragment

(lint/complexity/noUselessFragments)
src/domain/community/userAdmin/views/UserAdminSettingsView.tsx (4)
12-19: Add TypeScript interface for settings structure.

Consider defining a TypeScript interface for the settings object to improve type safety and documentation.
interface UserSettings {
  privacy: {
    contributionRolePubliclyVisible: boolean;
  };
  communication: {
    allowOtherUsersToSendMessages: boolean;
  };
}

const defaultUserSettings: UserSettings = {
  // ... existing implementation
};
35-41: Remove unnecessary useMemo dependency.

The userID is not used within the useMemo callback but is included in the dependency array.
  }, [data, userID]);
+  }, [data]);
47-73: Improve type safety of the update function.

The update function could benefit from better TypeScript types and a more concise implementation.
interface UpdateSettingsParams {
  allowOtherUsersToSendMessages?: boolean;
  contributionRolesPubliclyVisible?: boolean;
}

const handleUpdateSettings = async ({
  allowOtherUsersToSendMessages = currentSettings?.communication?.allowOtherUsersToSendMessages ??
    defaultUserSettings.communication.allowOtherUsersToSendMessages,
  contributionRolesPubliclyVisible = currentSettings?.privacy?.contributionRolesPubliclyVisible ??
    defaultUserSettings.privacy.contributionRolePubliclyVisible,
}: UpdateSettingsParams) => {
77-97: Remove redundant loading check and unnecessary Fragment.

Two improvements can be made to simplify the render logic:

The loading check at line 77 is redundant since it's already handled at line 43.

The Fragment wrapping the PageContentBlock is unnecessary as there's only one child.
  <PageContent background="transparent">
-   {!loading && (
-     <>
-       <PageContentBlock>
-         <BlockTitle>{t('pages.admin.user.settings.title')}</BlockTitle>
-         <SwitchSettingsGroup
-           // ... existing props
-         />
-       </PageContentBlock>
-     </>
-   )}
+   <PageContentBlock>
+     <BlockTitle>{t('pages.admin.user.settings.title')}</BlockTitle>
+     <SwitchSettingsGroup
+       // ... existing props
+     />
+   </PageContentBlock>
  </PageContent>
🧰 Tools

🪛 Biome (1.9.4)

[error] 78-96: Avoid using unnecessary Fragment.

A fragment is redundant if it contains only one child, or if it is the child of a html element, and is not a keyed fragment.
Unsafe fix: Remove the Fragment

(lint/complexity/noUselessFragments)

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f1b711c and e06e393.

📒 Files selected for processing (5)

src/domain/community/organizationAdmin/OrganizationAdminTabs.ts (1 hunks)
src/domain/community/organizationAdmin/views/OrganizationAdminSettingsView.tsx (1 hunks)
src/domain/community/userAdmin/UserAdminTabs.ts (1 hunks)
src/domain/community/userAdmin/views/UserAdminSettingsView.tsx (1 hunks)
src/domain/community/virtualContributorAdmin/VcAdminTabs.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

src/domain/community/organizationAdmin/OrganizationAdminTabs.ts
src/domain/community/virtualContributorAdmin/VcAdminTabs.ts

🧰 Additional context used

📓 Path-based instructions (3)

src/domain/community/userAdmin/views/UserAdminSettingsView.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/community/userAdmin/UserAdminTabs.ts (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

src/domain/community/organizationAdmin/views/OrganizationAdminSettingsView.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
Avoid flagging the absence of local error handling in cases where the global error handler suffices.
Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}

Check for common security vulnerabilities such as:

SQL Injection
XSS (Cross-Site Scripting)
CSRF (Cross-Site Request Forgery)
Insecure dependencies
Sensitive data exposure

🪛 Biome (1.9.4)

src/domain/community/userAdmin/views/UserAdminSettingsView.tsx

[error] 78-96: Avoid using unnecessary Fragment.

A fragment is redundant if it contains only one child, or if it is the child of a html element, and is not a keyed fragment.
Unsafe fix: Remove the Fragment

(lint/complexity/noUselessFragments)

src/domain/community/organizationAdmin/views/OrganizationAdminSettingsView.tsx

[error] 76-94: Avoid using unnecessary Fragment.

A fragment is redundant if it contains only one child, or if it is the child of a html element, and is not a keyed fragment.
Unsafe fix: Remove the Fragment

(lint/complexity/noUselessFragments)

🔇 Additional comments (3)

src/domain/community/userAdmin/UserAdminTabs.ts (1)

1-10: LGTM! Clean and well-organized imports

The imports are properly structured, using absolute paths and importing specific icons as needed.

src/domain/community/organizationAdmin/views/OrganizationAdminSettingsView.tsx (2)

1-21: LGTM! Well-structured imports and default settings.

The imports are organized logically, and the default settings provide appropriate fallback values that match the GraphQL schema structure.

100-100: LGTM! Proper export pattern.

The component follows the common React pattern of providing both named and default exports.

src/domain/community/userAdmin/views/UserAdminSettingsView.tsx

* fix forum discussion styles * update contributors image for unauth users and fix styles (#7354) * update contributors image for unauth users and fix styles * resolve pr comments * Remove location from VC card * remove usage of anonymousReadAccess (#7332) * Fix dashboard access (#7360) * Fix dashboard access * fixed scope * change polling interval * fix pr comment * renamed to useSpaceTemplate*s*ManagerQuery --------- Co-authored-by: Carlos Cano <carlos@alkem.io> * Handling of scroll and page change in documentation. (#7359) * logs for the frame origin * add allow-scripts to the docs iframe * Improve the layout banner of Documentation page; * Subtitle for the Docs page * added new tabs to user + org admin pages; refactored contributor admin pages (#7367) * added new tabs to user + org admin pages; refactored how admin pages for users + orgs + vcs are managed; moved some global admin functionality out of domain down to platform admin; ... * updated generation to match api tidy ups related to set of preference types + ID passing for org mutations * fix compile errors related to dropping of separate UserPreferenceType enum * Synchronize icons, remove comments, make sure there are no redundant settings calls. * Links & Docs to BoK on VC creation (#7365) * VC documents and links BoK - refactor the AddContent * VC documents and links implementation without validation; * resolve rabbit comments --------- Co-authored-by: Petar Kolev <33326233+reactoholic@users.noreply.github.com> Co-authored-by: reactoholic <petar.georgiev.kolev@gmail.com> * Links and Docs - forgotten commit with Validation (#7377) * CalloutsSet entity (#7376) * codegen passing with updated api * fixed api + codegen passes * code compiling * pick up create callout privilege from the CalloutsSet * callouts showing up after creation * retrieving of callouts using only calloutsSet ID * moved code around to have notion of calloutsSet in tree * fix array dep breaking tool creation; small code optimizations; --------- Co-authored-by: bobbykolev <bobbykolev@abv.bg> * split useCallouts into also useCalloutsOnCollaboration (#7378) * Style UserAvatar tooltip (#7384) * Fix: Deleting subspace l2 from its settings throws errors on space dashboard * InnovationFlow States names validation - no commas (#7391) * Add arcadeSoftware to the whitelist of iframes (#7397) * bump client version (#7403) * implement image pasting in md editor (#7387) * codegen compilation * Fix: ENTITY_NOT_FOUND Error is triggered after first login server#4790 (#7396) * Remove `makeStyles` from `AlkemioAvatar` and `CommunityUpdatesView` (#7390) * Clean up alkemio avatar component The goal is to remove `@mui/styles`, but as the component is deprecated, it is replaced with the new avatar component in the user popup and the deprecated component is cleaned up from all unused features. The user popup is inlined in it to simplify more the interface of the component. * update contributors image for unauth user (#7410) * bug fix: verified label overlaps with text (#7415) * removed usage of AuthorizationCredential, replaced with RoleName; removed usage of UserGroups * added label to issue templates (#7425) * Limit the answers length on ApplicationForm (#7419) * Limit the answers length on ApplicationForm * Fix error message --------- Co-authored-by: Petar Kolev <33326233+reactoholic@users.noreply.github.com> * Display account entitlements (#7414) * wip * removed state from some dialogs --------- Co-authored-by: Carlos Cano <carlos@alkem.io> * Fix: ENTITY_NOT_FOUND Error is triggered after first login server#4790 (#7396) * Remove `makeStyles` from `AlkemioAvatar` and `CommunityUpdatesView` (#7390) * Clean up alkemio avatar component The goal is to remove `@mui/styles`, but as the component is deprecated, it is replaced with the new avatar component in the user popup and the deprecated component is cleaned up from all unused features. The user popup is inlined in it to simplify more the interface of the component. * update contributors image for unauth user (#7410) * bug fix: verified label overlaps with text (#7415) * added label to issue templates (#7425) * Limit the answers length on ApplicationForm (#7419) * Limit the answers length on ApplicationForm * Fix error message --------- Co-authored-by: Petar Kolev <33326233+reactoholic@users.noreply.github.com> * Display account entitlements (#7414) * wip * removed state from some dialogs --------- Co-authored-by: Carlos Cano <carlos@alkem.io> * update contributors image for unauth user (#7410) * first pass fixing * second pass * Third pass * 6 errors left * Removing scary words in translation.en.json (#7432) * moved to using UUIDs * Add Updates from leads block to the subspaces page (l1 & l2). (#7417) * Add Updates from leads block to the subspaces page (l1 & l2). * share url --------- Co-authored-by: Carlos Cano <carlos@alkem.io> * Fix Sidebar list of spaces not refreshing after subspace delete (#7418) Co-authored-by: Petar Kolev <33326233+reactoholic@users.noreply.github.com> * fix * [VC] Knowledge base instead of Subspace BoK in Written Knowledge step (#7381) * added new tabs to user + org admin pages; refactored how admin pages for users + orgs + vcs are managed; moved some global admin functionality out of domain down to platform admin; ... * updated generation to match api tidy ups related to set of preference types + ID passing for org mutations * fix compile errors related to dropping of separate UserPreferenceType enum * Synchronize icons, remove comments, make sure there are no redundant settings calls. * Links & Docs to BoK on VC creation (#7365) * VC documents and links BoK - refactor the AddContent * VC documents and links implementation without validation; * resolve rabbit comments --------- Co-authored-by: Petar Kolev <33326233+reactoholic@users.noreply.github.com> Co-authored-by: reactoholic <petar.georgiev.kolev@gmail.com> * Links and Docs - forgotten commit with Validation (#7377) * CalloutsSet entity (#7376) * codegen passing with updated api * fixed api + codegen passes * code compiling * pick up create callout privilege from the CalloutsSet * callouts showing up after creation * retrieving of callouts using only calloutsSet ID * moved code around to have notion of calloutsSet in tree * fix array dep breaking tool creation; small code optimizations; --------- Co-authored-by: bobbykolev <bobbykolev@abv.bg> * VC knowledge base instead of subspace init * Space creation after VC creation, loading, code opt & reorganization * Fix docs uploading, code organization and documentation; * fix uploading of docs in case there's no space under the acc; remove misleading createdSpaceId usage; * useLoadingState instead of a new React State * Fix - set properly the persona type depending on the 3 steps; * Ability to select SpaceLevel2 on create VC (#7386) * VC Knowledge Base callouts dialog (#7388) * VC Knowledge Base callouts dialog - init. * Filter available callout types. * disable rich media on VC callout creation. * Description component with update functionality. * Update the Create Written Knowledge UI and initial state; Fix dialog titles in VC flow. * Reingest logic in the Knowledge dialog. * Remove the icon logic for CalloutVisibilityChangeDialog. * Use the account hostname for space created in the VC flow. * fix VC dialog not opening; remove outdated copy; * storage config for KnowledgeBase description --------- Co-authored-by: Neil Smyth <neil@thesmyths.eu> Co-authored-by: Petar Kolev <33326233+reactoholic@users.noreply.github.com> Co-authored-by: reactoholic <petar.georgiev.kolev@gmail.com> Co-authored-by: Neil Smyth <30729240+techsmyth@users.noreply.github.com> Co-authored-by: Carlos Cano <carlos@alkem.io> * add cspell config (#7404) * resolveIds returns string and not the entity * proper check for available account for the vc flow (#7433) * VirtualContributor fixes * name ids * updated for renamed mutation * Client web/7416 disable image pasting when hide image options flag is true (#7428) * fix organization verified sign font size by simone's ask * disable image pasting if hideImageOptions flag is true * optimize paste handler * resolve pr comment * Extract the isImageOrHtmlWithImage and call it once per item. --------- Co-authored-by: Bobby Kolev <bobbykolev@abv.bg> * Fix can't add callout to VC KnowledgeBase. (#7437) Co-authored-by: Valentin Yanakiev <valentin.yanakiev@gmail.com> * url resolver * url builders * Create space link entitlements (#7442) * check for entitlements in the CreateSpaceLink (cherry picked from commit aed1830) * 0.79.7 (cherry picked from commit 7ec232c) * updated to work with fields for entryRole + elevatedRole availability * MD fixes - comments not visible with long Post description; `pre` long line not visible; (#7435) * move fragment * missing padding for the items on the left block on space and subspaces (#7448) * Optimize the Contributor Account Tab and VC flow (#7444) * Optimize subspace query under acc. Fix first VC/Space flow resulting in errors. * Fix add to community and navigation related to spaceId * polishing * fix navigation of subspaces * Optimize the main vcWizard account call. * pr fix --------- Co-authored-by: Carlos Cano <carlos@alkem.io> * Admin Roles management * Available users search. Organizations auth using rolesetAdmin * Organization roles management * fix style * clean up. first 0 errors * removed usage of platform role set id on mutations for roles on platform as not needed (only one) * check for the correct privilege for Callout creation * Add checkbox for adding tutorials when creating new space and fix UI issue in Mozilla regarding the URL input (#7447) * updated for adjusted privilege names * [VC Flow] Choose community step (#7457) * choose community step in vc flow * fix data reload on home dash; * refetch the BoK after VC callouts creation * Append visuals to create profile input (#7301) * profileData renamed to profile on CreateWhiteboardInput * Removed visualUrl from post, which doens't make sense on creation * graphical tweak and little rename * Fix #7316 Create template permission (#7319) * Filter file extensions robustly (#7326) * Fix creating a subspace on a Space by nameId (#7328) * Fix creating a subspace on a Space by nameId * remove unused var * Fix Tutorials Iframes (#7323) * Fix tutorials iframes * parse the iframe with the DOMParser instead of with regex --------- Co-authored-by: Valentin Yanakiev <valentin.yanakiev@gmail.com> * Add Callouts preview accordion on SubspacesList default subspace template selector (#7325) * Add Callouts preview accordion on SubspacesList default subspace template selector * usememo * memoize the Description component --------- Co-authored-by: Valentin Yanakiev <valentin.yanakiev@gmail.com> * codegen --------- Co-authored-by: Valentin Yanakiev <valentin.yanakiev@gmail.com> * restrict activities block to 10 results and add activities dialog (#7463) * Handle missing privileges for add VC to community. (#7470) * Fix the save as template option missing due to missing array deps (#7476) * Remove nameIds from VC dialogs * Entitlements view based on permissions and limits (#7467) * Fix #7451 * Common component to handle the --------- Co-authored-by: Svetoslav Petkov <svetoslav@alkem.io> * display usage-limit of spaces in the account page (#7468) * display usage-limit of spaces in the account page * making safer check --------- Co-authored-by: Svetoslav Petkov <svetoslav@alkem.io> * removed another url builder * Remove SpaceRoleSetContributorTypes query and a few unused queries more * Fix innovationHubs * Fix add checkbox for tutorials UI bug (#7466) * fix add checkbox for tutorials ui * restore graphql files --------- Co-authored-by: Bobby Kolev <bobbykolev@abv.bg> * Fix first-child + useEffect dynamic deps array length console errors; (#7477) Co-authored-by: Petar Kolev <33326233+reactoholic@users.noreply.github.com> * Bug fix: search bar in spaces page not working, and page refreshes on search term enter (#7462) * search spaces page not working * visualize subspaces as well * resolve pr comment * resolve pr comment * fix missing callouts in create template preview (#7482) Co-authored-by: Petar Kolev <33326233+reactoholic@users.noreply.github.com> * Fix organization provider * clean * Rename files * Removed variables from notification query (#7481) * First pass removing useCommunityAdmin * rename forlder * wip * VC Flow - proper filtering of Existing Spaces (#7490) * apply multiple filters on space activities (#7489) Co-authored-by: Bobby Kolev <bobbykolev@abv.bg> * Available users/orgs/vcs hook * support knowledge-base route on VC profile (#7480) * fix nameId issue on VC profile * fix userNameId issues on UserProfile * a bit of cleanup. 0 errors again * fix paste issue (#7493) * removing fragment CommunityRoleSetDetails * clean up * Moved files * Remove groups * VC Flow - proper filtering of Existing Spaces (#7490) * apply multiple filters on space activities (#7489) Co-authored-by: Bobby Kolev <bobbykolev@abv.bg> * support knowledge-base route on VC profile (#7480) * fix paste issue (#7493) * VC Flow - proper filtering of Existing Spaces (#7490) * UserPage clean nameId * Removed some unused code * ApplicationDialog * invitations in RolesetAdmin * Delete more group things * updatePreference mutation * remove useInviteUsers * fix md editor typing issue (#7501) * small refactor * no space creation when org has no spaces and vc is created * refetch * Account storage config for the account resources (#7486) * use account storage config for entities under the account (instead userStorage) * refactor a bit --------- Co-authored-by: Carlos Cano <carlos@alkem.io> * disable new posts on knowledgebase callouts (#7507) * knowledgebase-disable-new-posts (#7509) * No default callouts on space creation w tutorials (#7518) * update graphql schema * Add VC Callouts route (#7515) * Url for posts that are inside VC knowledge-base * fix url resolver * 0.80.0 (#7526) * reingest after creation of a VC with Space BoK (#7536) * 0.80.1 * BugFix anonymous user access to public space (#7541) * crowdin config (#7549) * Fix search in space (#7552) * Fix search in space * Also use the lookup for space details * Translations (#7553) * 0.80.2 * disabled Crowdin action --------- Co-authored-by: reactoholic <petar.georgiev.kolev@gmail.com> Co-authored-by: Petar Kolev <33326233+reactoholic@users.noreply.github.com> Co-authored-by: Carlos Cano <carlos@alkem.io> Co-authored-by: Neil Smyth <30729240+techsmyth@users.noreply.github.com> Co-authored-by: Valentin Yanakiev <valentin.yanakiev@gmail.com> Co-authored-by: Neil Smyth <neil@thesmyths.eu> Co-authored-by: Todorka Halacheva <56818790+thalacheva@users.noreply.github.com> Co-authored-by: Svetoslav Petkov <svetoslav@alkem.io> Co-authored-by: Simone <38861315+SimoneZaza@users.noreply.github.com> Co-authored-by: Evgeni Dimitrov <comoque@gmail.com>

added new tabs to user + org admin pages; refactored how admin pages …

19f2c3e

…for users + orgs + vcs are managed; moved some global admin functionality out of domain down to platform admin; ...

techsmyth requested a review from bobbykolev December 21, 2024 13:48

coderabbitai bot reviewed Dec 21, 2024

View reviewed changes

techsmyth added 2 commits December 22, 2024 07:58

updated generation to match api tidy ups related to set of preference…

108a4e0

… types + ID passing for org mutations

fix compile errors related to dropping of separate UserPreferenceType…

0569961

… enum

coderabbitai bot reviewed Dec 22, 2024

View reviewed changes

bobbykolev added 3 commits December 23, 2024 17:04

Merge branch 'develop' into server-4742

f1b711c

Synchronize icons, remove comments, make sure there are no redundant …

c9dfdc7

…settings calls.

Merge branch 'server-4742' of https://github.com/alkem-io/client-web …

e06e393

…into server-4742

bobbykolev approved these changes Dec 23, 2024

View reviewed changes

coderabbitai bot reviewed Dec 23, 2024

View reviewed changes

src/domain/community/userAdmin/views/UserAdminSettingsView.tsx Show resolved Hide resolved

bobbykolev merged commit 60ab013 into develop Dec 23, 2024
3 checks passed

bobbykolev deleted the server-4742 branch December 23, 2024 15:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added new tabs to user + org admin pages; refactored contributor admin pages #7367

added new tabs to user + org admin pages; refactored contributor admin pages #7367

techsmyth commented Dec 21, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 21, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

added new tabs to user + org admin pages; refactored contributor admin pages #7367

added new tabs to user + org admin pages; refactored contributor admin pages #7367

Conversation

techsmyth commented Dec 21, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Dec 21, 2024 • edited Loading

Walkthrough

Changes

Sequence Diagram

Possibly related PRs

Suggested Labels

Suggested Reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

techsmyth commented Dec 21, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 21, 2024 •

edited

Loading