Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Lilygo TTGO T8 ESP32-S2 #4077

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

netroy
Copy link

@netroy netroy commented Jan 27, 2021

fixes #3414

example code

continued from #3943

VIDs requested from Espressif

@ladyada
Copy link
Member

ladyada commented Jan 27, 2021

awesome

@tannewt
Copy link
Member

tannewt commented Jan 27, 2021

Is this for the version with a display or without? For the display it'd be great to init the display in board_init like the pygamer does.

@netroy
Copy link
Author

netroy commented Jan 28, 2021

@tannewt I've only tested this with the one with the display.
You can get a build from the CI artifacts, and try out the example I linked in the description.

@tannewt
Copy link
Member

tannewt commented Jan 28, 2021

@netroy Ok, that's fine! Let's add _display to the end of the board ID to make that clear. It'd be nice to include the display init in board_init too. Want to give that a try? I think the pygamer_advanced has ST7789 init code in it.

@netroy
Copy link
Author

netroy commented Jan 28, 2021

@tannewt sure. but, lilygo_ttgo_t8_esp32s2_display sounds a bit mouthful. should I shorten the board name to lilygo_t8_display instead?

@tannewt
Copy link
Member

tannewt commented Jan 28, 2021

@netroy sure! fine with me

@m4tk
Copy link

m4tk commented Jan 28, 2021

@netroy there is another T8 board (with and without display) from LilyGo, but with ESP32 instead of ESP32S2...so I would keep ESP32S2 in the name of the board...

@skieast
Copy link

skieast commented Jan 28, 2021

In my ports I had named them
lilygo_ttgo_t8_s2_st7789 (obv with display)
lilygo_ttgo_t8_s2 (without)

I was about to finish up my tinyuf2 changes for both boards but will wait a bit to see what the consensus is.

@netroy netroy force-pushed the lilygo-ttgo-t8-esp32-s2 branch from 4565913 to 3c2ef46 Compare January 28, 2021 22:32
@netroy
Copy link
Author

netroy commented Jan 28, 2021

@tannewt updated and rebased. unfortunately I could not get the display_init code to work. I do have the code working in python. but, my C skills are just garbage.

@skieast I'll wait for your tinyuf2 PR. I suppose you already saw the PID for that.

@netroy netroy force-pushed the lilygo-ttgo-t8-esp32-s2 branch from 3c2ef46 to c313a93 Compare January 28, 2021 22:39
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the board name update! Just a couple other things.

tools/ci_check_duplicate_usb_vid_pid.py Outdated Show resolved Hide resolved
@tannewt
Copy link
Member

tannewt commented Jan 29, 2021

@tannewt updated and rebased. unfortunately I could not get the display_init code to work. I do have the code working in python. but, my C skills are just garbage.

Want to try and get it going or do it later? I can help point out differences if you push the C version and link to the Python version.

@netroy netroy force-pushed the lilygo-ttgo-t8-esp32-s2 branch from c313a93 to 6dba7a1 Compare January 31, 2021 13:36
@netroy
Copy link
Author

netroy commented Jan 31, 2021

@tannewt updated and rebased. unfortunately I could not get the display_init code to work. I do have the code working in python. but, my C skills are just garbage.

Want to try and get it going or do it later? I can help point out differences if you push the C version and link to the Python version.

I'd like to try this, but in another PR, if that's okay.

@tannewt
Copy link
Member

tannewt commented Feb 1, 2021

Yup, no problem! Thank you!

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tannewt tannewt merged commit 529114c into adafruit:main Feb 1, 2021
@skieast
Copy link

skieast commented Feb 3, 2021

@tannewt updated and rebased. unfortunately I could not get the display_init code to work. I do have the code working in python. but, my C skills are just garbage.

@skieast I'll wait for your tinyuf2 PR. I suppose you already saw the PID for that.

I've created a PR for the tinyuf2 support.
adafruit/tinyuf2#67

Merged. :)

@netroy netroy deleted the lilygo-ttgo-t8-esp32-s2 branch February 3, 2021 07:53
@m4tk
Copy link

m4tk commented Feb 4, 2021

@netroy I've created a PR for the display init code. #4124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lilygo T8 ESP32s2 with 4MB Flash, 8MB RAM
5 participants