Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add display init code for Lilygo TTGO T8 ESP32-S2 #4124

Merged
merged 2 commits into from
Feb 9, 2021
Merged

Add display init code for Lilygo TTGO T8 ESP32-S2 #4124

merged 2 commits into from
Feb 9, 2021

Conversation

m4tk
Copy link

@m4tk m4tk commented Feb 4, 2021

No description provided.

@netroy
Copy link

netroy commented Feb 4, 2021

i'll test and leave my comments later. thanks for doing this :)

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! Will approve and merge after @netroy tests. Thanks!

ports/esp32s2/boards/lilygo_ttgo_t8_s2_st7789/pins.c Outdated Show resolved Hide resolved
@skieast
Copy link

skieast commented Feb 5, 2021

I don't believe IO4 is connected to MISO on the board. When I was working on the UF2 bootloader I attempted to query the ST7789 using this and couldn't get it to work. It also is not shown on the schematic on LilyGo Github.
https://github.com/Xinyuan-LilyGO/LilyGo-T-Display-S2/blob/master/schematic/ESP32_S2-Display.pdf

@m4tk
Copy link
Author

m4tk commented Feb 5, 2021

@skieast thanks for pointing this out. I had just taken this over from the Lilygo example app :-) Ok, I removed MISO from the code.

@netroy
Copy link

netroy commented Feb 5, 2021

I was able to replace my FourWire/ST7789 initialization code with simply board.DISPLAY, and everything worked as expected. ❤️

@m4tk
Copy link
Author

m4tk commented Feb 5, 2021

@netroy thanks for testing this :-)

@netroy
Copy link

netroy commented Feb 5, 2021

Not sure if this is the ticket to discuss this, but I installed the latest tinyuf2, to test out @skieast's PR.
While both these PRs work as expected individually, once I have both installed on the board, I'm seeing some ghosting when using displayio (the slightly dark text at the top and the bottom of the screen).

photo_2021-02-05_15-04-57

is there some kinda of display-reset that I need to do, to flush out the previous graphics completely?
or is that something that needs to happen in this code?

@skieast
Copy link

skieast commented Feb 5, 2021

Not sure if this is the ticket to discuss this, but I installed the latest tinyuf2, to test out @skieast's PR.
While both these PRs work as expected individually, once I have both installed on the board, I'm seeing some ghosting when using displayio (the slightly dark text at the top and the bottom of the screen).

photo_2021-02-05_15-04-57

is there some kinda of display-reset that I need to do, to flush out the previous graphics completely?
or is that something that needs to happen in this code?

I'm out most of today but I'm guessing we should probably coordinate the init code in both apps (TinyUF2 and CPY) It's interesting though. I had tried some test code but didn't notice this. Thanks,

@m4tk
Copy link
Author

m4tk commented Feb 5, 2021

hmm strange, I also have the tinyuf2 installed…but didn’t experienced such ghosting effects yet…

@m4tk
Copy link
Author

m4tk commented Feb 5, 2021

@netroy can you provide your test script please? Then I will check if this ghosting is also visible on my board.

@netroy
Copy link

netroy commented Feb 5, 2021

@m4tk the more I try to reproduce this, the weaker the ghosting gets. it's at a point where I can't see it anymore.
I'll ping you back, if I manage to consistently reproduce it.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One pin suggestion.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit 6efd87b into adafruit:main Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants