-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add display init code for Lilygo TTGO T8 ESP32-S2 #4124
Conversation
i'll test and leave my comments later. thanks for doing this :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good! Will approve and merge after @netroy tests. Thanks!
I don't believe IO4 is connected to MISO on the board. When I was working on the UF2 bootloader I attempted to query the ST7789 using this and couldn't get it to work. It also is not shown on the schematic on LilyGo Github. |
@skieast thanks for pointing this out. I had just taken this over from the Lilygo example app :-) Ok, I removed MISO from the code. |
I was able to replace my |
@netroy thanks for testing this :-) |
Not sure if this is the ticket to discuss this, but I installed the latest is there some kinda of display-reset that I need to do, to flush out the previous graphics completely? |
I'm out most of today but I'm guessing we should probably coordinate the init code in both apps (TinyUF2 and CPY) It's interesting though. I had tried some test code but didn't notice this. Thanks, |
hmm strange, I also have the tinyuf2 installed…but didn’t experienced such ghosting effects yet… |
@netroy can you provide your test script please? Then I will check if this ghosting is also visible on my board. |
@m4tk the more I try to reproduce this, the weaker the ghosting gets. it's at a point where I can't see it anymore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One pin suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
No description provided.