Lilygo TTGo T8 S2 St7789 board #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hathach
requested changes
Feb 3, 2021
There was a problem hiding this comment.
looks good, there are only a few minor changes request per review. Also please update the readme to add your board to the doc as well https://github.com/adafruit/tinyuf2/blob/master/ports/esp32s2/README.md
Don't worry about the CI build failed, it seems to be caused by another issue,
Comment on lines
55
to
57
| // #define DISPLAY_MADCTL (0x36) //Display Memory Access Control ST7789 | ||
| // #define DISPLAY_MADCTL (TFT_MADCTL_MX) //Display Memory Access Control ST7789 | ||
| #define DISPLAY_ROTATION 1 |
There was a problem hiding this comment.
please remove these comment lines and the rotation as well since it is not used by the code. DISPLAY_MADCTL should be configured appropriately for rotation.
Comment on lines
51
to
54
| #define DISPLAY_BL_STATE 1 // GPIO state to enable back light | ||
| #define DISPLAY_WIDTH 240 | ||
| #define DISPLAY_HEIGHT 135 | ||
| #define DISPLAY_MADCTL (TFT_MADCTL_MX | TFT_MADCTL_RGB) |
| #define USB_PRODUCT "TTGO_T8_S2_Display" | ||
|
|
||
| #define UF2_PRODUCT_NAME USB_MANUFACTURER " " USB_PRODUCT | ||
| #define UF2_BOARD_ID "LilyGO-TTGO-T8-S2-DISPLAY" |
There was a problem hiding this comment.
board id must follow uf2 format https://github.com/microsoft/uf2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for the Lilygo TTGO T8 ESP32S2 ST7789 board.
I am using the PID assigned by Espressif for this use (tinyuf2)