Add support for Lilygo TTGO T8 ESP32-S2 #3943
Conversation
| @@ -0,0 +1,18 @@ | |||
| USB_VID = 0x239A | |||
| USB_PID = 0x80AC | |||
There was a problem hiding this comment.
please ask lilygo for a VID/PID instead of using unexpected makers'
There was a problem hiding this comment.
0x239A seems to be Adafruits's vendor ID.
I used it because many other boards are already using the same vendor ID, despite not being an Adafruit product.
Not sure how they picked their PIDs, as none of them seem registered.
Should I change just the PID to be something unique in the context of this VID? like 0x80AD
I can try asking the folks at LilyGo.
There was a problem hiding this comment.
Please don't use my FeatherS2 PID, thanks! Making up your own is also no ok. They are Adafruit's PIDs and you don't know who has been assigned which PID from Adafruit.
LilyGO has already been asked to provide VID/PIDs for their boards for CP. If they chose not to, that is up to them.
There was a problem hiding this comment.
I used it because many other boards are already using the same vendor ID, despite not being an Adafruit product.
Not sure how they picked their PIDs, as none of them seem registered.
Should I change just the PID to be something unique in the context of this VID? like 0x80AD
We've allocated Adafruit PIDs for non-Adafruit devices when we're the ones adding support or at the request of a maker in our community.
We not doing this as much now because of the popularity of the S2. Companies should acquire their own VID. Open source hardware makers and open source software folks can get a PID from https://pid.codes (which I help administer.)
So, you should bug LilyGo but you can also request a pid.codes PID because you are unaffiliated with LilyGo.
|
@netroy if you have purchased from lilygo, please email them, they have tech support teams, they will reply to customer emails. |
|
I heard back from them, and this is all they said:
Considering that this board itself isn't open-source, I'd prefer not to ask for a PID from https://pid.codes or adafruit. I'll close this issue for now. If they ever inform me of a valid PID for this board, I'll rebase this branch, and open a new pull-request. Cheers |
|
ok please keep asking them, they are required to have one |
The new ADC methods are: init(), read_uv() and block(). The new ADCBlock class has methods: init() and connect(). See related discussions in adafruit#3943, adafruit#4213. Signed-off-by: Damien George <damien@micropython.org>
fixes #3414
example code