Requesting PIDs for LILYGO TTGO T8 ESP32-S2 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. One small thing: please add to the 0x8006 PID that this PID is intended for the board when running CircuitPython. (Otherwise people may think that they can use the PID if they develop any random USB application for this board.) |
|
Excellent; merged. |
|
Thank you @Spritetm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This board by LILYGO seems like a great option for someone to start tinkering with ESP32-S2.
But, unfortunately the board manufacturer does not have a USB VID.
I have added support for CircuitPython for this board, but to be able to get that merged, I need two unique and valid PIDs for this board. One for CircuitPython itself, and another for the UF2 bootloader (for when it boots up in mass-storage mode).
Also, Thanks a lot for offering these PIDs, they are an invaluable resource for open-source software.
Cheers