This repository has been archived by the owner on Oct 23, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Agenda Notes Monday September 18th 2017 11:00 AM
Michael Duda edited this page Sep 18, 2017
·
10 revisions
Date: 18 September 2017
Time: 11:00 MDT / 19:00 CET
Call-in number: 1-866-740-1260
Access Code: 4978161
- If it doesn't already exist, should we create a page describing "best practices" for creating PRs?
- How to write a good PR description / merge message
- When to include test cases, example code, or additional details
- Guidelines for commit history (e.g., should cleanup commits be squashed into the commit they fix, how to handle dependent PRs, etc.)
- Any other points that would make it easier for reviewers?
- This wiki page contains some core points that could be expanded
- Are any cores making use of
file_idandparent_idglobal attributes?- Background: With MPAS-Atmosphere, there are several workflows and toolchains that could benefit from robust provenance of mesh information, and there is a vague sentiment that the current
file_idandparent_idapproach may not be robust enough - Related issue: Having
file_idgenerated at random can cause headaches, since two otherwise identical netCDF files cannot be simply compared withcmp file1.nc file2.ncbecause thefile_idattribute in no way depends on the contents of the file
- Background: With MPAS-Atmosphere, there are several workflows and toolchains that could benefit from robust provenance of mesh information, and there is a vague sentiment that the current
- Framework modifications:
Monday, 11 September 2017 @ 11:00 MDT
Participants: Adrian, Dom, Matt, Mark, Michael
Creating a Developers' Guide wiki page sounds generally useful
- For coding style, first list mandatory items along with justification (e.g., not following a guideline is known to not work with a certain compiler)
- Better to over-specify style knowing that some guidelines will not be followed than to not specify at all
- Having this page would be helpful to point new developers to
- Having
file_iddiffer for otherwise identical files can be an annoyance - Using custom tools or scripts can tell whether the contents of files are identical
- But, being able to use standard UNIX tools (like
cmp) seems nice
- But, being able to use standard UNIX tools (like
- No cores are completely tied to the current implementation of
file_idandparent_id, so there is room to modify these if specific deficiencies can be identified
- Generally: in framework code, attention to threading constructs is becoming a concern now that several MPAS cores are making (or attempting to make) serious use of OpenMP