chore: cherry-pick changes from main #8258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Related Issue:** #6374 Updates component usage examples for the label and list components --------- Co-authored-by: JC Franco <jfranco@esri.com> Co-authored-by: Matt Driscoll <mdriscoll@esri.com> Co-authored-by: Ben Elan <no-reply@benelan.dev> Co-authored-by: jcfranco <jcfranco@users.noreply.github.com> Co-authored-by: Adam Tirella <adam@tirel.la>
**Related Issue:** N/A ## Summary The design-tokens package no longer has package-level dependencies, so we can drop the lock file.
Old URL is leading to a 404 page. I found the new URL for the same page.
**Related Issue:** #3834 ## Summary cc @asangma @SkyeSeitz @ashetland
**Related Issue:** #7860 ## Summary Adds the angular package to our issue templates for: a11y, bugs, enhancements, and refactors.
**Related Issue:** #7188 ## Summary Prevents increasing/decreasing the value in `calcite-input-number` on `blur` via keyboard or mouse
**Related Issue:** N/A Rolls back responsiveness (#7755) in favor of upcoming alert stack UX (#2835). See #7921 (comment) for more info.
**Related Issue:** N/A ## Summary @jcfranco I'm running into an issue where once I drag a list-item that has children, the caret icon disappears.   I can't reproduce it with just calcite. Do you think this might fix it?
This PR was automatically generated by the update-browserslist-db GitHub action Co-authored-by: jcfranco <jcfranco@users.noreply.github.com>
…splay prop (#7912) **Related Issue:** #4326 ## Summary This PR introduces a new `selection-display` property to Combobox to control the chip display with the available values `all`(default), `fit` and `single`. This new property only takes effect when `selection-mode` is `multiple` or `ancestors`. --------- Co-authored-by: Erik Harper <eriklharper@pm.me>
**Related Issue:** #6694 Enables responsive layout for stepper component. - stepper element `host` display is changed to `flex` from `grid` - grid column width will use `minmax( )` instead of fixed fractional units. - When none of the stepper item's are selected and the first one is disabled, the first available enabled stepper will be selected.
**Related Issue:** #7912 ## Summary Fixes linting errors introduced by the PR linked above.
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/eslint-plugin-calcite-components: 0.2.3</summary> [0.2.3](https://github.com/Esri/calcite-design-system/compare/@esri/eslint-plugin-calcite-components@0.2.2...@esri/eslint-plugin-calcite-components@0.2.3) (2023-11-21) </details> <details><summary>@esri/calcite-components: 1.11.0</summary> [1.11.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@1.10.0...@esri/calcite-components@1.11.0) (2023-11-21) * **combobox:** Limit display of selected items with new selection-display prop ([#7912](#7912)) ([58317ae](58317ae)) * **date-picker:** Make component responsive ([#7872](#7872)) ([f131218](f131218)) * **input, input-date-picker, input-number, input-text, input-time-picker:** Truncate value and placeholder when input is narrow ([#8160](#8160)) ([533eff3](533eff3)) * **list-item:** Add content-bottom slot for placing content below the label and description of the component ([#8183](#8183)) ([7d400fb](7d400fb)) * **list:** Specify the element types in the `calciteListOrderChange` event detail. ([#8123](#8123)) ([3e81d7e](3e81d7e)) * **pagination:** Introduce responsive design for xxsmall breakpoint ([#8150](#8150)) ([ab20eb0](ab20eb0)) * **stepper-item:** Remove support for previousStep and nextStep in messages ([#8222](#8222)) ([213b31d](213b31d)) * **stepper:** Enable responsive layout ([#7744](#7744)) ([687ca2b](687ca2b)) * **accordion-item:** Update expanded chevron color ([#8087](#8087)) ([d3d7688](d3d7688)) * **action:** Ensure action content is correctly spaced ([#8184](#8184)) ([b18dcc8](b18dcc8)) * **action:** Update transparent action styles ([#8194](#8194)) ([0f12489](0f12489)) * **block-section:** Wraps long text over to a new line when toggle switch is displayed ([#8101](#8101)) ([3f90780](3f90780)) * **checkbox:** Make label property public ([#8181](#8181)) ([d3b9c1f](d3b9c1f)) * **combobox-item:** Hide disabled item icon ([#8095](#8095)) ([36552f3](36552f3)) * **input-date-picker:** Fix date-picker wrapper displaying beyond its bounds ([#8172](#8172)) ([01ec024](01ec024)) * **input-number:** Prevents mutating value on blur ([#8226](#8226)) ([b89a893](b89a893)) * **input-time-zone:** Fix Indian/Christmas time zone translation ([#8096](#8096)) ([d79d591](d79d591)) * **list-item, stack:** Stretch action-menu and handle when placed inside a list-item or stack. ([#8185](#8185)) ([8a16a69](8a16a69)) * **list-item, stack:** Stretch dropdown when placed inside a list-item or stack ([#8204](#8204)) ([05e6b65](05e6b65)) * **list-item:** Adds border between grouped and ungrouped list-items ([#8134](#8134)) ([b3c331c](b3c331c)) * **list-item:** Fix rendering of open icon. ([#8207](#8207)) ([a6e1766](a6e1766)) * **panel, flow-item:** Remove overflow rule ([#8055](#8055)) ([d0c3ed2](d0c3ed2)) * **split-button:** Fix width layout ([#8133](#8133)) ([051f332](051f332)) * The following workspace dependencies were updated * devDependencies * @esri/eslint-plugin-calcite-components bumped from 0.2.3-next.6 to 0.2.3 </details> <details><summary>@esri/calcite-components-angular: 1.11.0</summary> * **angular:** Publish from the dist directory ([#8151](#8151)) ([d813f14](d813f14)) * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 1.11.0-next.3 to 1.11.0 </details> <details><summary>@esri/calcite-components-react: 1.11.0</summary> [1.11.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@1.10.0...@esri/calcite-components-react@1.11.0) (2023-11-21) * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 1.11.0-next.3 to 1.11.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Ben Elan <no-reply@benelan.dev>
**Related Issue:** #8214 #7979 ## Summary - Update some component `open` handlers to call reposition before open and after open - Previously, they were just calling when open was set to true. - Update `floating-ui` utility - Handle device pixel ratio: https://floating-ui.com/docs/misc#subpixel-and-accelerated-positioning - Only set `top`, `left`, and `transform` when the component is open. - This makes it so that the positioned container is never going to "fly in" from anywhere. - Update sortable styles to hide any overflow on dragged elements.
**Related Issue:** #8242 ## Summary - Specifies padding on a list that has no list items inside it - This allows for easier dragging into the empty list. - This could be a quick fix for the issue and design could come up with something better. - add story
…ents on the window instead of the document (#8247)
**Related Issue:** n/a ## Summary Adds a debugger script for calcite-design-tokens in VSCode (launch.json) Adds snapshot tests to enforce token output
|
Thanks @benelan for putting this together and testing on your side. Code LGTM and checks look good! @geospatialem @Elijbet @alisonailea @DitwanP @driskull @macandcheese @anveshmekala @eriklharper @Elijbet can you take a quick glance at your changes to make sure everything looks ✅? @alisonailea Could you take a look at updating and restoring the token spec tests (they were skipped in this PR)? Thanks! 🙇♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #8254
Summary
Seeing if GitHub will let me "rebase merge" when cherry-picking the commits. For future reference, I did: