Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sync rc with main #8254

Closed
wants to merge 36 commits into from
Closed

chore: sync rc with main #8254

wants to merge 36 commits into from

Conversation

benelan
Copy link
Member

@benelan benelan commented Nov 23, 2023

Sync recent changes to main into rc.

DitwanP and others added 30 commits November 16, 2023 15:26
**Related Issue:** #6374 

## Summary

Updates component usage examples for the label and list components

---------

Co-authored-by: JC Franco <jfranco@esri.com>
Co-authored-by: Matt Driscoll <mdriscoll@esri.com>
Co-authored-by: Ben Elan <no-reply@benelan.dev>
Co-authored-by: jcfranco <jcfranco@users.noreply.github.com>
Co-authored-by: Adam Tirella <adam@tirel.la>
…e label and description of the component (#8183)

**Related Issue:** #8173

## Summary

- Adds a new slot `content-bottom`. 
- `content-bottom` is indented the same as the item.
- screenshot tests
**Related Issue:** N/A

## Summary

The design-tokens package no longer has package-level dependencies, so
we can drop the lock file.
…m or stack (#8204)

**Related Issue:** #8185

## Summary

- stretch dropdown component in list-item and stack
…8134)

**Related Issue:** #7546 

## Summary

Adds border to the `calcite-list-item` excluding the first
`calcite-list-item` in the `calcite-list-item-group` or the
`calcite-list`.
)

**Related Issue:** #8028 

## Summary
Adds screenshots for panel and flow-item.
Follow-up from #8055

cc @driskull
Old URL is leading to a 404 page.
I found the new URL for the same page.
…messages (#8222)

**Related Issue:** #8223 

## Summary
BREAKING CHANGE: Removed `previousStep` and `nextStep` in messages. They
are not available for overriding via `messageOverrides`
**Related Issue:** #7860

## Summary
Adds the angular package to our issue templates for: a11y, bugs,
enhancements, and refactors.
**Related Issue:** #7188 

## Summary

Prevents increasing/decreasing the value in `calcite-input-number` on
`blur` via keyboard or mouse
**Related Issue:** N/A

## Summary

Rolls back responsiveness (#7755) in favor of upcoming alert stack UX
(#2835).

See
#7921 (comment)
for more info.
**Related Issue:** N/A

## Summary

@jcfranco I'm running into an issue where once I drag a list-item that
has children, the caret icon disappears.

![Nov-17-2023
14-02-24](https://github.com/Esri/calcite-design-system/assets/1231455/b1791d67-bb7c-4484-83a7-436b5a289bc2)

![Screenshot 2023-11-17 at 2 03
41 PM](https://github.com/Esri/calcite-design-system/assets/1231455/3227db11-febc-417a-8be2-a6954b891cab)

I can't reproduce it with just calcite. Do you think this might fix it?
This PR was automatically generated by the update-browserslist-db GitHub
action

Co-authored-by: jcfranco <jcfranco@users.noreply.github.com>
…splay prop (#7912)

**Related Issue:** #4326 

## Summary

This PR introduces a new `selection-display` property to Combobox to
control the chip display with the available values `all`(default), `fit`
and `single`. This new property only takes effect when `selection-mode`
is `multiple` or `ancestors`.

---------

Co-authored-by: Erik Harper <eriklharper@pm.me>
**Related Issue:** #6694 

## Summary

Enables responsive layout for stepper component.


#### Additional Enhancements:

- stepper element `host` display is changed to `flex` from `grid`
- grid column width will use `minmax( )` instead of fixed fractional
units.
- When none of the stepper item's are selected and the first one is
disabled, the first available enabled stepper will be selected.
…Step in messages (#8222) (#8232)

This reverts commit 213b31d.

---

**Related Issue:** #8222

## Summary

This reverts a breaking change that landed on `main`. Moving forward,
all breaking changes should be installed on the `rc` branch.
**Related Issue:** #8232

## Summary

Downgrade the versions in `package.json` files to ensure the release
goes out as 1x
**Related Issue:** #7912

## Summary

Fixes linting errors introduced by the PR linked above.
**Related Issue:** #8237

## Summary

One more package needs downgrading
🤖 I have created a release *beep* *boop*
---


<details><summary>@esri/eslint-plugin-calcite-components:
0.2.3</summary>

##
[0.2.3](https://github.com/Esri/calcite-design-system/compare/@esri/eslint-plugin-calcite-components@0.2.2...@esri/eslint-plugin-calcite-components@0.2.3)
(2023-11-21)
</details>

<details><summary>@esri/calcite-components: 1.11.0</summary>

##
[1.11.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@1.10.0...@esri/calcite-components@1.11.0)
(2023-11-21)

### Features

* **combobox:** Limit display of selected items with new
selection-display prop
([#7912](#7912))
([58317ae](58317ae))
* **date-picker:** Make component responsive
([#7872](#7872))
([f131218](f131218))
* **input, input-date-picker, input-number, input-text,
input-time-picker:** Truncate value and placeholder when input is narrow
([#8160](#8160))
([533eff3](533eff3))
* **list-item:** Add content-bottom slot for placing content below the
label and description of the component
([#8183](#8183))
([7d400fb](7d400fb))
* **list:** Specify the element types in the `calciteListOrderChange`
event detail.
([#8123](#8123))
([3e81d7e](3e81d7e))
* **pagination:** Introduce responsive design for xxsmall breakpoint
([#8150](#8150))
([ab20eb0](ab20eb0))
* **stepper-item:** Remove support for previousStep and nextStep in
messages
([#8222](#8222))
([213b31d](213b31d))
* **stepper:** Enable responsive layout
([#7744](#7744))
([687ca2b](687ca2b))


### Bug Fixes

* **accordion-item:** Update expanded chevron color
([#8087](#8087))
([d3d7688](d3d7688))
* **action:** Ensure action content is correctly spaced
([#8184](#8184))
([b18dcc8](b18dcc8))
* **action:** Update transparent action styles
([#8194](#8194))
([0f12489](0f12489))
* **block-section:** Wraps long text over to a new line when toggle
switch is displayed
([#8101](#8101))
([3f90780](3f90780))
* **checkbox:** Make label property public
([#8181](#8181))
([d3b9c1f](d3b9c1f))
* **combobox-item:** Hide disabled item icon
([#8095](#8095))
([36552f3](36552f3))
* **input-date-picker:** Fix date-picker wrapper displaying beyond its
bounds
([#8172](#8172))
([01ec024](01ec024))
* **input-number:** Prevents mutating value on blur
([#8226](#8226))
([b89a893](b89a893))
* **input-time-zone:** Fix Indian/Christmas time zone translation
([#8096](#8096))
([d79d591](d79d591))
* **list-item, stack:** Stretch action-menu and handle when placed
inside a list-item or stack.
([#8185](#8185))
([8a16a69](8a16a69))
* **list-item, stack:** Stretch dropdown when placed inside a list-item
or stack
([#8204](#8204))
([05e6b65](05e6b65))
* **list-item:** Adds border between grouped and ungrouped list-items
([#8134](#8134))
([b3c331c](b3c331c))
* **list-item:** Fix rendering of open icon.
([#8207](#8207))
([a6e1766](a6e1766))
* **panel, flow-item:** Remove overflow rule
([#8055](#8055))
([d0c3ed2](d0c3ed2))
* **split-button:** Fix width layout
([#8133](#8133))
([051f332](051f332))

### Dependencies

* The following workspace dependencies were updated
  * devDependencies
* @esri/eslint-plugin-calcite-components bumped from 0.2.3-next.6 to
0.2.3
</details>

<details><summary>@esri/calcite-components-angular: 1.11.0</summary>

## 1.11.0 (2023-11-21)


### Bug Fixes

* **angular:** Publish from the dist directory
([#8151](#8151))
([d813f14](d813f14))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 1.11.0-next.3 to 1.11.0
</details>

<details><summary>@esri/calcite-components-react: 1.11.0</summary>

##
[1.11.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@1.10.0...@esri/calcite-components-react@1.11.0)
(2023-11-21)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 1.11.0-next.3 to 1.11.0
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ben Elan <no-reply@benelan.dev>
…8245)

**Related Issue:** #8243 

## Summary
Prevents increasing/decreasing the value in `<calcite-input
type="number" />` on `blur` using `Tab`
#8240)

**Related Issue:** #8241

## Summary

- Sets a list item as `openable` when a list without any items is
slotted inside it.
- Previously, an empty list was not accounted for.
- Add story
**Related Issue:** #8214 #7979

## Summary

- Update some component `open` handlers to call reposition before open
and after open
  - Previously, they were just calling when open was set to true.
- Update `floating-ui` utility
- Handle device pixel ratio:
https://floating-ui.com/docs/misc#subpixel-and-accelerated-positioning
  - Only set `top`, `left`, and `transform` when the component is open.
- This makes it so that the positioned container is never going to "fly
in" from anywhere.
- Update sortable styles to hide any overflow on dragged elements.
**Related Issue:** #8242

## Summary

- Specifies padding on a list that has no list items inside it
- This allows for easier dragging into the empty list.
- This could be a quick fix for the issue and design could come up with
something better.
- add story
**Related Issue:** n/a

## Summary

Adds a debugger script for calcite-design-tokens in VSCode (launch.json)
Adds snapshot tests to enforce token output
@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Nov 23, 2023
* origin/main: (30 commits)
  test: add token snapshot tests (#8050)
  chore: release next
  fix(color-picker, popover, shell-panel, slider, tooltip): Register events on the window instead of the document (#8247)
  fix(list-item): Reserve space for empty open lists. (#8239)
  fix: dragging floating ui components (#8230)
  fix(list-item): an item with an empty slotted list should be openable. (#8240)
  fix(input): prevents mutating value on `blur` when `type="number"` (#8245)
  chore: release main (#8092)
  chore: downgrade eslint plugin after reverting breaking change (#8238)
  refactor(combobox): fix linting errors (#8235)
  chore: downgrade packages after reverting 2.0.0-next.0 change (#8237)
  chore: release next
  revert: feat(stepper-item)!: remove support for previousStep and nextStep in messages (#8222) (#8232)
  feat(stepper): enable responsive layout (#7744)
  feat(combobox): limit display of selected items with new selection-display prop (#7912)
  chore: release next
  build: update browserslist db (#8218)
  fix(list-item): fix rendering of open icon. (#8207)
  revert: feat(alert): make component responsive (#8195)
  fix(input-number): prevents mutating value on blur (#8226)
  ...
@benelan benelan force-pushed the benelan/sync-main-rc branch from 437ec4d to 82cd085 Compare November 23, 2023 02:13
@benelan benelan added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Nov 23, 2023
@benelan benelan added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Nov 23, 2023
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Nov 23, 2023
@jcfranco jcfranco force-pushed the benelan/sync-main-rc branch from 7a1454a to ac9f4ea Compare November 23, 2023 08:26
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Nov 23, 2023
@benelan
Copy link
Member Author

benelan commented Nov 23, 2023

Installing this with @jcfranco's approval over Teams 🚀

Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👾🕹️

@benelan
Copy link
Member Author

benelan commented Nov 26, 2023

Closing in favor of #8258

@benelan benelan closed this Nov 26, 2023
@benelan benelan deleted the benelan/sync-main-rc branch November 26, 2023 10:16
jcfranco added a commit that referenced this pull request Nov 28, 2023
**Related Issue:** N/A

## Summary

Cherry pick fix from
#8254.

Co-authored-by: Ben Elan <no-reply@benelan.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issues with changes that don't modify src or test files. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.