Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(panel, flow-item): add screenshot tests for overflow (#8028) #8161

Merged
merged 3 commits into from
Nov 18, 2023
Merged

test(panel, flow-item): add screenshot tests for overflow (#8028) #8161

merged 3 commits into from
Nov 18, 2023

Conversation

asangma
Copy link
Contributor

@asangma asangma commented Nov 11, 2023

Related Issue: #8028

Summary

Adds screenshots for panel and flow-item.
Follow-up from #8055

cc @driskull

@github-actions github-actions bot added the testing Issues related to automated or manual testing. label Nov 11, 2023
driskull
driskull approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Nov 13, 2023
@jcfranco
Copy link
Member

@asangma Thanks for adding these tests! ✨🧪✨ If screenshots are looking good, can you mark this ready for review? We can get it merged right after.

@jcfranco jcfranco changed the title test(panel, flowitem): add screenshot tests for overflow (#8028) test(panel, flow-item): add screenshot tests for overflow (#8028) Nov 15, 2023
@asangma asangma marked this pull request as ready for review November 16, 2023 21:16
@asangma asangma requested a review from a team as a code owner November 16, 2023 21:16
@asangma
Copy link
Contributor Author

asangma commented Nov 16, 2023

Thanks @driskull @jcfranco !

@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Nov 18, 2023
@jcfranco jcfranco merged commit 9f7270b into main Nov 18, 2023
@jcfranco jcfranco deleted the asangma/panel-flow-item-screenshots-8028 branch November 18, 2023 06:34
@github-actions github-actions bot added this to the 2023 November Priorities milestone Nov 18, 2023
benelan pushed a commit that referenced this pull request Nov 24, 2023
@asangma @benelan
test(panel, flow-item): add screenshot tests for overflow (#8028) (#8161
8f7e63e 
)

**Related Issue:** #8028 

## Summary
Adds screenshots for panel and flow-item.
Follow-up from #8055

cc @driskull
benelan pushed a commit that referenced this pull request Nov 24, 2023
@asangma @benelan
test(panel, flow-item): add screenshot tests for overflow (#8028) (#8161
91c567f 
)

**Related Issue:** #8028 

## Summary
Adds screenshots for panel and flow-item.
Follow-up from #8055

cc @driskull
benelan pushed a commit that referenced this pull request Nov 26, 2023
@asangma @benelan
test(panel, flow-item): add screenshot tests for overflow (#8028) (#8161
3cddfb9 
)

**Related Issue:** #8028 

## Summary
Adds screenshots for panel and flow-item.
Follow-up from #8055

cc @driskull
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull

Assignees

@asangma asangma

Labels
pr ready for visual snapshots Adding this label will run visual snapshot testing. skip visual snapshots Pull requests that do not need visual regression testing. testing Issues related to automated or manual testing.
Projects
None yet
Milestone
2023 November Priorities
Development

Successfully merging this pull request may close these issues.
3 participants
@asangma @jcfranco @driskull