-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Combobox] Add an option to limit the amount of displayed chips #4326
Comments
One note from a customer. If you pursue the "no individual chips" option and have "# Selected" as the singular chip, please consider swapping "#" with "All" if every item in the list is selected: "1 Selected" -> "2 Selected" -> "All Selected" on a list of 3, for example. |
The displayed selected chips keep growing and occupy too much real estate, hide other components on the UI, it is too crowded for the user to see other items. Please consider options as 1)shrink the display text 2) have a textbox labelled down to show selected items, no displaying chips |
@ashetland and I met on this and discussed some ideas. Here's a link to some of the scratch work we're iterating on for discussion's sake only: https://www.figma.com/file/ujZYHdimnVC3yA2PyYOH85/Epic%3A-Combobox-Redesign?type=design&node-id=43%3A58814&t=q3Gb7wa0njY5GVwU-1 |
Proposing a new Full designs and context with other issues from epic #6720 are available in this Figma file. This property does not affect displayMode Values
NoteChips that display “All selected” or “n selected” or “+n” are not closable. This is to prevent a conflict with the clear-all button. |
There are a few remaining items needed for resolution, including tests and additional team reviews. Reallocated to the November release for inclusion. cc: @brittneytewks |
…splay prop (#7912) **Related Issue:** #4326 ## Summary This PR introduces a new `selection-display` property to Combobox to control the chip display with the available values `all`(default), `fit` and `single`. This new property only takes effect when `selection-mode` is `multiple` or `ancestors`. --------- Co-authored-by: Erik Harper <eriklharper@pm.me>
Installed and assigned for verification. |
Verified in |
…splay prop (#7912) **Related Issue:** #4326 ## Summary This PR introduces a new `selection-display` property to Combobox to control the chip display with the available values `all`(default), `fit` and `single`. This new property only takes effect when `selection-mode` is `multiple` or `ancestors`. --------- Co-authored-by: Erik Harper <eriklharper@pm.me>
…splay prop (#7912) **Related Issue:** #4326 ## Summary This PR introduces a new `selection-display` property to Combobox to control the chip display with the available values `all`(default), `fit` and `single`. This new property only takes effect when `selection-mode` is `multiple` or `ancestors`. --------- Co-authored-by: Erik Harper <eriklharper@pm.me>
…splay prop (#7912) **Related Issue:** #4326 ## Summary This PR introduces a new `selection-display` property to Combobox to control the chip display with the available values `all`(default), `fit` and `single`. This new property only takes effect when `selection-mode` is `multiple` or `ancestors`. --------- Co-authored-by: Erik Harper <eriklharper@pm.me>
Description
The Combobox can often become crowded when many chips are selected.
Propose to add a
limitChips
(name tbd) property that appends all additional chips after that numeric value to a non-dismissible "+n" chip.Questions to answer:
Acceptance Criteria
As a user, I can choose a number of chips to display, after which, all selected items would be appended to a non-dismissible catch-all.
Also note of Aaron's comment
For example, limit-chips="2" would result in:
This would result in a display of <chip (1) ><chip 2 (x) ><+n>
Relevant Info
MUI's "limit tags" https://mui.com/components/autocomplete/#limit-tags
No response
Which Component
Combobox
Example Use Case
My product offers a state-selection Combobox to a user. Often times, a user can select 5+ states, which clutters the combobox and causes my UI to break. I want to limit the amount of chips displayed.
The text was updated successfully, but these errors were encountered: