Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combobox - Make icon/label spacing consistent between dropdown items and selected item #8396

Closed
2 of 6 tasks
rebollin opened this issue Dec 11, 2023 · 8 comments
Closed
2 of 6 tasks

Combobox - Make icon/label spacing consistent between dropdown items and selected item #8396

rebollin opened this issue Dec 11, 2023 · 8 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library regression Issues that are caused by changes in a release, but were working before that. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible.
Milestone
2024-02-15 - Feb ...

Comments

@rebollin
Copy link

Check existing issues

Description

The spacing between the calcite icon used in the combobox component is different than the spacing seen in the dropdown options.
image

Acceptance Criteria

The spacing between the label and icon should be consistent between the selected option and dropdown options

Relevant Info

No response

Which Component

Combobox input

Example Use Case

We just switched to using the combobox in the Update Data modal. We noticed that the spacing is off and not adjustable.

Priority impact

p2 - want for current milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Online
@rebollin rebollin added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Dec 11, 2023
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. ArcGIS Online Issues logged by ArcGIS Online team members. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Dec 11, 2023
@ashetland
Copy link
Contributor

@jcfranco @eriklharper I think this snuck in with the updates from #4326

@ashetland ashetland added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. regression Issues that are caused by changes in a release, but were working before that. and removed enhancement Issues tied to a new feature or request. labels Dec 11, 2023
@macandcheese
Copy link
Contributor

Screenshot 2023-12-11 at 10 26 16 AM

There also seems to be some uneven spacing in Input, may be worth looking at all of these to make sure this is cleared up across the board.

@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 2 Small fix or update, may require updates to tests. labels Dec 11, 2023
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Dec 11, 2023
@jcfranco
Copy link
Member

@macandcheese Great catch. Let's create a separate issue for this since combobox doesn't use calcite-input internally.

@jcfranco
Copy link
Member

@macandcheese It looks like spacing might look different depending on the icon used.

Screenshot 2024-01-29 at 4 09 20 PM

@jcfranco jcfranco self-assigned this Jan 30, 2024
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Jan 30, 2024
@jcfranco jcfranco mentioned this issue Jan 30, 2024
Merged
@eriklharper
Copy link
Contributor

@macandcheese Great catch. Let's create a separate issue for this since combobox doesn't use calcite-input internally.

Perhaps it should?

@jcfranco
Copy link
Member

jcfranco commented Feb 5, 2024

☝️

jcfranco added a commit that referenced this issue Feb 8, 2024
@jcfranco
fix(combobox): avoid inline-start padding on combobox label when icon…
9eb680a 
… is displayed (#8672)

**Related Issue:** #8396 

## Summary

This fixes a spacing regression introduced in
#7912.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Feb 8, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned jcfranco Feb 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 8, 2024

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Feb 13, 2024
@geospatialem
Copy link
Member

Verified in 2.5.0-next.2 with https://codepen.io/geospatialem/pen/XWGyLxg:

image

Elijbet pushed a commit that referenced this issue Feb 15, 2024
@jcfranco @Elijbet
fix(combobox): avoid inline-start padding on combobox label when icon…
06ec437 
… is displayed (#8672)

**Related Issue:** #8396 

## Summary

This fixes a spacing regression introduced in
#7912.
@jcfranco jcfranco added the visual changes Issues with visual changes that are added for consistency, but are not backwards compatible. label Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library regression Issues that are caused by changes in a release, but were working before that. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible.
Projects
None yet
Milestone
2024-02-15 - Feb Maintenance Release
Development

No branches or pull requests
8 participants
@jcfranco @eriklharper @macandcheese @geospatialem @DitwanP @ashetland @brittneytewks @rebollin