Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(combobox): avoid inline-start padding on combobox label when icon is displayed #8672

Merged
merged 5 commits into from
Feb 8, 2024
Merged

fix(combobox): avoid inline-start padding on combobox label when icon is displayed #8672

merged 5 commits into from
Feb 8, 2024

Conversation

jcfranco
Copy link
Member

Related Issue: #8396

Summary

This fixes a spacing regression introduced in #7912.

@jcfranco jcfranco requested a review from a team as a code owner January 30, 2024 07:31
@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jan 30, 2024
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Jan 30, 2024
@jcfranco jcfranco requested a review from eriklharper January 30, 2024 08:03
@eriklharper
Copy link
Contributor

This fixes a spacing regression introduced in #7912.

This wasn't introduced by #7912, that line was there from before based on this diff: (notice line 174 doesn't have any changes):

image

Could we remove that from the description?

@jcfranco
Copy link
Member Author

@eriklharper The regression was introduced in v2.0.0-next.1 and the referenced issue is the only one modifying combobox (see example and changes between v2.0.0-next.0 and v2.0.0-next.1). I think it's caused by the added gap in .grid-input.

driskull
driskull approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcfranco jcfranco added low risk Issues with low risk for consideration in low risk milestones pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Feb 2, 2024
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Feb 6, 2024
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Feb 6, 2024
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Feb 7, 2024
@jcfranco jcfranco merged commit 9eb680a into main Feb 8, 2024
16 checks passed
@jcfranco jcfranco deleted the jcfranco/8396-fix-combobox-input-spacing-with-icon branch February 8, 2024 18:29
@calcite-admin calcite-admin mentioned this pull request Feb 8, 2024
Merged
benelan added a commit that referenced this pull request Feb 8, 2024
@benelan
Merge remote-tracking branch 'origin/main' into benelan/bump-deps
fef8566 
* origin/main:
  fix(combobox): avoid inline-start padding on combobox label when icon is displayed (#8672)
Elijbet pushed a commit that referenced this pull request Feb 15, 2024
@jcfranco @Elijbet
fix(combobox): avoid inline-start padding on combobox label when icon…
06ec437 
… is displayed (#8672)

**Related Issue:** #8396 

## Summary

This fixes a spacing regression introduced in
#7912.
jcfranco pushed a commit that referenced this pull request Feb 15, 2024
@calcite-admin @github-actions
chore: release main (#8706)
24b18c8 
🤖 I have created a release *beep* *boop*
---


<details><summary>@esri/calcite-components: 2.5.0</summary>

##
[2.5.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.4.0...@esri/calcite-components@2.5.0)
(2024-02-15)


### Features

* **stepper:** Add horizontal-single layout
([#8742](#8742))
([c34bc4f](c34bc4f))
* **table:** Add `interactionMode` property to control focus behavior
([#8686](#8686))
([0cb78c0](0cb78c0))
* **table:** Improve accessibility of interaction-mode: static Table
([#8754](#8754))
([eead1b5](eead1b5))
* **tile:** Add responsive layout features
([#8691](#8691))
([f4f872e](f4f872e))


### Bug Fixes

* **color-picker:** Alpha-channel slider scope updates to reflect
current opacity
([#8700](#8700))
([cd0b532](cd0b532))
* **combobox:** Avoid inline-start padding on combobox label when icon
is displayed
([#8672](#8672))
([9eb680a](9eb680a))
* Don't override existing validationMessage when displaying after form
submission
([#8690](#8690))
([3076220](3076220))
* Fix dragging items on a mobile device
([#8751](#8751))
([dc11612](dc11612))
* Fix styling when dragging items on a mobile device
([#8750](#8750))
([7c01e6e](7c01e6e))
* **input, input-number, input-text, text-area:** Ensure all applicable
props are considered in form validation
([#8655](#8655))
([6de8534](6de8534))
* **list-item:** Fix slotted list border styling.
([#8712](#8712))
([855f98d](855f98d))
* **loader:** Optimize animation performance
([#8714](#8714))
([1ed8a01](1ed8a01))
* **preset:** Add back legacy token for calcite-ui-focus-color
([#8694](#8694))
([1d1b933](1d1b933))
* Prevent interaction when component is disabled after initialization
(Firefox)
([#8746](#8746))
([aa84182](aa84182))
* **stepper:** No longer adds default `min-width` for items when
`layout='horizontal'`
([#8758](#8758))
([23a7439](23a7439))


### Reverts

* Fix(panel, flow-item): remove overflow rule
([#8711](#8711))
([21226ce](21226ce))
</details>

<details><summary>@esri/calcite-components-angular: 2.5.0</summary>

##
[2.5.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.4.0...@esri/calcite-components-angular@2.5.0)
(2024-02-15)


### Miscellaneous Chores

* **@esri/calcite-components-angular:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from ^2.5.0-next.6 to ^2.5.0
</details>

<details><summary>@esri/calcite-components-react: 2.5.0</summary>

##
[2.5.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.4.0...@esri/calcite-components-react@2.5.0)
(2024-02-15)


### Miscellaneous Chores

* **@esri/calcite-components-react:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from ^2.5.0-next.6 to ^2.5.0
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@calcite-admin calcite-admin mentioned this pull request May 14, 2024
Merged
@calcite-admin calcite-admin mentioned this pull request May 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull driskull approved these changes

@alisonailea alisonailea alisonailea approved these changes

@eriklharper eriklharper Awaiting requested review from eriklharper

Assignees

@jcfranco jcfranco

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. low risk Issues with low risk for consideration in low risk milestones pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
2024-02-15 - Feb Maintenance Release
Development

Successfully merging this pull request may close these issues.
5 participants
@jcfranco @eriklharper @driskull @alisonailea @geospatialem