Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(stepper): no longer adds default min-width for items when layout='horizontal' #8758

Merged
merged 3 commits into from
Feb 15, 2024
Merged

fix(stepper): no longer adds default min-width for items when layout='horizontal' #8758

merged 3 commits into from
Feb 15, 2024

Conversation

anveshmekala
Copy link
Contributor

@anveshmekala anveshmekala commented Feb 15, 2024 •
edited
Loading

Related Issue: #8461

Summary

When layout="horizontal", allows stepper-item's to shrink with container width.

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Feb 15, 2024
@anveshmekala anveshmekala added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Feb 15, 2024
@anveshmekala anveshmekala added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Feb 15, 2024
@anveshmekala anveshmekala changed the title fix(stepper): no longer displays responsive design when layout='horizontal` fix(stepper): no longer adds default min-width for items when layout='horizontal` Feb 15, 2024
@anveshmekala anveshmekala changed the title fix(stepper): no longer adds default min-width for items when layout='horizontal` fix(stepper): no longer adds default min-width for items when layout='horizontal' Feb 15, 2024
@anveshmekala anveshmekala marked this pull request as ready for review February 15, 2024 17:55
@anveshmekala anveshmekala requested a review from a team as a code owner February 15, 2024 17:55
driskull
driskull approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anveshmekala can you check the formatting settings as I think trailing commas are expected. Otherwise looks good 👍

packages/calcite-components/src/components/stepper/stepper.tsx
@@ -386,7 +388,7 @@ export class Stepper implements LocalizedComponent, T9nComponent {

private resizeObserver = createObserver(
"resize",
(entries) => (this.elWidth = entries[0].contentRect.width),
(entries) => (this.elWidth = entries[0].contentRect.width)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anveshmekala can you check your stylelint/prettier config? I think the previous should be correct.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be handled in followup.

jcfranco
jcfranco approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 📏

Good to merge once linter/formatting comments have been addressed.

@geospatialem geospatialem added the low risk Issues with low risk for consideration in low risk milestones label Feb 15, 2024
@geospatialem
Copy link
Member

geospatialem commented Feb 15, 2024 •
edited
Loading

Added the low risk label for the maintenance release, as the above will revert stepper to the pre-2.0 version of the component.

@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Feb 15, 2024
@anveshmekala anveshmekala merged commit 23a7439 into main Feb 15, 2024
14 checks passed
@anveshmekala anveshmekala deleted the anveshmekala/8461-fix-stepper-horizontal-layout branch February 15, 2024 20:41
@calcite-admin calcite-admin mentioned this pull request Feb 15, 2024
Merged
jcfranco pushed a commit that referenced this pull request Feb 15, 2024
@calcite-admin @github-actions
chore: release main (#8706)
24b18c8 
🤖 I have created a release *beep* *boop*
---


<details><summary>@esri/calcite-components: 2.5.0</summary>

##
[2.5.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.4.0...@esri/calcite-components@2.5.0)
(2024-02-15)


### Features

* **stepper:** Add horizontal-single layout
([#8742](#8742))
([c34bc4f](c34bc4f))
* **table:** Add `interactionMode` property to control focus behavior
([#8686](#8686))
([0cb78c0](0cb78c0))
* **table:** Improve accessibility of interaction-mode: static Table
([#8754](#8754))
([eead1b5](eead1b5))
* **tile:** Add responsive layout features
([#8691](#8691))
([f4f872e](f4f872e))


### Bug Fixes

* **color-picker:** Alpha-channel slider scope updates to reflect
current opacity
([#8700](#8700))
([cd0b532](cd0b532))
* **combobox:** Avoid inline-start padding on combobox label when icon
is displayed
([#8672](#8672))
([9eb680a](9eb680a))
* Don't override existing validationMessage when displaying after form
submission
([#8690](#8690))
([3076220](3076220))
* Fix dragging items on a mobile device
([#8751](#8751))
([dc11612](dc11612))
* Fix styling when dragging items on a mobile device
([#8750](#8750))
([7c01e6e](7c01e6e))
* **input, input-number, input-text, text-area:** Ensure all applicable
props are considered in form validation
([#8655](#8655))
([6de8534](6de8534))
* **list-item:** Fix slotted list border styling.
([#8712](#8712))
([855f98d](855f98d))
* **loader:** Optimize animation performance
([#8714](#8714))
([1ed8a01](1ed8a01))
* **preset:** Add back legacy token for calcite-ui-focus-color
([#8694](#8694))
([1d1b933](1d1b933))
* Prevent interaction when component is disabled after initialization
(Firefox)
([#8746](#8746))
([aa84182](aa84182))
* **stepper:** No longer adds default `min-width` for items when
`layout='horizontal'`
([#8758](#8758))
([23a7439](23a7439))


### Reverts

* Fix(panel, flow-item): remove overflow rule
([#8711](#8711))
([21226ce](21226ce))
</details>

<details><summary>@esri/calcite-components-angular: 2.5.0</summary>

##
[2.5.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.4.0...@esri/calcite-components-angular@2.5.0)
(2024-02-15)


### Miscellaneous Chores

* **@esri/calcite-components-angular:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from ^2.5.0-next.6 to ^2.5.0
</details>

<details><summary>@esri/calcite-components-react: 2.5.0</summary>

##
[2.5.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.4.0...@esri/calcite-components-react@2.5.0)
(2024-02-15)


### Miscellaneous Chores

* **@esri/calcite-components-react:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from ^2.5.0-next.6 to ^2.5.0
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@anveshmekala anveshmekala mentioned this pull request Feb 15, 2024
Merged
benelan added a commit that referenced this pull request Feb 15, 2024
@benelan
Merge remote-tracking branch 'origin/main' into benelan/bump-deps
6e14643 
* origin/main: (22 commits)
  fix: ensure ui-icons are copied from correct path (#8761)
  build(changelog): fix synced version group name (#8762)
  chore: release main (#8706)
  fix(stepper): no longer adds default `min-width` for items when `layout='horizontal'` (#8758)
  build(deps): update dependency @floating-ui/dom to v1.6.3 (#8759)
  chore: release next
  feat(table): Improve accessibility of interaction-mode: static Table (#8754)
  chore: release next
  fix: fix dragging items on a mobile device (#8751)
  build(deps): update dependency @esri/calcite-ui-icons to v3.26.4 (#8752)
  chore: release next
  fix: prevent interaction when component is disabled after initialization (Firefox) (#8746)
  fix: fix styling when dragging items on a mobile device (#8750)
  chore: release next
  feat(stepper): add horizontal-single layout (#8742)
  revert: fix(panel, flow-item): remove overflow rule (#8711)
  refactor(input): tidy up input spec test (#8733)
  chore: improve doc for createBreakpointStories helper (#8739)
  chore: release next
  feat(table): Add `interactionMode` property to control focus behavior (#8686)
  ...
anveshmekala added a commit that referenced this pull request Feb 20, 2024
@anveshmekala
style(stepper,stepper-item): lint code (#8760)
5ada606 
**Related Issue:** # N/A

## Summary

Restores trailingComma removed in #8758
@calcite-admin calcite-admin mentioned this pull request May 14, 2024
Merged
@calcite-admin calcite-admin mentioned this pull request May 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfranco jcfranco jcfranco approved these changes

@driskull driskull driskull approved these changes

Assignees

@anveshmekala anveshmekala

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. low risk Issues with low risk for consideration in low risk milestones pr ready for visual snapshots Adding this label will run visual snapshot testing. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
2024-02-15 - Feb Maintenance Release
Development

Successfully merging this pull request may close these issues.
4 participants
@anveshmekala @geospatialem @jcfranco @driskull