feat(tile): add responsive layout features #8691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ayout options with all possible variants
…s in the shadowRoot to force using css variables to override themeable settings. Removing tailwind usage, and adding a couple component tokens to get things started
…dth just to make sure the entire tile conforms to size of whatever is calculated on the host
… when used inside tile group. Adding more tile-group css to control the layout per design spec. Got tiles to match height in row tracks, just need to figure out a way to make them match on wrapped rows
…t of largest tile. adding tile group story file to start
jcfranco
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨
🟨🟦🟨🟨🟨🟦🟦🟦🟦🟨🟦🟦🟦🟦🟦🟨🟦🟨🟨🟨🟦🟨🟦🟨
🟨🟦🟨🟨🟨🟦🟨🟨🟨🟨🟨🟨🟦🟨🟨🟨🟦🟦🟨🟦🟦🟨🟦🟨
🟨🟦🟨🟨🟨🟦🟨🟦🟦🟨🟨🟨🟦🟨🟨🟨🟦🟨🟦🟨🟦🟨🟦🟨
🟨🟦🟨🟨🟨🟦🟨🟨🟦🟨🟨🟨🟦🟨🟨🟨🟦🟨🟨🟨🟦🟨🟨🟨
🟨🟦🟦🟦🟨🟦🟦🟦🟦🟨🟨🟨🟦🟨🟨🟨🟦🟨🟨🟨🟦🟨🟦🟨
🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨
@alisonailea can you take another look at the CSS prop changes? 🙇♂️
macandcheese
reviewed
Feb 7, 2024
SkyeSeitz
approved these changes
Feb 7, 2024
Merged
Elijbet
pushed a commit
that referenced
this pull request
Feb 15, 2024
**Related Issues:** #6690 #6662 ## Summary This PR adds responsive layout features and some design improvements to the Tile component, including: - Tile: `min` and `max` inline-size (width) for all 3 scales - Tile: `alignment` property, supporting `start` and `center` Other improvements include refactoring Tile to remove the deprecated `ConditionalSlotComponent` interface and improving style encapsulation to allow more defined control of theming with css custom properties. --------- Co-authored-by: Erik Harper <eriklharper@pm.me>
jcfranco
pushed a commit
that referenced
this pull request
Feb 15, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 2.5.0</summary> ## [2.5.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.4.0...@esri/calcite-components@2.5.0) (2024-02-15) ### Features * **stepper:** Add horizontal-single layout ([#8742](#8742)) ([c34bc4f](c34bc4f)) * **table:** Add `interactionMode` property to control focus behavior ([#8686](#8686)) ([0cb78c0](0cb78c0)) * **table:** Improve accessibility of interaction-mode: static Table ([#8754](#8754)) ([eead1b5](eead1b5)) * **tile:** Add responsive layout features ([#8691](#8691)) ([f4f872e](f4f872e)) ### Bug Fixes * **color-picker:** Alpha-channel slider scope updates to reflect current opacity ([#8700](#8700)) ([cd0b532](cd0b532)) * **combobox:** Avoid inline-start padding on combobox label when icon is displayed ([#8672](#8672)) ([9eb680a](9eb680a)) * Don't override existing validationMessage when displaying after form submission ([#8690](#8690)) ([3076220](3076220)) * Fix dragging items on a mobile device ([#8751](#8751)) ([dc11612](dc11612)) * Fix styling when dragging items on a mobile device ([#8750](#8750)) ([7c01e6e](7c01e6e)) * **input, input-number, input-text, text-area:** Ensure all applicable props are considered in form validation ([#8655](#8655)) ([6de8534](6de8534)) * **list-item:** Fix slotted list border styling. ([#8712](#8712)) ([855f98d](855f98d)) * **loader:** Optimize animation performance ([#8714](#8714)) ([1ed8a01](1ed8a01)) * **preset:** Add back legacy token for calcite-ui-focus-color ([#8694](#8694)) ([1d1b933](1d1b933)) * Prevent interaction when component is disabled after initialization (Firefox) ([#8746](#8746)) ([aa84182](aa84182)) * **stepper:** No longer adds default `min-width` for items when `layout='horizontal'` ([#8758](#8758)) ([23a7439](23a7439)) ### Reverts * Fix(panel, flow-item): remove overflow rule ([#8711](#8711)) ([21226ce](21226ce)) </details> <details><summary>@esri/calcite-components-angular: 2.5.0</summary> ## [2.5.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.4.0...@esri/calcite-components-angular@2.5.0) (2024-02-15) ### Miscellaneous Chores * **@esri/calcite-components-angular:** Synchronize undefined versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.5.0-next.6 to ^2.5.0 </details> <details><summary>@esri/calcite-components-react: 2.5.0</summary> ## [2.5.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.4.0...@esri/calcite-components-react@2.5.0) (2024-02-15) ### Miscellaneous Chores * **@esri/calcite-components-react:** Synchronize undefined versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.5.0-next.6 to ^2.5.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Merged
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues: #6690 #6662
Summary
This PR adds responsive layout features and some design improvements to the Tile component, including:
minandmaxinline-size (width) for all 3 scalesalignmentproperty, supportingstartandcenterOther improvements include refactoring Tile to remove the deprecated
ConditionalSlotComponentinterface and improving style encapsulation to allow more defined control of theming with css custom properties.