Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ListItem: an item with an empty slotted list should have the open caret #8241

Closed
2 of 6 tasks
driskull opened this issue Nov 21, 2023 · 2 comments
Closed
2 of 6 tasks

ListItem: an item with an empty slotted list should have the open caret #8241

driskull opened this issue Nov 21, 2023 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 2 Small fix or update, may require updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2023 November Pri...

Comments

@driskull
Copy link
Member

Check existing issues

Actual Behavior

an item with an empty slotted list does not get the open caret button

Expected Behavior

an item with an empty slotted list should have the open caret

Reproduction Sample

https://codepen.io/driskull/pen/MWLVZpZ?editors=1000

Reproduction Steps

  1. Open the sample
  2. The item should have a care to open the item
  3. Notice it does not.

Reproduction Version

1.10

Relevant Info

No response

Regression?

No response

Priority impact

p2 - want for current milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Maps SDK for JavaScript
@driskull driskull added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Nov 21, 2023
@driskull driskull self-assigned this Nov 21, 2023
@driskull driskull added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Nov 21, 2023
@driskull driskull added this to the 2023 November Priorities milestone Nov 21, 2023
@github-actions github-actions bot added ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone calcite-components Issues specific to the @esri/calcite-components package. labels Nov 21, 2023
@driskull driskull added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 2 Small fix or update, may require updates to tests. and removed needs triage Planning workflow - pending design/dev review. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone calcite-components Issues specific to the @esri/calcite-components package. labels Nov 21, 2023
@driskull driskull mentioned this issue Nov 21, 2023
Merged
driskull added a commit that referenced this issue Nov 21, 2023
@driskull
fix(list-item): an item with an empty slotted list should be openable. (
d615b39 
#8240)

**Related Issue:** #8241

## Summary

- Sets a list item as `openable` when a list without any items is
slotted inside it.
- Previously, an empty list was not accounted for.
- Add story
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Nov 21, 2023
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned driskull Nov 21, 2023
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Nov 22, 2023 •
edited
Loading

Verified on the main branch.Screenshot 2023-11-21 at 4 03 53 PM

@DitwanP DitwanP removed the 3 - installed Issues that have been merged to master branch and are ready for final confirmation. label Nov 22, 2023
@DitwanP DitwanP added the 4 - verified Issues that have been released and confirmed resolved. label Nov 22, 2023
@DitwanP DitwanP closed this as completed Nov 22, 2023
benelan pushed a commit that referenced this issue Nov 24, 2023
@driskull @benelan
fix(list-item): an item with an empty slotted list should be openable. (
0bcb486 
#8240)

**Related Issue:** #8241

## Summary

- Sets a list item as `openable` when a list without any items is
slotted inside it.
- Previously, an empty list was not accounted for.
- Add story
benelan pushed a commit that referenced this issue Nov 24, 2023
@driskull @benelan
fix(list-item): an item with an empty slotted list should be openable. (
b057f64 
#8240)

**Related Issue:** #8241

## Summary

- Sets a list item as `openable` when a list without any items is
slotted inside it.
- Previously, an empty list was not accounted for.
- Add story
benelan pushed a commit that referenced this issue Nov 26, 2023
@driskull @benelan
fix(list-item): an item with an empty slotted list should be openable. (
6f5e6d8 
#8240)

**Related Issue:** #8241

## Summary

- Sets a list item as `openable` when a list without any items is
slotted inside it.
- Previously, an empty list was not accounted for.
- Add story
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 2 Small fix or update, may require updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2023 November Priorities
Development

No branches or pull requests
3 participants
@driskull @geospatialem @DitwanP