-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Contact Us Link Reload Issue (#146) #148
Open
wtfashwin
wants to merge
112
commits into
main
Choose a base branch
from
dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Linkedin Section
Update InfiniteCarousel
Update About Section
Corrected responsiveness in feature section
fixing build error [BUG]
changed next.config.js
* Convert_Blog_Page_to_Event_Page * Update_Feature_Section_
…f-Contact-Us-Navbar
…n project card component (#113)
* hotfix changed the video * feat: add legal notice and terms of service markdown files, and update package.json dependencies * feat: update dependencies and enhance footer component with syntax highlighting --------- Co-authored-by: yashksaini-coder <ys3853428@gmail.com>
* Delete src/app/icon.ico * Add files via upload * Delete src/app/icon1.ico * Add files via upload * added favicon and justified text, removed lagging robot friend
* Delete src/app/icon.ico * Add files via upload * Delete src/app/icon1.ico * Add files via upload * added favicon and justified text, removed lagging robot friend * Build error removal with template litrals * added C4GT and linked footer * Add files via upload
* All docs changes done * Add files via upload * Add files via upload
* fix navbar tab not stay highted in dark mode * fix navbar tab not stay highted in dark mode * add yarn lock file ini .ginignore * yarn lock remove
devsayanR
reviewed
Feb 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MAVRICK-1 @Manaregr8
Please check once if ok then merge it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Contact Us button on About page now uses client-side routing. Resolves #146
Description
This pull request addresses issue #146, where the "Contact Us" button on the About page was causing a full page reload instead of using client-side routing. This was due to the button being implemented with a standard
<a>
tag instead of the Next.js<Link>
component.The fix involved replacing the
<a>
tag with<Link>
fromnext/link
, ensuring that the navigation is handled by the client-side router. This provides a smoother and more efficient user experience, preventing unnecessary page reloads.Dependencies:
next/link
(already a core dependency of Next.js)Fixes #146
Type of change
Test Configuration: