Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legal Notice Popup added (Closes #121) #128

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

Harshit457
Copy link
Contributor

@Harshit457 Harshit457 commented Feb 9, 2025

Description

Added a Legal Notice Popup Component that displays the legal notice when the "Legal Notice" link is clicked. The popup includes a close button to dismiss the notice. This feature enhances the user experience by allowing users to view legal details without navigating away.
Also, made some code formatting improvements for better readability.

Fixes #121

Type of change

  • New feature (non-breaking change which adds functionality)

Test Configuration:

  • Firmware version: N/A
  • Hardware: N/A
  • Toolchain: N/A
  • SDK: N/A

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshot

Legal Notice popup

@Harshit457
Copy link
Contributor Author

Harshit457 commented Feb 9, 2025

@Durgesh4993 @MAVRICK-1 Please Review This PR

@Harshit457
Copy link
Contributor Author

@Durgesh4993 @MAVRICK-1 please review this PR i want to create a new PR

@MAVRICK-1 MAVRICK-1 merged commit 06523b6 into DEVRhylme-Foundation:dev Feb 10, 2025
1 check failed
@MAVRICK-1
Copy link
Member

MAVRICK-1 commented Feb 10, 2025

@Durgesh4993 points

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request IWOC2025 Medium
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add Legal Notice Popup
3 participants