-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Highlighter Not Working in Dark Mode #142
Conversation
there is a yarn.lock file , should i put it into gitignore |
@devsayanR can you plz review this PR |
@Chayan8837 yes put the yarn.lock to .gitignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Chayan8837 add the file yarn.lock
into .gitignore file
done @devsayanR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is fine
@MAVRICK-1 check once
@Chayan8837 from next time when you will contribute any code create your branch first, do not code into the dev branch. |
Ok I will follow this and think you
…On Sat, 22 Feb 2025, 21:40 Sayan Rakshit, ***@***.***> wrote:
@Chayan8837 <https://github.com/Chayan8837> from next time when you will
contribute any code create your branch first, do not code into the dev
branch.
—
Reply to this email directly, view it on GitHub
<#142 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BCWKCLSQHBJTF4WSHCJXA6L2RCOPVAVCNFSM6AAAAABXO2M2XKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZWGI4DENRRHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: devsayanR]*devsayanR* left a comment
(DEVRhylme-Foundation/new-website#142)
<#142 (comment)>
@Chayan8837 <https://github.com/Chayan8837> from next time when you will
contribute any code create your branch first, do not code into the dev
branch.
—
Reply to this email directly, view it on GitHub
<#142 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BCWKCLSQHBJTF4WSHCJXA6L2RCOPVAVCNFSM6AAAAABXO2M2XKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZWGI4DENRRHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Description
This PR fixes an issue where the text highlighter was not applying correctly in dark mode. The text-primary class was not being applied as expected when pathUrl === menuItem?.path. This caused the highlighted menu item to remain the default white color instead of switching to the primary theme color.
Fixes #139
Type of change
Please delete options that are not relevant.
Test Configuration:
Checklist: