Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Highlighter Not Working in Dark Mode #142

Merged
merged 7 commits into from
Feb 22, 2025

Conversation

Chayan8837
Copy link
Contributor

@Chayan8837 Chayan8837 commented Feb 19, 2025

Description

This PR fixes an issue where the text highlighter was not applying correctly in dark mode. The text-primary class was not being applied as expected when pathUrl === menuItem?.path. This caused the highlighted menu item to remain the default white color instead of switching to the primary theme color.

Screenshot from 2025-02-19 22-20-04

Fixes #139

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Chayan8837
Copy link
Contributor Author

there is a yarn.lock file , should i put it into gitignore

@MAVRICK-1
Copy link
Member

@devsayanR can you plz review this PR

@MAVRICK-1
Copy link
Member

@Chayan8837 yes put the yarn.lock to .gitignore

@MAVRICK-1 MAVRICK-1 requested a review from devsayanR February 22, 2025 15:47
Copy link
Member

@devsayanR devsayanR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Chayan8837 add the file yarn.lock into .gitignore file

@Chayan8837 Chayan8837 marked this pull request as draft February 22, 2025 15:55
@Chayan8837 Chayan8837 marked this pull request as ready for review February 22, 2025 16:00
@Chayan8837
Copy link
Contributor Author

done @devsayanR

Copy link
Member

@devsayanR devsayanR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is fine
@MAVRICK-1 check once

@devsayanR devsayanR merged commit bba8b19 into DEVRhylme-Foundation:dev Feb 22, 2025
@devsayanR
Copy link
Member

@Chayan8837 from next time when you will contribute any code create your branch first, do not code into the dev branch.

@Chayan8837
Copy link
Contributor Author

Chayan8837 commented Feb 22, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEATURE] Navbar tabs should stay highlighted based on the active route(dark theme)
3 participants